AMT-Cheif
/
drift
mirror of https://github.com/AMT-Cheif/drift.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix reading triggers in old schema files (#2191)

This commit is contained in:
Simon Binder 2022-12-10 22:57:03 +01:00
parent 0bb7f79607
commit 1c06873403
No known key found for this signature in database
GPG Key ID: 7891917E4147B8C0
4 changed files with 74 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drift_dev/lib/src/services/schema/schema_files.dart
View File

@ -282,14 +282,18 @@ class SchemaReader {
final name = content['name'] as String;
final sql = content['sql'] as String;
// Old versions of this file used to have a typo when serializing body
// references.
final bodyReferences =
(content['references_in_body'] ?? content['refences_in_body']) as List;
return DriftTrigger(
_id(name),
_declaration,
on: on,
onWrite: UpdateKind.delete,
references: [
for (final bodyRef in content['references_in_body'] as List)
_existingEntity(bodyRef)
for (final bodyRef in bodyReferences) _existingEntity(bodyRef)
],
createStmt: sql,
writes: const [],

32
examples/app/test/generated_migrations/schema_v1.dart
View File

@ -9,9 +9,11 @@ class Categories extends Table with TableInfo {
Categories(this.attachedDatabase, [this._alias]);
late final GeneratedColumn<int> id = GeneratedColumn<int>(
'id', aliasedName, false,
hasAutoIncrement: true,
type: DriftSqlType.int,
requiredDuringInsert: false,
defaultConstraints: 'PRIMARY KEY AUTOINCREMENT');
defaultConstraints:
GeneratedColumn.constraintIsAlways('PRIMARY KEY AUTOINCREMENT'));
late final GeneratedColumn<String> name = GeneratedColumn<String>(
'name', aliasedName, false,
type: DriftSqlType.string, requiredDuringInsert: true);
@ -35,9 +37,6 @@ class Categories extends Table with TableInfo {
Categories createAlias(String alias) {
return Categories(attachedDatabase, alias);
}
@override
bool get dontWriteConstraints => false;
}
class TodoEntries extends Table with TableInfo {
@ -47,9 +46,11 @@ class TodoEntries extends Table with TableInfo {
TodoEntries(this.attachedDatabase, [this._alias]);
late final GeneratedColumn<int> id = GeneratedColumn<int>(
'id', aliasedName, false,
hasAutoIncrement: true,
type: DriftSqlType.int,
requiredDuringInsert: false,
defaultConstraints: 'PRIMARY KEY AUTOINCREMENT');
defaultConstraints:
GeneratedColumn.constraintIsAlways('PRIMARY KEY AUTOINCREMENT'));
late final GeneratedColumn<String> description = GeneratedColumn<String>(
'description', aliasedName, false,
type: DriftSqlType.string, requiredDuringInsert: true);
@ -73,9 +74,6 @@ class TodoEntries extends Table with TableInfo {
TodoEntries createAlias(String alias) {
return TodoEntries(attachedDatabase, alias);
}
@override
bool get dontWriteConstraints => false;
}
class TextEntries extends Table with TableInfo, VirtualTableInfo {
@ -95,7 +93,7 @@ class TextEntries extends Table with TableInfo, VirtualTableInfo {
@override
String get actualTableName => 'text_entries';
@override
Set<GeneratedColumn> get $primaryKey => <GeneratedColumn>{};
Set<GeneratedColumn> get $primaryKey => const {};
@override
Never map(Map<String, dynamic> data, {String? tablePrefix}) {
throw UnsupportedError('TableInfo.map in schema verification code');
@ -106,8 +104,6 @@ class TextEntries extends Table with TableInfo, VirtualTableInfo {
return TextEntries(attachedDatabase, alias);
}
@override
bool get dontWriteConstraints => true;
@override
String get moduleAndArgs =>
'fts5(description, content=todo_entries, content_rowid=id)';
@ -120,14 +116,24 @@ class DatabaseAtV1 extends GeneratedDatabase {
late final TodoEntries todoEntries = TodoEntries(this);
late final TextEntries textEntries = TextEntries(this);
late final Trigger todosInsert = Trigger(
'CREATE TRIGGER todos_insert AFTER INSERT ON todo_entries BEGIN\n INSERT INTO text_entries(rowid, description) VALUES (new.id, new.description);\nEND;',
'CREATE TRIGGER todos_insert AFTER INSERT ON todo_entries BEGIN INSERT INTO text_entries ("rowid", description) VALUES (new.id, new.description);END',
'todos_insert');
@override
Iterable<TableInfo<Table, dynamic>> get allTables =>
Iterable<TableInfo<Table, Object?>> get allTables =>
allSchemaEntities.whereType<TableInfo<Table, Object?>>();
@override
List<DatabaseSchemaEntity> get allSchemaEntities =>
[categories, todoEntries, textEntries, todosInsert];
@override
StreamQueryUpdateRules get streamUpdateRules => const StreamQueryUpdateRules(
[
WritePropagation(
on: TableUpdateQuery.onTableName('todo_entries',
limitUpdateKind: UpdateKind.delete),
result: [],
),
],
);
@override
int get schemaVersion => 1;
}

32
examples/app/test/generated_migrations/schema_v2.dart
View File

@ -9,9 +9,11 @@ class Categories extends Table with TableInfo {
Categories(this.attachedDatabase, [this._alias]);
late final GeneratedColumn<int> id = GeneratedColumn<int>(
'id', aliasedName, false,
hasAutoIncrement: true,
type: DriftSqlType.int,
requiredDuringInsert: false,
defaultConstraints: 'PRIMARY KEY AUTOINCREMENT');
defaultConstraints:
GeneratedColumn.constraintIsAlways('PRIMARY KEY AUTOINCREMENT'));
late final GeneratedColumn<String> name = GeneratedColumn<String>(
'name', aliasedName, false,
type: DriftSqlType.string, requiredDuringInsert: true);
@ -35,9 +37,6 @@ class Categories extends Table with TableInfo {
Categories createAlias(String alias) {
return Categories(attachedDatabase, alias);
}
@override
bool get dontWriteConstraints => false;
}
class TodoEntries extends Table with TableInfo {
@ -47,9 +46,11 @@ class TodoEntries extends Table with TableInfo {
TodoEntries(this.attachedDatabase, [this._alias]);
late final GeneratedColumn<int> id = GeneratedColumn<int>(
'id', aliasedName, false,
hasAutoIncrement: true,
type: DriftSqlType.int,
requiredDuringInsert: false,
defaultConstraints: 'PRIMARY KEY AUTOINCREMENT');
defaultConstraints:
GeneratedColumn.constraintIsAlways('PRIMARY KEY AUTOINCREMENT'));
late final GeneratedColumn<String> description = GeneratedColumn<String>(
'description', aliasedName, false,
type: DriftSqlType.string, requiredDuringInsert: true);
@ -76,9 +77,6 @@ class TodoEntries extends Table with TableInfo {
TodoEntries createAlias(String alias) {
return TodoEntries(attachedDatabase, alias);
}
@override
bool get dontWriteConstraints => false;
}
class TextEntries extends Table with TableInfo, VirtualTableInfo {
@ -98,7 +96,7 @@ class TextEntries extends Table with TableInfo, VirtualTableInfo {
@override
String get actualTableName => 'text_entries';
@override
Set<GeneratedColumn> get $primaryKey => <GeneratedColumn>{};
Set<GeneratedColumn> get $primaryKey => const {};
@override
Never map(Map<String, dynamic> data, {String? tablePrefix}) {
throw UnsupportedError('TableInfo.map in schema verification code');
@ -109,8 +107,6 @@ class TextEntries extends Table with TableInfo, VirtualTableInfo {
return TextEntries(attachedDatabase, alias);
}
@override
bool get dontWriteConstraints => true;
@override
String get moduleAndArgs =>
'fts5(description, content=todo_entries, content_rowid=id)';
@ -123,14 +119,24 @@ class DatabaseAtV2 extends GeneratedDatabase {
late final TodoEntries todoEntries = TodoEntries(this);
late final TextEntries textEntries = TextEntries(this);
late final Trigger todosInsert = Trigger(
'CREATE TRIGGER todos_insert AFTER INSERT ON todo_entries BEGIN\n INSERT INTO text_entries(rowid, description) VALUES (new.id, new.description);\nEND;',
'CREATE TRIGGER todos_insert AFTER INSERT ON todo_entries BEGIN INSERT INTO text_entries ("rowid", description) VALUES (new.id, new.description);END',
'todos_insert');
@override
Iterable<TableInfo<Table, dynamic>> get allTables =>
Iterable<TableInfo<Table, Object?>> get allTables =>
allSchemaEntities.whereType<TableInfo<Table, Object?>>();
@override
List<DatabaseSchemaEntity> get allSchemaEntities =>
[categories, todoEntries, textEntries, todosInsert];
@override
StreamQueryUpdateRules get streamUpdateRules => const StreamQueryUpdateRules(
[
WritePropagation(
on: TableUpdateQuery.onTableName('todo_entries',
limitUpdateKind: UpdateKind.delete),
result: [],
),
],
);
@override
int get schemaVersion => 2;
}

43
examples/app/test/generated_migrations/schema_v3.dart
View File

@ -9,9 +9,11 @@ class Categories extends Table with TableInfo {
Categories(this.attachedDatabase, [this._alias]);
late final GeneratedColumn<int> id = GeneratedColumn<int>(
'id', aliasedName, false,
hasAutoIncrement: true,
type: DriftSqlType.int,
requiredDuringInsert: false,
defaultConstraints: 'PRIMARY KEY AUTOINCREMENT');
defaultConstraints:
GeneratedColumn.constraintIsAlways('PRIMARY KEY AUTOINCREMENT'));
late final GeneratedColumn<String> name = GeneratedColumn<String>(
'name', aliasedName, false,
type: DriftSqlType.string, requiredDuringInsert: true);
@ -35,9 +37,6 @@ class Categories extends Table with TableInfo {
Categories createAlias(String alias) {
return Categories(attachedDatabase, alias);
}
@override
bool get dontWriteConstraints => false;
}
class TodoEntries extends Table with TableInfo {
@ -47,9 +46,11 @@ class TodoEntries extends Table with TableInfo {
TodoEntries(this.attachedDatabase, [this._alias]);
late final GeneratedColumn<int> id = GeneratedColumn<int>(
'id', aliasedName, false,
hasAutoIncrement: true,
type: DriftSqlType.int,
requiredDuringInsert: false,
defaultConstraints: 'PRIMARY KEY AUTOINCREMENT');
defaultConstraints:
GeneratedColumn.constraintIsAlways('PRIMARY KEY AUTOINCREMENT'));
late final GeneratedColumn<String> description = GeneratedColumn<String>(
'description', aliasedName, false,
type: DriftSqlType.string, requiredDuringInsert: true);
@ -57,7 +58,8 @@ class TodoEntries extends Table with TableInfo {
'category', aliasedName, true,
type: DriftSqlType.int,
requiredDuringInsert: false,
defaultConstraints: 'REFERENCES categories (id)');
defaultConstraints:
GeneratedColumn.constraintIsAlways('REFERENCES categories (id)'));
late final GeneratedColumn<DateTime> dueDate = GeneratedColumn<DateTime>(
'due_date', aliasedName, true,
type: DriftSqlType.dateTime, requiredDuringInsert: false);
@ -78,9 +80,6 @@ class TodoEntries extends Table with TableInfo {
TodoEntries createAlias(String alias) {
return TodoEntries(attachedDatabase, alias);
}
@override
bool get dontWriteConstraints => false;
}
class TextEntries extends Table with TableInfo, VirtualTableInfo {
@ -100,7 +99,7 @@ class TextEntries extends Table with TableInfo, VirtualTableInfo {
@override
String get actualTableName => 'text_entries';
@override
Set<GeneratedColumn> get $primaryKey => <GeneratedColumn>{};
Set<GeneratedColumn> get $primaryKey => const {};
@override
Never map(Map<String, dynamic> data, {String? tablePrefix}) {
throw UnsupportedError('TableInfo.map in schema verification code');
@ -111,8 +110,6 @@ class TextEntries extends Table with TableInfo, VirtualTableInfo {
return TextEntries(attachedDatabase, alias);
}
@override
bool get dontWriteConstraints => true;
@override
String get moduleAndArgs =>
'fts5(description, content=todo_entries, content_rowid=id)';
@ -134,7 +131,7 @@ class DatabaseAtV3 extends GeneratedDatabase {
'CREATE TRIGGER todos_update AFTER UPDATE ON todo_entries BEGIN INSERT INTO text_entries (text_entries, "rowid", description) VALUES (\'delete\', new.id, new.description);INSERT INTO text_entries ("rowid", description) VALUES (new.id, new.description);END',
'todos_update');
@override
Iterable<TableInfo<Table, dynamic>> get allTables =>
Iterable<TableInfo<Table, Object?>> get allTables =>
allSchemaEntities.whereType<TableInfo<Table, Object?>>();
@override
List<DatabaseSchemaEntity> get allSchemaEntities => [
@ -146,5 +143,25 @@ class DatabaseAtV3 extends GeneratedDatabase {
todosUpdate
];
@override
StreamQueryUpdateRules get streamUpdateRules => const StreamQueryUpdateRules(
[
WritePropagation(
on: TableUpdateQuery.onTableName('todo_entries',
limitUpdateKind: UpdateKind.delete),
result: [],
),
WritePropagation(
on: TableUpdateQuery.onTableName('todo_entries',
limitUpdateKind: UpdateKind.delete),
result: [],
),
WritePropagation(
on: TableUpdateQuery.onTableName('todo_entries',
limitUpdateKind: UpdateKind.delete),
result: [],
),
],
);
@override
int get schemaVersion => 3;
}