Remove outdated todo entries

This commit is contained in:
Simon Binder 2019-07-01 21:27:09 +02:00
parent a45d73a6cf
commit 3dddc6993a
No known key found for this signature in database
GPG Key ID: 7891917E4147B8C0
4 changed files with 7 additions and 6 deletions

View File

@ -1113,9 +1113,9 @@ mixin _$SomeDaoMixin on DatabaseAccessor<TodoDb> {
Variable.withInt(user),
],
readsFrom: {
users,
todosTable,
sharedTodos
sharedTodos,
users
}).map((rows) => rows.map(_rowToTodoEntry).toList());
}
}

View File

@ -41,7 +41,6 @@ class InferredResultSet {
/// If the result columns of a SELECT statement exactly match one table, we
/// can just use the data class generated for that table. Otherwise, we'd have
/// to create another class.
// todo implement this check
final SpecifiedTable matchingTable;
final List<ResultColumn> columns;
final Map<ResultColumn, String> _dartNames = {};

View File

@ -1,6 +1,7 @@
import 'package:moor_generator/src/model/specified_column.dart';
import 'package:moor_generator/src/model/specified_table.dart';
import 'package:moor_generator/src/options.dart';
import 'package:moor_generator/src/utils/string_escaper.dart';
import 'package:moor_generator/src/writer/data_class_writer.dart';
import 'package:moor_generator/src/writer/update_companion_writer.dart';
import 'package:moor_generator/src/writer/utils.dart';
@ -117,8 +118,8 @@ class TableWriter {
}
if (column.customConstraints != null) {
// todo should we worry about escaping this string?
additionalParams['\$customConstraints'] = "'${column.customConstraints}'";
additionalParams['\$customConstraints'] =
asDartLiteral(column.customConstraints);
}
if (column.defaultArgument != null) {

View File

@ -62,7 +62,8 @@ class SqlEngine {
..accept(ReferenceResolver(context))
..accept(TypeResolvingVisitor(context));
} catch (e) {
// todo should we do now? Mostly, everything
// todo should we do now? AFAIK, everything that causes an exception
// is added as an error contained in the context.
}
return context;