AMT-Cheif
/
drift
mirror of https://github.com/AMT-Cheif/drift.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve type inference around IS expressions

This commit is contained in:
Simon Binder 2020-12-14 17:48:50 +01:00
parent 5db10342b0
commit efe0df519b
No known key found for this signature in database
GPG Key ID: 7891917E4147B8C0
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sqlparser/lib/src/analysis/types/resolving_visitor.dart
View File

@ -338,8 +338,11 @@ class TypeResolver extends RecursiveVisitor<TypeExpectation, void> {
@override
void visitIsExpression(IsExpression e, TypeExpectation arg) {
session._checkAndResolve(e, const ResolvedType.bool(), arg);
session._hintNullability(e, false);
session
.._checkAndResolve(e, const ResolvedType.bool(), arg)
.._addRelation(HaveSameType(e.left, e.right))
.._hintNullability(e, false);
visitChildren(e, const NoTypeExpectation());
}

1
sqlparser/test/analysis/types2/misc_cases_test.dart
View File

@ -31,6 +31,7 @@ const Map<String, ResolvedType?> _types = {
'SELECT (3 * 4) = ?': ResolvedType(type: BasicType.int),
'SELECT (3 / 4) = ?': ResolvedType(type: BasicType.int),
'SELECT (3 / 4.) = ?': ResolvedType(type: BasicType.real),
'SELECT NULLIF(3, 3) IS ?': ResolvedType(type: BasicType.int, nullable: true),
'SELECT CURRENT_TIMESTAMP = ?': ResolvedType(type: BasicType.text),
"SELECT COALESCE(NULL, 'foo') = ?": ResolvedType(type: BasicType.text),
'SELECT NULLIF(3, 4) = ?': ResolvedType(type: BasicType.int, nullable: true),