2ee506ac03
Fix typo.
2015-08-31 14:05:38 +09:00
768adfb337
Fix "restore" further by accepting --mpk
2015-08-31 13:52:18 +09:00
2d05e7d891
Merge the network and network_proxy
2015-08-31 12:00:38 +09:00
4d6a0f29ee
Fix 'restore' command line to take -C.
2015-08-31 11:34:44 +09:00
92e0744470
Refactoring of daemon:
...
* gui and daemon are in the same process
* commands that require network are sent to the daemon
* open only one gui window per wallet
2015-08-30 11:31:51 +02:00
351272f0b6
Small optimization for large wallets
...
Previously the verifier job would scan all transactions in
unverified_tx each time it ran.
Nothing was ever removed from this map; it would essentially
be the full set of transactions.
As the job runs about 10 times a second, for a wallet with 500 txs
this would be 5,000 useless loops a second.
This patch makes unverified_tx be simply the set of confirmed
transactions that haven't yet been verified. txs are added once
confirmed, and removed once verified. Hence it will almost always be
empty.
2015-08-28 12:39:19 +09:00
478bde8afa
Access to unverified_tx no longer needs a lock
...
Once the proxy thread jobs are created only they access this,
and they all run under the proxy thread, so there is no contention.
2015-08-28 11:10:50 +09:00
578a83fa30
show error message raised during sign_transaction. see issue #1422
2015-08-27 08:22:02 +02:00
695aebaa80
Clean up imports; use self.print_error
2015-08-27 15:12:54 +09:00
91049c8af8
Protect proxy against ill-formed server responses
2015-08-27 15:09:00 +09:00
9455815ad0
Merge requested_merkle and merkle_roots.
2015-08-26 17:12:40 +09:00
b64c42b1eb
Make the verifier a thread job instead of a thread
...
The verifier, like the synchronizer, now runs as part of the
network proxy thread.
2015-08-26 17:07:36 +09:00
01491dd1d0
Have network_proxy use ThreadJob framework
...
Rename WalletSynchronizer to Synchronizer so that diagnostic messages,
which are based on class name, still refer to Synchronizer.
2015-08-26 16:50:40 +09:00
56654ec4e9
Introduce thread job framework.
...
This is a cleaner generalization of the functionality added
to network_proxy.py a few months ago, whereby jobs can be
added and removed from a thread's main loop. This allows
us to cut down on unnecessary threads.
A follow-up patch will update the proxy to this framework.
2015-08-26 16:41:12 +09:00
eb66289314
test_transaction: add BCDataStream test case
2015-08-25 15:51:22 +03:00
33b78551a3
test_transaction: add Transaction.sweep() test case
2015-08-25 15:21:44 +03:00
6a7e145053
test_transaction: add test suite for lib.transaction module
2015-08-25 12:05:49 +03:00
a056f9804b
Notify when a chunk of headers is validated
...
And a couple of cosmetic changes.
This should fix #1379 .
2015-08-25 14:27:53 +09:00
3c3d96f69e
test_mnemonic: add tests for mnemonics
2015-08-24 17:35:17 +03:00
bb97624de2
test_account: add test case for OldAccount
2015-08-24 10:57:41 +03:00
893849ab39
test_account: add test case for BIP32_Account
2015-08-24 10:57:41 +03:00
a92ca583bd
test_interface: fix check_host_name test
2015-08-24 10:02:10 +03:00
49a48d52ac
Use select.
2015-08-22 14:03:08 +02:00
85c0dda1a9
version 2.5
2015-08-22 13:42:53 +02:00
234471b70c
version 2.4.3 and release notes
2015-08-22 11:42:18 +02:00
678ec84267
Add Chinese Simplified wordlist
2015-08-20 23:18:47 +09:00
37034bdf7f
listunspent: convert value to float
2015-08-19 11:10:55 +02:00
6bbfef5198
add timestamp to history command output, convert value to float
2015-08-19 11:04:06 +02:00
93b674982e
fix tx strip
2015-08-18 16:33:51 +02:00
f583fcfedb
do not import dns on android
2015-08-18 12:15:56 +02:00
3f1e4ae3b1
strip spaces from raw tx
2015-08-18 10:17:53 +02:00
4a514c7638
version 2.4.2 and release notes
2015-08-17 13:20:45 +02:00
fa9ce51685
deprecate dumpprivkeys
2015-08-16 16:30:55 +02:00
02e81a3655
read command line arguments from stdin if '-' is passed
2015-08-16 16:11:52 +02:00
5686499eae
fix #1400
2015-08-16 13:50:03 +02:00
bfae04e6f0
Improved in network callbacks:
...
* Pass arguments
* Don't redraw history when a tx is verified.
* Fix new tx notifications.
2015-08-16 11:36:23 +02:00
438bc94dce
fix #1399
2015-08-16 11:25:23 +02:00
ede7423bf2
Merge pull request #1397 from romanz/master
...
Add tests to bitcoin.py and ripemd.py
2015-08-15 13:42:59 +02:00
e0939348c3
minimize calls to estimated_fee
2015-08-15 12:31:57 +02:00
6232a0b76c
speedup fee computation when collecting small inputs
2015-08-15 10:02:47 +02:00
ac8e792c58
test_ripemd: add simple test case for ripemd module
2015-08-15 09:52:27 +03:00
fa412c3a86
test_bitcoin: add tests for int packing
2015-08-15 09:41:20 +03:00
175fef2d56
test_bitcoin: add test case for seeds
2015-08-15 09:20:01 +03:00
8a3e5032b1
Merge pull request #1389 from romanz/master
...
remove unused code
2015-08-14 16:48:23 +02:00
d69da1ef43
add/remove transaction: remove unused tx_height parameter
2015-08-14 15:30:00 +02:00
e9b346ed29
add command for master private key
2015-08-14 15:23:50 +02:00
abc7429b0f
bitcoin: remove multiple imports
2015-08-09 19:35:02 +03:00
b5854b6e8b
account: remove unused variables
2015-08-09 19:35:02 +03:00
a3a01be8ce
remove unused code
2015-08-09 19:02:04 +03:00
c3991091de
move init_qt hook
2015-08-07 20:06:31 +02:00
6b87256795
sign tx with empty scriptSig inputs
2015-08-07 17:11:42 +02:00
5f413aca1c
rm unneeded float conversion
2015-08-07 14:36:43 +02:00
c844d22a19
synchronous_get: return -> raise exception
2015-08-07 12:22:47 +02:00
85d9b8aa8d
fix: dePem cert before parsing
2015-08-07 11:58:59 +02:00
ca3c320ef4
simplify x509 constructor
2015-08-07 11:39:30 +02:00
713fa00d86
fix estimatefee for daemon
2015-08-07 10:54:32 +02:00
65c7dfafbc
check alias in signrequest
2015-08-07 09:00:00 +02:00
34e3261efd
fix estimate_fee
2015-08-06 19:26:34 +02:00
714445aba8
fix: wallet.is_used
2015-08-06 19:19:25 +02:00
e93ff18776
rename help -> commands
2015-08-06 15:52:38 +02:00
aadffa0c8f
check_ssl_config: verify pubkey
2015-08-05 20:59:51 +02:00
a9e74da11c
check SSL certificate in config dialog
2015-08-05 20:49:45 +02:00
43880d452e
dynamic fees
2015-08-05 15:45:28 +02:00
476d198be9
fix missing occurences of X509.parse
2015-08-04 18:31:08 +02:00
e8d30129ea
replace TLSLite dependency with minimal RSA implementation
2015-08-04 18:16:06 +02:00
4c8408b42d
Print reason for failure to connect headers
...
Used to fail just with a "header didn't connect" message, now
it gives a reason too.
2015-08-01 13:09:52 +09:00
8ae64064b6
dont silence dns errors
2015-07-31 21:56:22 +02:00
380bccacf0
request_queue.put should never block, because maxsize is not set
2015-07-31 20:11:12 +02:00
963ec4ca3e
dnssec: don't call get_default_resolver
2015-07-31 20:02:55 +02:00
9938fbd160
version 2.4.1
2015-07-31 14:52:16 +02:00
465d1dfd8b
fix #1378
2015-07-31 14:51:48 +02:00
2ec19e7528
fix bugs with ecdsa/dnssec
2015-07-31 13:49:14 +02:00
4731418af9
Use ssl.PROTOCOL_TLSv1 on client side to avoid SSLv23
2015-07-30 20:40:05 +02:00
77b0e7be5e
network: initial status should be 'unknown', distinct from 'connecting'
2015-07-30 11:32:16 +02:00
348a9b0e21
fix imports, cleanup
2015-07-29 22:16:36 +02:00
e96a0945ca
do not use pycrypto for DNSSEC validation
2015-07-29 22:06:44 +02:00
5fbd7553ed
interface: fix check_host_name() pattern matching
...
The existing pattern matching code:
val.find('*.') == 0 and name.find(val[1:]) + len(val[1:]) == len(name)
will return True in the following case:
val = '*.host.com'
name = 'blah.org'
since string.find() will return -1, len(val[1:]) == 9 and len(name) == 8.
2015-07-26 18:11:30 +03:00
70d59bbe06
Merge pull request #1376 from romanz/master
...
util: fix small typo at parse_URI() and update its unittests
2015-07-25 17:19:28 +02:00
96c3513cb2
add character encoding declaration to index.html
2015-07-25 12:50:00 +02:00
cbf13197e2
websocket: hostname
2015-07-25 12:31:35 +02:00
e9f5e6866d
check www dir on daemon start
2015-07-25 12:25:47 +02:00
87d3fafa22
util: fix small typo at parse_URI() and update its unittests
2015-07-25 12:41:37 +03:00
0c5bfb8c26
print -> util.print_error
2015-07-24 14:23:03 +02:00
e6924d9912
prevent websocket closing with balnk target
2015-07-24 13:30:51 +02:00
3da148f406
use local copy of javascript files
2015-07-24 12:36:08 +02:00
f0e6f5bf64
Merge branch 'master' of github.com:spesmilo/electrum
2015-07-24 11:39:31 +02:00
18d145cced
add websocket to webpages
2015-07-24 11:39:12 +02:00
0f2d4bd375
Add bitflyer.jp block explorer
2015-07-24 15:17:15 +09:00
41d9c94821
don't add bip70 suffixes
2015-07-22 16:00:08 +02:00
6d54512627
clearrequests command; minor type fix
2015-07-22 15:46:53 +02:00
508b5373ac
minor fixes
2015-07-22 15:33:50 +02:00
8960b16e09
more sanitization
2015-07-22 15:28:43 +02:00
b813ba0bdd
sanitize timestamp and expiration in requests
2015-07-22 15:24:15 +02:00
37c07278d5
update var names
2015-07-22 09:37:17 +02:00
8f507d2afd
change var name
2015-07-22 09:24:44 +02:00
acbd434f76
cleanup request signing
2015-07-22 09:06:03 +02:00
a8ed934a7f
fix bug with make_unsigned_request
2015-07-21 16:30:25 +02:00
a6c65b8997
change internal format of requests
2015-07-21 12:26:37 +02:00
2c1fb1e37c
do not raise exception if uri has an unknown key
2015-07-21 11:54:45 +02:00
e77f0c98e7
extend bitcoin: URI with signature data, instead of serialized format
2015-07-21 11:40:55 +02:00
9c30ad3dd5
extend bitcoin URIs with signed payment requests passed directly
2015-07-18 18:42:56 +02:00
e879cb4552
https download of headers
2015-07-18 11:17:19 +02:00
380e072842
fix bug with import_key
2015-07-18 11:00:41 +02:00
8792301846
restrict to *. only, add DN support also
2015-07-17 11:17:43 +07:00
3c563b85ad
adjust comment about wildcards
2015-07-17 04:22:39 +07:00
59c231808f
add wildcard ssl support
2015-07-17 04:03:40 +07:00
e7ea3e5d01
Add two more block explorers
...
chain.so and biteasy.com
2015-07-15 20:58:19 +09:00
471cab6089
do not base64encode signatures in requests
2015-07-14 16:37:04 +02:00
677f235e4b
Fix typo.
2015-07-14 09:00:59 +09:00
f320178db9
no empty amount in bip70
2015-07-13 21:37:41 +02:00
6fa7f57f10
express expiration dates in natural language
2015-07-13 20:47:11 +02:00
aa7b9af501
minor fix
2015-07-12 08:13:09 +02:00
da55d9ed6e
payment requests: cmdline fixes
2015-07-11 21:09:56 +02:00
fbc23a61a3
fix cmdline addrequest
2015-07-11 21:03:02 +02:00
dff8f6b338
rework paymentrequest methods
2015-07-11 20:26:30 +02:00
35aba0c14b
show alias satus in gui after fetch
2015-07-11 18:14:00 +02:00
4578777c29
network: Update default servers
2015-07-10 19:35:02 +02:00
cb2bc54f96
store and display signatures of own requests
2015-07-09 14:15:30 +02:00
71243c2a57
dnssec: fix hash, and skip SOA
2015-07-09 09:02:39 +02:00
094ce2e4b3
add DNSSEC chain validation
2015-07-08 19:20:54 +02:00
538846ee0b
remove incorrect dnssec validation
2015-07-08 15:14:00 +02:00
f3c4a55e77
add dnssec verification to payment requests
2015-07-07 08:59:03 +02:00
e9f3b21519
Fix transaction update
2015-07-06 00:22:19 +02:00
15f592f022
trezor multisig: build xpub from pubkey
2015-07-05 23:29:36 +02:00
0368a2cd5e
fix bug from #1281
2015-07-05 18:16:33 +02:00
b0f7411a0a
check and fix history on startup
2015-07-05 17:29:41 +02:00
e2c19ff871
fix #1344
2015-07-05 16:19:44 +02:00
9947173183
fix tx deserialize
2015-07-05 13:29:02 +02:00
5c2235e54b
make tx.deserialize preserve existing inputs
2015-07-04 17:33:18 +02:00
c224a9ad9d
enable multisig with trezor
2015-07-04 12:10:52 +02:00
7933ac4324
reformatting
2015-07-04 12:07:33 +02:00
250bb03034
Merge pull request #1337 from kyuupichan/auto_connect
...
Suggested auto_connect daemon mode fix for #1336
2015-07-03 09:58:57 +02:00
9e84d12a6f
Merge pull request #1339 from kyuupichan/daemon
...
Avoid string representation issues, fix #1338
2015-07-03 09:41:21 +02:00
930304e46b
Remove apparently dead code.
2015-07-03 13:57:42 +09:00
389c8e8a8d
Only write config file once.
2015-07-03 13:56:17 +09:00
3a50c78a47
Avoid string representation issues
...
Caused by unicode vs non-unicode strings.
Fixes #1338
2015-07-03 13:53:15 +09:00
5acbe00cbf
Suggested auto_connect daemon mode fix for #1336
2015-07-03 11:50:53 +09:00
65e7667eba
build reverse history index, to know when a transaction can be removed
2015-07-02 16:07:04 +02:00
616becd9a8
move openalias from plugins to core
2015-07-02 12:44:53 +02:00
fa2de58c90
redo fixes for 1324
2015-07-02 09:22:59 +02:00
ccd07c6a80
Merge branch 'synchronizer-unthread' of https://github.com/kyuupichan/electrum into kyuupichan-synchronizer-unthread
2015-07-02 09:20:51 +02:00
0c37009cdb
fix is_address (forgot p2sh)
2015-07-02 08:53:17 +02:00
c0858f314f
Merge branch 'master' of git://github.com/spesmilo/electrum
2015-07-02 08:48:53 +02:00
cf5328b143
do not accet testnet addresses in bitcoin.is_address
2015-07-02 08:48:48 +02:00
daee02e22d
commands: fix typo
...
rename "sec" to "privkey"
2015-07-01 18:15:35 +03:00
9c06bee8c7
interface: slow_parse() is not defined for X509
2015-07-01 16:54:11 +03:00
604d5d432c
sanitize server at the interface level (follow up to issue #1330 )
2015-07-01 09:09:00 +02:00
0ac3aebb88
fix proxy setting issue #1330
2015-07-01 08:45:47 +02:00
d0308010da
Client-side fix for #1324
...
Print messages rather than throwing uncaught exceptions that kill the
thread.
I cannot fix the server side as I have no way to test it.
2015-06-30 23:14:05 +09:00
523aa7c380
update restore multisig to add type
2015-06-27 16:12:15 -04:00
765ef338ec
fix multisig seed detection
2015-06-27 21:53:55 +02:00
118052d815
v2.4 will require protocol v0.10
2015-06-27 15:22:34 +02:00
56b3c98332
generic m of n multisig
2015-06-27 12:43:29 +02:00
37d5e3b42a
version 2.3.3, release notes
2015-06-26 14:35:22 +02:00
fdd43bd5ad
fix issue in f307b18546
2015-06-24 09:35:54 +02:00
f307b18546
Merge pull request #1268 from kyuupichan/blockchain_nothread
...
Make the blockchain class not a thread
2015-06-24 09:00:52 +02:00
56f8fc62f9
fix 1312
2015-06-23 16:58:21 +02:00
f894af90d7
fix deserialize_proxy. fixes #1309
2015-06-23 14:22:10 +02:00
74d26f5bdc
better error message
2015-06-15 10:52:03 +02:00
0682695da9
version 2.3.2
2015-06-14 11:39:41 +02:00
00af3b394b
Merge pull request #1280 from kyuupichan/BIP-LI01
...
Implement BIP-LI01.
2015-06-14 08:08:55 +02:00
ec9cdfaf48
blockchain: restore call to set_local_height, forgotten in previous commit
2015-06-13 16:45:42 +02:00
d09a10e0f7
fix is_used for unmatured tx
2015-06-13 16:40:50 +02:00
90076b0b79
util: add print_msg() method to DaemonThread
...
it is used by at synchornizer.py, line 173
2015-06-13 16:58:08 +03:00
c324d21107
transaction: added missing import
...
for "traceback.print_exc(file=sys.stdout)" statement at line 361
2015-06-13 16:58:08 +03:00
cb4d3a78b4
verifier: fix typo
2015-06-13 16:58:08 +03:00
12feb4cf9c
Merge pull request #1294 from romanz/master
...
bitcoin: remove dead code
2015-06-13 13:25:28 +02:00
6bb9ee0cf7
bitcoin: remove dead code
2015-06-13 08:34:56 +03:00
7a3ddfc6a4
version 2.3.1
2015-06-12 20:22:02 +02:00
10740470cc
fix requests_dir bug
2015-06-12 20:18:06 +02:00
d75d3fdf5b
fix --pending option
2015-06-12 20:15:53 +02:00
42084a3610
improve docstrings
2015-06-12 10:34:45 +02:00
1fbbd5d65d
require network to show request status
2015-06-12 09:58:29 +02:00
cbcb799eec
add filtering options for listrequests
2015-06-12 09:46:21 +02:00
f3597f865b
--force option for addrequest
2015-06-11 20:44:38 +02:00
db6c69f0da
Merge pull request #1289 from Kefkius/patch-1
...
Fix typo in param_descriptions
2015-06-11 13:47:06 +02:00
a103f59686
new flags for listaddresses
2015-06-11 12:49:14 +02:00
317a9de71d
check amount before calling make_payment_request
2015-06-11 12:32:52 +02:00
ba78093e2e
getalias: no check
2015-06-11 12:08:38 +02:00
b6e4013a9d
Fix typo in param_descriptions
...
heigh --> height
2015-06-11 04:55:08 -04:00
e5b5e8d0f4
comment our ackrequest
2015-06-11 10:50:25 +02:00
d6cdc085ea
fix #1283
2015-06-11 10:03:26 +02:00
16344b43af
fix issue #1282
2015-06-11 08:56:07 +02:00
e31ac7905d
Clear address cache when interface changes. Send requests only if interface is connected.
2015-06-11 02:10:06 +02:00
28f440350d
Fix request handling.
...
Handle local requests immediately.
Defer those requiring connectivity until we have an interface.
2015-06-11 08:31:19 +09:00
5714d9f4fc
shorter docstrings
2015-06-10 23:48:36 +02:00
145bf5cf0a
rename decodetx and sendtx commands. merge mktx and payto commands.
2015-06-10 23:21:25 +02:00
e067e34313
make global options: -w and -o
2015-06-10 22:29:31 +02:00
2b9b42d5f7
Merge pull request #1286 from kyuupichan/remove_urllib2
...
Use requests instead - SSL handling is superior
2015-06-10 21:15:27 +02:00
e517321f76
Network: fix handle_requests, must process requests even if we are not connected
2015-06-10 18:26:03 +02:00
6ea04e2d47
Network: Fix switch_to_interface (check that interface is connected)
2015-06-10 18:24:57 +02:00
060e3aa23e
plugins: call load_wallet in install wizard
2015-06-10 12:40:08 +02:00
a3ad32bd91
Use requests instead - SSL handling is superior
2015-06-10 16:15:00 +09:00
479a6f84e7
paymentrequest: add headers to http request
2015-06-10 09:04:34 +02:00
8bccf7b2db
replace httplib with requests
2015-06-10 08:29:50 +02:00
ee6b718ea4
better message
2015-06-09 16:10:44 +02:00
f70a996619
fix trezor initialiation hook (pass window in load_wallet)
2015-06-09 09:58:40 +02:00
e8db8983ec
Make the synchronizer not a thread.
...
The synchronizer's work is done from the network proxy's main loop.
A minor problem with the old synchronizer was that it considered itself
out of date if the network was out of date. This was too generic: the
network can have pending requests unrelated to the synchronizer. This
resulted in the synchronizer often unnecessarily flipping the wallet
between up-to-date and not-up-to-date, and causing unnecessary calls
to wallet.save_transactions(). This was observable when opening the
network dialog box: frequently just opening it would cause a wallet
status change and transaction flush, simply because the network dialog
sends a get_parameters() request. This rework of the synchronizer does
not have that issue.
2015-06-09 08:41:31 +09:00
70037b89a9
version 2.3 and release notes
2015-06-08 18:40:21 +02:00
8995cdbf14
rename fields: 'time' -> 'timestamp', payment_requests
2015-06-08 13:36:35 +02:00
357c405ac6
fix publish_request
2015-06-08 13:21:13 +02:00
d367930113
amount is in satoshis
2015-06-08 13:20:42 +02:00
9bd94e5062
refactor payment requests
2015-06-08 12:51:45 +02:00
572a463806
reason->memo
2015-06-08 08:06:38 +02:00
3bb00f0006
store json record requests
2015-06-07 21:52:23 +02:00
bf755f8ac0
jsonrpc interface
2015-06-07 19:11:54 +02:00
48e53498db
improve requests
2015-06-07 18:44:33 +02:00
98bea614d8
Implement BIP-LI01.
...
No more need to randomly place change.
2015-06-06 22:25:40 +09:00
0b874b2bb0
Readding pending_transactions_for_notifications, needed by the gui.
2015-06-05 08:56:55 +02:00
a2445aa27d
Remove unused vars and imports.
2015-06-05 11:54:00 +09:00
2f2e468d0a
SocketPipe shouldn't close the socket.
...
This is a layering violation - the SocketPipe doesn't own
the socket and provides no other way to close the socket, leading
to unnecessary complexity like that in interface.py.
I looked at deamon.py and NetworkProxy - the two other users,
and they don't close the sockets explicitly, just let them be
garbage collected.
2015-06-04 16:30:59 +09:00
90d7179d73
Merge pull request #1276 from kyuupichan/need_interface
...
Need an interface to process a request.
2015-06-04 05:57:04 +02:00
caebdd0819
Need an interface to process a request.
...
Occasionally triggered with a race at start up, typically from
the verifier requesting a merkle root.
2015-06-04 11:22:57 +09:00
fc23b0f490
fix #1274
2015-06-03 14:18:49 +02:00
ec795ba3c0
fix var name
2015-06-03 11:39:44 +02:00
ab60da89ac
Add a help group for config variables. Change name of ssl variables
2015-06-03 11:34:52 +02:00
34360bddfb
add missing definition of COIN
2015-06-03 10:25:21 +02:00
0ddd94b5b3
remove forgotten debugging statement
2015-06-03 10:03:55 +02:00
ca62df89d4
fix: set_config
2015-06-03 10:02:12 +02:00
d85a11173d
verify: return earlier if request is empty
2015-06-03 09:34:35 +02:00
cbeeedcca2
Add note for commands that are not SPV; fix format_request parameter
2015-06-03 09:12:38 +02:00
fb6a74e034
fix typo
2015-06-02 16:49:21 +02:00
3188ff05a3
fix is_watching_only
2015-06-02 16:41:32 +02:00
b832a5cea4
Merge pull request #1272 from kyuupichan/if-socket
...
Fix couple of minor socket issues
2015-06-02 16:28:42 +02:00
088d8e8415
show request status
2015-06-02 11:36:06 +02:00
ab2f80c3e0
Fix couple of minor socket issues
...
Set timeout and socket options on all simple sockets. At present
some code paths can miss it, such as when the SSL certificate is
CA-signed.
Add a missing check for failure.
2015-06-02 18:13:36 +09:00
e4946cf26e
setconfig: return False on error
2015-06-02 11:05:21 +02:00
31c4849566
url_rewrite
2015-06-02 10:41:36 +02:00
b83b7fa5c8
cmd line: format payment requests
2015-06-02 10:25:39 +02:00
2727df962e
requests: store path not url
2015-06-02 09:56:10 +02:00
b9e4825422
fix request_dir variable
2015-06-02 09:37:54 +02:00
514ea6aa8c
doc for addrequest
2015-06-02 09:31:24 +02:00
d41785c783
save payment requests in requests_dir
2015-06-02 09:18:39 +02:00
d16714a1db
Make the blockchain class not a thread
...
Remove interface communication out of blockchain.py
into network.py. network.py handles protocol requests
for headers and chunks. blockchain.py continues to
handle their analysis and verification.
If an interface provides a header chain that doesn't
connect, it is dismissed, as per a previous TODO comment.
This removes a thread and another source of timeouts.
I see no performance issues with this when truncating the
blockchain.
Rename 'result' to 'header' for clarity.
2015-06-01 20:53:42 +09:00
832369d7c4
Merge pull request #1270 from kyuupichan/if-tristate
...
Make interface status tri-state.
2015-06-01 13:09:40 +02:00
0938299e9b
move payment requests logic to wallet, add basic commands
2015-06-01 13:02:09 +02:00
76355e66c8
Make interface status tri-state.
...
This allows us to distinguish between connecting and connected
state in interface.py (used to be done in network.py but that
had other issues).
This means we don't switch to a connecting server, and get_interfaces()
does not report connecting ones.
2015-06-01 18:22:03 +09:00
03e53a5e01
Create a constant for 100000000 and use it
...
Use same name as is in bitcoind.
Note that one of the constants in text.py had the wrong number
of zeroes previously...
2015-06-01 14:53:36 +09:00
4d9be9a6d2
commands: use decorator to register commands
2015-06-01 06:10:06 +02:00
7e20901e3b
read command defaults
2015-06-01 00:17:50 +02:00
c3f82fd69c
fix cmd descriptions
2015-05-31 23:23:13 +02:00
f8eb68458d
use docstrings
2015-05-31 23:17:44 +02:00
ddd6a58cc7
commands: extract params and options from arguments
2015-05-31 22:42:34 +02:00
1d5c6bdc2d
deserialized option for mktx
2015-05-31 18:21:14 +02:00
4042ac69ec
fix varname
2015-05-31 18:03:58 +02:00
9c76a0232e
distinction between 'destination' and 'address'
2015-05-31 18:02:09 +02:00
200563c4e9
fix sweep fee
2015-05-31 17:49:59 +02:00
c4d822b0cf
add 'unsigned' option
2015-05-31 17:38:57 +02:00
ee20910c65
fix signtransaction flags
2015-05-31 17:21:02 +02:00
a3cd33fe03
add option to disable dnssec
2015-05-31 16:43:27 +02:00
9be94c74d2
add getalias command
2015-05-31 15:06:52 +02:00
8513dd2c63
fix cmd names
2015-05-31 15:00:56 +02:00
c006678289
fix indent
2015-05-31 15:00:43 +02:00
5a76a0fc95
hook openalias plugin to command line interface
2015-05-31 14:42:16 +02:00
ee5f499fc1
use contacts in command line
2015-05-31 14:10:52 +02:00
5cd3bfedb6
always pass coins to wallet.make_unsigned_transactions. fix \! shortcut in commands
2015-05-31 11:31:41 +02:00
0531f00c80
support for \! shortcut in command line
2015-05-31 10:40:12 +02:00
0caa29784c
separate param_descriptions and improve help messages
2015-05-31 10:03:53 +02:00
cc610d352f
merge signtxwithwallet and signtxwithkey
2015-05-31 09:28:47 +02:00
1d5f04c588
fix function name
2015-05-31 08:49:47 +02:00
53a3f00389
add --deserialize option to gettransaction
2015-05-31 08:20:09 +02:00
9acc0e4ed0
minor formatting
2015-05-31 08:06:20 +02:00
2167b9e93d
Merge pull request #1264 from kyuupichan/unify_interfaces
...
Remove pending_servers, self.interfaces is now the complete set of
2015-05-31 08:02:47 +02:00
bd6bfcea0e
Merge pull request #1267 from kyuupichan/spendable_coins
...
get_spendable_coins and frozen addrs
2015-05-31 07:53:43 +02:00
320f9a3790
get_spendable_coins and frozen addrs
...
Two callers of get_spendable_coins were removing frozen addrs
before calling. Put that functionality in the function.
We shouldn't be able to send_from a frozen address. This was
possible in the current release because logic assumed a two-element
tuple was returned when it is now three-element. Fix that too.
Command line options listunspent and createrawtransaction currently
ignore frozen addresses. I'm not sure that's right but I've preserved
that behaviour.
With this patch only the wallet class refers to self.frozen_addresses;
other clients use is_frozen() now.
2015-05-31 14:07:50 +09:00
00ded10810
fix: freeze does not need password
2015-05-31 06:45:51 +02:00
0f29984f07
Speed up freezing and unfreezing of many addresses
...
Speedup mainly from writing to storage only once.
Make frozen_addresses a set in memory, as sets give cleaner
code and are more efficient.
Minor change in behaviour: command line freezing used to return
False if the address isn't in the wallet OR the address was already
frozen. Now it returns more like a success code: it returns False
only if the address isn't in the wallet regardless of frozen state.
Similarly for unfreezing.
2015-05-31 11:54:21 +09:00
d6f4b57d64
help function for python console
2015-05-30 19:13:28 +02:00
92a158b910
proper handling of arg_types. add more options for listaddresses
2015-05-30 18:49:58 +02:00
2ab9272f52
fix positional arguments
2015-05-30 16:14:56 +02:00
966bb3c15f
separate help and description for commands
2015-05-30 14:07:48 +02:00
0ad73b0899
better help
2015-05-30 13:38:05 +02:00
d2f3e3f349
fix cmdline listcontacts
2015-05-30 12:35:58 +02:00
2b66f0d459
Remove pending_servers, self.interfaces is now the complete set of
...
interfaces we have created.
Existing code has the concept of pending servers, where a connection
thread is started but has not sent a connection notification, and
and interfaces which have received the notification.
This separation caused a couple of minor bugs, and given the cleaner
semantics of unifying the two I don't think the separation is beneficial.
The bugs:
1) When stopping the network, we only stopped the connected interface
threads, not the pending ones. This would leave Python hanging
on exit if we don't make them daemon threads.
2) start_interface() did not check pending servers before starting
a new thread. Some of its callers did, but not all, so it was
possible to initiate two threads to one server and "lose" one thread.
Apart form fixing the above two issues, unification causes one more
change in semantics: we are now willing to switch to a connection
that is pending (we don't switch to failed interfaces). I don't
think that is a problem: if it times out we'll just switch
again when we receive the disconnect notification, and previously the
fact that an interface was in the interaces dictionary wasn't a
guarantee the connection was good anyway: we might not have processed
a pending disconnection notification.
2015-05-30 17:42:11 +09:00
4eaff5678d
Avoid change address reuse if possible
...
As discussed on #electrum yesterday.
Increase change gap limit to 6.
Choose the next unused change address, if any, otherwise pick
one at random from the gap limit.
2015-05-30 17:07:29 +09:00
48f98f75db
improve help messages
2015-05-30 09:43:42 +02:00
bf1aa6263c
add description to command parameters
2015-05-30 09:36:54 +02:00
5dd535f915
move global options to parent, to avoid order-sensitive parsing
2015-05-30 07:58:47 +02:00
701527df20
fix -P option
2015-05-30 06:56:45 +02:00
6201133c48
fix #1263
2015-05-30 06:38:46 +02:00
a0c7219db0
rm debugging print
2015-05-29 19:30:00 +02:00
2e67ca43e8
use csv instead of mkmanytx
2015-05-29 19:26:06 +02:00
3ddbbc1008
Parse arguments with argparse.
...
Move parser to commands.py
2015-05-29 19:24:50 +02:00
3195b94f28
Merge pull request #1257 from kyuupichan/update_fee
...
Fix calls to update_fee
2015-05-28 19:34:04 +02:00
a3dd51f476
rm failing test
2015-05-28 15:43:50 +02:00
9dc8393cf6
move import test to wallet.py
2015-05-28 15:39:26 +02:00
3fdfd23ca9
add check in importprivkey
2015-05-28 15:27:22 +02:00
05cb9975cb
Fix calls to update_fee
...
Fees should be recalculated when send_from changes.
Fees should be recalculated when editing fee preference, but
only save to storage when leaving the fee per kb widget.
No need to emit a textEdited signal; the widget does that already
(with the effect that we used to call update_fee() twice).
2015-05-28 15:52:31 +09:00
dd8493f97e
make coin selection a bit faster
2015-05-27 11:07:57 +02:00
65e7dca3de
Merge pull request #1249 from kyuupichan/stale_interfaces2
...
Common stale interface testing and switching
2015-05-27 10:42:59 +02:00
8e6e4f1b92
Merge pull request #1255 from kyuupichan/amountedit2
...
Fix nasty bug in amount editors
2015-05-27 10:19:07 +02:00
e5d243e08c
Fix nasty bug in amount editors
...
str() can convert amounts to scientific notation
2015-05-27 17:14:40 +09:00
45a8740755
Common stale interface testing and switching
...
Three places used to test for lagging and switch. Commonize the
code. We test for lagging before autoconnect so lagging
diagnostics are output if not auto-connect.
Lagging diagnotics moved to server_is_lagging().
2015-05-27 00:42:43 +09:00
ae957f3736
make_transaction: remove unneeded inputs
2015-05-26 09:09:07 +02:00
7becb28ec8
Merge pull request #1246 from kyuupichan/bug_fix
...
e20dfc unintentionally inverted portable condition
2015-05-25 13:28:42 +02:00
e63ac88c77
e20dfc unintentionally inverted portable condition
...
This wasn't noticed because the test was also broken.
2015-05-25 16:59:16 +09:00
39fe24b4d3
Rename auto_cycle to auto_connect in config
...
User config is updated if appropriate.
Add tests behaviour is as expected.
Just the one rename-it reference to auto_cycle remains.
2015-05-25 16:18:52 +09:00
d5f6651237
follow up e20dfcd3eb
2015-05-25 08:47:25 +02:00
e20dfcd3eb
Fix SimpleConfig
...
SimpleConfig claims to handle configuration options in priority
command line, user config, system config, which makes sense.
In fact it appears it used priority command line, system config,
user config.
Also, from the priority ordering, it would seem correct that a
value should be unmodifiable if and only if it's set on the command
line. Previously anything in the system config would be unmodifiable.
This patch fixes these and cleans the code up a bit. I noticed this
whilst attempting to unify the 'auto_cycle' setting.
Fixup tests accordingly.
2015-05-25 15:16:19 +09:00
4f6d2f3d32
Put getting of auto_cycle into one place.
...
Default to False consistently; this may change the behaviour of
network.py's get_parameters().
2015-05-25 14:09:43 +09:00
778297697a
lazy plugin constructor
2015-05-24 20:37:05 +02:00
71046371ec
Merge pull request #1242 from kyuupichan/pick_random_server
...
Clean up pick_random_server() and filter_protocol() and their
2015-05-24 16:43:17 +02:00
117b809bab
fix issue #1238
2015-05-24 16:14:56 +02:00
01d8f79a75
Clean up pick_random_server() and filter_protocol() and their
...
call sites.
Remove unused imports and redundant random pick of server
2015-05-24 21:07:35 +09:00
48ad7c36a8
show plugin dependencies
2015-05-24 10:06:53 +02:00
d40c12c949
check gui when loading plugins
2015-05-24 09:26:28 +02:00
89c1a1a0ab
Improve logic in network.py's set_parameters()
...
1) For new proxy or protocol, restart the network and default to
the requested server.
2) Otherwise if we aren't using the requested server, switch to it
3) Otherwise choose a random server if the requested server is
stale and auto_connect is True
As switch_to_interface() now has another user, move the logic
there whereby we close the old interface in order to terminate
subscriptions, in order to have it in one place.
2015-05-23 23:33:17 +09:00
8f98ea4aca
make plugins available without the GUI
2015-05-23 10:38:19 +02:00
89c277de9d
fix pruning error in #1223
2015-05-23 08:45:27 +02:00
0fbbeb16be
Merge pull request #1232 from kyuupichan/switch-or-start
...
switch_to_interface() to start interface if not connected
2015-05-23 07:30:00 +02:00
4aaa9e24f2
Merge pull request #1234 from kyuupichan/storage-tmpfile
...
Prevent race with two electrum instances on same wallet.
2015-05-23 07:22:12 +02:00
77490e4764
Flush wallet storage once for a sequence of puts.
...
This speeds up save_transactions by 2 to 3 times for me.
2015-05-23 10:52:10 +09:00
33a8348d48
Prevent race with two electrum instances on same wallet.
...
Whilst it's not a good idea to have two electrum instances
open on the same wallet, we should avoid throwing an
exception. Also note how the old code's handling of the
exception (caused by both renaming the file almost at the
same time, rather than a non-POSIX system not supporting
the atomic rename) can lead to the wallet file being lost
enirely because os.remove(self.path) succeeds and the
rename of the temporary no-longer-existing file then fails.
2015-05-23 10:24:10 +09:00
b029589fc1
fix issue #1233
2015-05-22 20:47:51 +02:00
2f34f3db21
Only start if not already in pending_servers
...
This was only in one call site previously, not both.
2015-05-22 16:29:56 +09:00
31ffd4b381
switch_to_interface() to start interface if not connected
...
Two places currently have switch-to-or-start-interface logic.
Put that common logic into switch_to_interface().
2015-05-22 16:24:58 +09:00
346e38674b
Absorb add_interface and remove_interface
...
They are now only called from the same place; it's simpler
and clearer to put them inline.
2015-05-22 15:26:17 +09:00
0b201d98ab
Merge pull request #1230 from kyuupichan/switch-random-if
...
Remove interfaces in one place only
2015-05-22 08:13:14 +02:00
e13e42a00c
Merge pull request #1229 from kyuupichan/uri-format
...
Plain number formatting for URIs.
2015-05-22 08:12:09 +02:00
274965468e
Remove interfaces in one place only
...
switch_to_random_interface used to do is_connected()
checks and remove interfaces when switching. This
is redundant: interfaces are only added to self.interfaces
once in is_connected() state from process_if_notification().
When they are disconnected, a notification is also received
and process_if_notification() performs the removal. Furthermore,
two other callers of switch_to_interface do not do explicit
is_connected() checks before calling it.
2015-05-22 15:01:11 +09:00
d09d5e5dac
Plain number formatting for URIs.
2015-05-22 14:32:47 +09:00
4873c455b9
Add documentation string. Fix uninitialized f error.
...
Traceback (most recent call last):
File "src/electrum/lib/network.py", line 411, in process_request
out['result'] = f(*params)
UnboundLocalError: local variable 'f' referenced before assignment
[Network] network error local variable 'f' referenced before assignment
2015-05-22 14:14:06 +09:00
05dd310431
Set 'connecting' status in one place.
...
Also means when switching to an already connected server our
status doesn't quickly change to connecting and back again.
2015-05-22 14:05:58 +09:00
86626d8080
Consistency in handling of self.interface
...
switch_to_interface() becomes the common place where
self.interface is set; therefore self.interface is not None
precisely when self.default_server is connected. Previously some
places required it to be connected and some didn't. Also an
interface change now sends the 'updated' notification
consistently - previously some did and some didn't.
Have network_start() call start_interfaces() - this also means
network restarts now do this.
Fix apparent off-by-one in start_interfaces()
2015-05-22 09:13:09 +09:00
c918e74039
Put common network start and stop code in one place.
...
Prefer to use safer self.is_connected() as it checks interface
is not None.
Using common code gives small observable changes in behaviour:
- slightly different print_error() messages
- network restarts now enter status 'connecting' which they
didn't before, which seems correct
- status 'connecting' is done with set_status() rather than
simply assigning the status, which seems more correct. Now
that the response_queue is available in the constructor this
works; it used to fail with 'response_queue is not defined'
2015-05-22 07:52:59 +09:00
8620019f92
Merge pull request #1222 from kyuupichan/if_notification
...
Put interface notification handling in its own function.
2015-05-21 15:05:07 +02:00
5bd22d2378
follow-up to bd781d600b8ce2bc9dcebebbdb0fb60ad2fb892e: use pipe
2015-05-21 12:50:26 +02:00
c9a30eb5f2
Put interface notification handling in its own function.
2015-05-21 17:45:37 +09:00
bd781d600b
Have queues passed to the network constructor.
...
This is somewhat cleaner as the proxy's pipe and network setup
was awkwardly interleaved. It also means network's constructor
is free to use both; currently some code is working around the
fact that the response queue doesn't exist in the constructor.
2015-05-21 12:49:39 +09:00
7b27f01e07
call fsync before rename
2015-05-19 11:56:33 +02:00
5c73bc5bc7
interface: init ping_time with 0 so that the client sends version message
2015-05-19 11:28:30 +02:00
2104e96a66
network: use get_nowait on one of the two queues
2015-05-19 10:22:25 +02:00
63733ccd2a
No need for thread to handle requests
...
Handle requests in the main loop.
Remove unused lock.
interface.py was reworked and send_request() no longer throws.
2015-05-19 14:29:10 +09:00
a0e9046c2c
prepare for 2.2 release
2015-05-17 09:17:52 +02:00
e33bc2473b
network: don't store unanswered request if result is in cache
2015-05-17 09:00:36 +02:00
6d0bc5d9b3
fix: nodes retry
2015-05-17 08:41:01 +02:00
44f06de796
network: when interface is disconnected, clear cache and resend unanswered requests
2015-05-15 14:47:59 +02:00
0ec62c8f36
Fix createrawtransaction and missing deserialize()
...
Found these issues while trying to create, sign, and broadcast a raw transaction.
* createrawtransaction was using old signature for Transaction constructor
* Signwithwallet and decoderawtransaction need to call deserialize on tx before they can access inputs and outputs. (Maybe adding getInputs() and getOutputs() which deserializes if needed might be nicer)
2015-05-13 14:57:34 +02:00
5fa2a48343
add getmerkle command
2015-05-12 12:30:26 +02:00
81be685644
remove tests broken after WalletStorage update
2015-05-11 11:59:39 +02:00
7e9153aaa4
test if labels exist before loop. don't raise if a label cannot be converted
2015-05-11 11:55:26 +02:00
fe5be618db
Convert old latin1 labels, Raise exception if json conversion fails.
...
A couple of changes
1) Old electrum wallets seemed to save labels in latin1, when you call json.dumps on line 83/84 it fails silently, which causes the label import to fail. Whenever electrum saves, it then overwrites your default wallet with no labels - essentially deleting all your labels. The solution to this is iterating over all the labels for old wallets decoding anything that fails to unicode() as latin1, and then unicoding it :)
2) Failing to import data and then deleting it is bad. So I'm raising an exception to avoid data being lost.
2015-05-10 20:28:42 +01:00
59a9e4f710
fix new_wallet and seed language
2015-05-10 08:31:31 +02:00
a1d1999545
move interfaces maintenance to its own function
2015-05-08 20:13:18 +02:00
f2c2f9d738
network: fix confusion between addresses and cached responses
2015-05-08 17:59:33 +02:00
2a92a310ba
typo
2015-05-08 17:47:04 +02:00
8c07bdc3bc
do not timeout if interface is receiving data
2015-05-08 17:45:59 +02:00
233fd8ed77
revert 175bfae9e6. store last known height in wallet instead
2015-05-08 13:43:42 +02:00
1d517abf39
restore network_proxy.get_local_height
2015-05-08 11:12:19 +02:00
c2a4252065
do not pass config to storage. request height from network_proxy if connected
2015-05-08 10:58:54 +02:00
Neil Booth
ThomasV
Roman Zeyde
dabura667
ThomasV
Eagle[TM]
ThomasV
neocogent
Michael Wozniak
Kefkius
mikeland86
Azelphur