WIP --- Cleaning up tests
Currently working on sighash_tests which may be the last of the
test_bitcoin failures.
Restore Genesis Block
Mistakenly replaced with search and replace of AlertKey
test_bitcoin now passes
Fixed multiple errors throughout src/test and main.cpp. Possibly read
for pull request but will want to investigate a few things first.
Adding sighash.json
Needed to run sighash tests and not created automatically as needed.
Updated sighash.json
Sighash test fails without this.
Fixed formatting issue
removed {} which did not exist in the file at the time i got it
Commented out line so test data is not always generated when script_tests runs.
This adds some source files, a script and skeleton for building
a Debian package that installs the zcash daemon and CLI tool.
Also removes unused Bitcoin files.
No need to waste startup time building something that can be done
at compile time.
This also resolves a clang++ warning originally reported in #4714,
univalue/univalue_write.cpp:33:12: warning: array subscript is of type 'char
escapes['"'] = "\\"";
^~~~
etc.
This is a simple utility that provides command line manipulation of
a hex-encoded TX. The utility takes a hex string on the command line
as input, performs zero or more mutations, and outputs a hex string
to standard output.
This utility is also an intentional exercise of the "bitcoin library"
concept. It is designed to require minimal libraries, and works
entirely without need for any RPC or P2P communication.
See "bitcoin-tx --help" for command and options summary.
Prior to this change, `git status` would report untracked files of the
following sort if run during a build:
?? src/rpcprotocol.o-e628def3
These files should be explicitly ignored not only because they are a
nuisance, but given that they appear and disappear quickly, they may be
inadvertently added to the index even if one has been careful to check
for untracked files with `git status` prior to a `git add .`.
This adds an executable `bitcoin-rpc` that only serves as a Bitcoin RPC
client.
The commit does not remove RPC functionality from the `bitcoind` yet,
this functionality should be deprecated but is left for a later version
to give users some time to switch.
This change moves test data into the binaries rather than reading them from
the disk at runtime.
Advantages:
- Tests become distributable
- Cross-compile friendly. Build on one machine and execute in an arbitrary
location on another.
- Easier testing for backports. Users can verify that tests pass without having
to track down corresponding test data.
- More trustworthy test results and easier quality assurance as tests make
fewer assumptions about their environment.
- Tests could theoretically run at client/daemon startup and exit on failure.
Disadvantages:
- Required 'hexdump' build-dependency. This is a standard bsd tool that should
be usable everywhere. It is likely already installed on all build-machines.
- Tests can no longer be fudged after build by altering test-data.
All client version information is moved to version.cpp, which optionally
(-DHAVE_BUILD_INFO) includes build.h. build.h is automatically generated
on supporting platforms via contrib/genbuild.sh, using git describe.
The git export-subst attribute is used to put the commit id statically
in version.cpp inside generated archives, and this value is used if no
build.h is present.
The gitian descriptors are modified to use git archive instead of a
copy, to create the src/ directory in the output. This way,
src/src/version.cpp will contain the static commit id. To prevent
gitian builds from getting the "-dirty" marker in their git-describe
generated identifiers, no touching of files or running sed on the
makefile is performed anymore. This does not seem to influence
determinism.
Jon Layton
Zane Thomas
airk42
Daira Hopwood
Jack Grigg
Sean Bowe
Simon
zkbot
Kevin Gallagher
Taylor Hornby
Nathan Wilcox
Taylor Hornby
Michael Ford
Cory Fields
randy-waterhouse
Jeff Garzik
Wladimir J. van der Laan
Drak
Chris Beams
harry
Josh Triplett
Cory Fields
Peter Todd
Mike Hearn
Gavin Andresen
Jeff Garzik
R E Broadley
Pieter Wuille
Matt Corallo
p2k
Luke Dashjr
Misbakh-Soloviev Vadim A
Doug Huff