From 4dfda532c84c79aa5b1ee0a474a4935d88fee254 Mon Sep 17 00:00:00 2001 From: Matias Alejo Garcia Date: Wed, 17 Feb 2016 16:19:49 -0300 Subject: [PATCH 1/2] update history limit --- lib/server.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/server.js b/lib/server.js index 41ff170..a5074d6 100644 --- a/lib/server.js +++ b/lib/server.js @@ -42,7 +42,7 @@ var messageBroker; var fiatRateService; var serviceVersion; -var HISTORY_LIMIT = 10; +var HISTORY_LIMIT = 100; /** * Creates an instance of the Bitcore Wallet Service. From 270c5cbeffd46b8af4359983e32aebbe10489644 Mon Sep 17 00:00:00 2001 From: Matias Alejo Garcia Date: Wed, 17 Feb 2016 16:45:56 -0300 Subject: [PATCH 2/2] mv constant to defaults --- lib/common/defaults.js | 2 ++ lib/server.js | 6 ++---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/common/defaults.js b/lib/common/defaults.js index 897ddbd..f51efc1 100644 --- a/lib/common/defaults.js +++ b/lib/common/defaults.js @@ -45,4 +45,6 @@ Defaults.FIAT_RATE_PROVIDER = 'BitPay'; Defaults.FIAT_RATE_FETCH_INTERVAL = 10; // In minutes Defaults.FIAT_RATE_MAX_LOOK_BACK_TIME = 120; // In minutes +Defaults.HISTORY_LIMIT = 100; + module.exports = Defaults; diff --git a/lib/server.js b/lib/server.js index a5074d6..ea2a281 100644 --- a/lib/server.js +++ b/lib/server.js @@ -42,8 +42,6 @@ var messageBroker; var fiatRateService; var serviceVersion; -var HISTORY_LIMIT = 100; - /** * Creates an instance of the Bitcore Wallet Service. * @constructor @@ -2153,8 +2151,8 @@ WalletService.prototype.getTxHistory = function(opts, cb) { var self = this; opts = opts || {}; - opts.limit = (_.isUndefined(opts.limit) ? HISTORY_LIMIT : opts.limit); - if (opts.limit > HISTORY_LIMIT) + opts.limit = (_.isUndefined(opts.limit) ? Defaults.HISTORY_LIMIT : opts.limit); + if (opts.limit > Defaults.HISTORY_LIMIT) return cb(Errors.HISTORY_LIMIT_EXCEEDED); function decorate(txs, addresses, proposals) {