BTCPrivate
/
bitcore-wallet-service
mirror of https://github.com/BTCPrivate/bitcore-wallet-service.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

fix: wrong output value calculation in _buildTx

This commit is contained in:
Kosta Korenkov 2016-04-11 13:10:40 +03:00
parent 1168824f7f
commit 2e1cc88c56
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/model/txproposal.js
View File

@ -162,7 +162,7 @@ TxProposal.prototype._buildTx = function() {
t.fee(self.fee); t.fee(self.fee);
var totalInputs = _.sum(self.inputs, 'satoshis'); var totalInputs = _.sum(self.inputs, 'satoshis');
var totalOutputs = _.sum(self.outputs, 'satoshis'); var totalOutputs = _.sum(self.outputs, 'amount');
if (totalInputs - totalOutputs - self.fee > 0 && self.changeAddress) { if (totalInputs - totalOutputs - self.fee > 0 && self.changeAddress) {
t.change(self.changeAddress.address); t.change(self.changeAddress.address);
@ -182,7 +182,7 @@ TxProposal.prototype._buildTx = function() {
} }
// Validate actual inputs vs outputs independently of Bitcore // Validate actual inputs vs outputs independently of Bitcore
var totalInputs = _.sum(t.inputs, 'satoshis'); var totalInputs = _.sum(t.inputs, 'output.satoshis');
var totalOutputs = _.sum(t.outputs, 'satoshis'); var totalOutputs = _.sum(t.outputs, 'satoshis');
$.checkState(totalInputs - totalOutputs <= Defaults.MAX_TX_FEE); $.checkState(totalInputs - totalOutputs <= Defaults.MAX_TX_FEE);