BTCPrivate
/
bitcore-wallet-service
mirror of https://github.com/BTCPrivate/bitcore-wallet-service.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

add test for invalid m/n combination

This commit is contained in:
Ivan Socolsky 2015-02-03 09:40:39 -03:00
parent d4865de91d
commit 3ca1196819
2 changed files with 28 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/server.js
View File

@ -57,7 +57,7 @@ CopayServer.prototype.createWallet = function(opts, cb) {
pubKey;
Utils.checkRequired(opts, ['id', 'name', 'm', 'n', 'pubKey']);
if (!Wallet.verifyCopayerLimits(opts.m, opts.n)) return cb('Incorrect m or n value');
if (!Wallet.verifyCopayerLimits(opts.m, opts.n)) return cb('Invalid m/n combination');
var network = opts.network || 'livenet';
if (network != 'livenet' && network != 'testnet') return cb('Invalid network');

27
test/integration.js
View File

@ -253,6 +253,33 @@ describe('Copay server', function() {
});
});
});
it('should fail to create wallet with invalid copayer pairs', function(done) {
var invalidPairs = [
{ m: 0, n: 0 },
{ m: 0, n: 2 },
{ m: 2, n: 1 },
{ m: 0, n: 10 },
{ m: 1, n: 20 },
{ m: 10, n: 10 },
];
var opts = {
id: '123',
name: 'my wallet',
pubKey: aPubKey,
};
async.each(invalidPairs, function (pair, cb) {
opts.m = pair.m;
opts.n = pair.n;
server.createWallet(opts, function(err) {
should.exist(err);
err.should.contain('Invalid m/n combination');
return cb();
});
}, function (err) {
done();
});
});
});
describe('#joinWallet', function() {