BTCPrivate
/
bitcore-wallet-service
mirror of https://github.com/BTCPrivate/bitcore-wallet-service.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #655 from isocolsky/fix/send-max 

Fix send max when resulting amount is below dust
This commit is contained in:
Matias Alejo Garcia 2017-05-24 14:35:36 +02:00 committed by GitHub
parent a9b44ee5f1 4be0937e5b
commit 7587540113
2 changed files with 37 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/server.js
View File

@ -1339,9 +1339,15 @@ WalletService.prototype.getSendMaxInfo = function(opts, cb) {
if (_.isEmpty(txp.inputs)) return cb(null, info);
var fee = txp.getEstimatedFee();
var amount = _.sum(txp.inputs, 'satoshis') - fee;
if (amount < Defaults.MIN_OUTPUT_AMOUNT) return cb(null, info);
info.size = txp.getEstimatedSize();
info.fee = txp.getEstimatedFee();
info.amount = _.sum(txp.inputs, 'satoshis') - info.fee;
info.fee = fee;
info.amount = amount;
if (opts.returnInputs) {
info.inputs = _.shuffle(txp.inputs);
}

29
test/integration/server.js
View File

@ -4433,6 +4433,35 @@ describe('Wallet service', function() {
});
});
});
it('should correctly get send max info when resulting amount is below dust', function(done) {
helpers.stubUtxos(server, wallet, [300e-6, 300e-6], function() {
server.getSendMaxInfo({
feePerKb: 500e2,
returnInputs: true,
}, function(err, info) {
should.not.exist(err);
should.exist(info);
info.size.should.equal(700);
info.fee.should.equal(350e2);
info.amount.should.equal(250e2);
var _min_output_amount = Defaults.MIN_OUTPUT_AMOUNT;
Defaults.MIN_OUTPUT_AMOUNT = 300e2;
server.getSendMaxInfo({
feePerKb: 500e2,
returnInputs: true,
}, function(err, info) {
should.not.exist(err);
should.exist(info);
info.size.should.equal(0);
info.amount.should.equal(0);
Defaults.MIN_OUTPUT_AMOUNT = _min_output_amount;
done();
});
});
});
});
describe('Fee level', function() {
it('should correctly get send max info using feeLevel', function(done) {
helpers.stubFeeLevels({