BTCPrivate
/
bitcore-wallet-service
mirror of https://github.com/BTCPrivate/bitcore-wallet-service.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #497 from troggy/fix-build-tx 

fix: wrong output value calculation in _buildTx
This commit is contained in:
Ivan Socolsky 2016-04-11 14:25:07 -03:00
parent 4157e839c7 1dd7d1628b
commit b3e01c0ddd
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/model/txproposal.js
View File

@ -162,7 +162,7 @@ TxProposal.prototype._buildTx = function() {
t.fee(self.fee);
var totalInputs = _.sum(self.inputs, 'satoshis');
var totalOutputs = _.sum(self.outputs, 'satoshis');
var totalOutputs = _.sum(self.outputs, 'amount');
if (totalInputs - totalOutputs - self.fee > 0 && self.changeAddress) {
t.change(self.changeAddress.address);
@ -182,9 +182,10 @@ TxProposal.prototype._buildTx = function() {
}
// Validate actual inputs vs outputs independently of Bitcore
var totalInputs = _.sum(t.inputs, 'satoshis');
var totalInputs = _.sum(t.inputs, 'output.satoshis');
var totalOutputs = _.sum(t.outputs, 'satoshis');
$.checkState(totalInputs > 0 && totalOutputs > 0 && totalInputs >= totalOutputs);
$.checkState(totalInputs - totalOutputs <= Defaults.MAX_TX_FEE);
return t;