refactor tx inputs selection
This commit is contained in:
parent
b088183ce9
commit
b5f6582b77
|
@ -464,33 +464,42 @@ WalletService.prototype.getBalance = function(opts, cb) {
|
|||
});
|
||||
};
|
||||
|
||||
WalletService.prototype._selectTxInputs = function(txp, cb) {
|
||||
var self = this;
|
||||
|
||||
WalletService.prototype._selectUtxos = function(txp, utxos) {
|
||||
var i = 0;
|
||||
var total = 0;
|
||||
var selected = [];
|
||||
var inputs = _.sortBy(utxos, 'amount');
|
||||
self._getUtxos(function(err, utxos) {
|
||||
if (err) return cb(err);
|
||||
|
||||
while (i < inputs.length) {
|
||||
selected.push(inputs[i]);
|
||||
total += inputs[i].satoshis;
|
||||
utxos = _.reject(utxos, {
|
||||
locked: true
|
||||
});
|
||||
|
||||
if (total >= txp.amount + Bitcore.Transaction.FEE_PER_KB) {
|
||||
try {
|
||||
// Check if there are enough fees
|
||||
txp.inputs = selected;
|
||||
var raw = txp.getRawTx();
|
||||
return;
|
||||
} catch (ex) {
|
||||
if (ex.name != 'bitcore.ErrorTransactionFeeError') {
|
||||
throw ex.message;
|
||||
var i = 0;
|
||||
var total = 0;
|
||||
var selected = [];
|
||||
var inputs = _.sortBy(utxos, 'amount');
|
||||
|
||||
while (i < inputs.length) {
|
||||
selected.push(inputs[i]);
|
||||
total += inputs[i].satoshis;
|
||||
|
||||
if (total >= txp.amount + Bitcore.Transaction.FEE_PER_KB) {
|
||||
try {
|
||||
// Check if there are enough fees
|
||||
txp.inputs = selected;
|
||||
var raw = txp.getRawTx();
|
||||
txp.inputPaths = _.pluck(txp.inputs, 'path');
|
||||
return cb();
|
||||
} catch (ex) {
|
||||
if (ex.name != 'bitcore.ErrorTransactionFeeError') {
|
||||
return cb(ex);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
i++;
|
||||
};
|
||||
txp.inputs = null;
|
||||
return;
|
||||
i++;
|
||||
};
|
||||
return cb(new ClientError('INSUFFICIENTFUNDS', 'Insufficient funds'));
|
||||
});
|
||||
};
|
||||
|
||||
|
||||
|
@ -534,36 +543,25 @@ WalletService.prototype.createTx = function(opts, cb) {
|
|||
if (opts.amount < Bitcore.Transaction.DUST_AMOUNT)
|
||||
return cb(new ClientError('DUSTAMOUNT', 'Amount below dust threshold'));
|
||||
|
||||
self._getUtxos(function(err, utxos) {
|
||||
|
||||
var changeAddress = wallet.createAddress(true);
|
||||
|
||||
var txp = TxProposal.create({
|
||||
creatorId: self.copayerId,
|
||||
toAddress: opts.toAddress,
|
||||
amount: opts.amount,
|
||||
message: opts.message,
|
||||
proposalSignature: opts.proposalSignature,
|
||||
changeAddress: changeAddress,
|
||||
requiredSignatures: wallet.m,
|
||||
requiredRejections: Math.min(wallet.m, wallet.n - wallet.m + 1),
|
||||
});
|
||||
|
||||
|
||||
self._selectTxInputs(txp, function(err) {
|
||||
if (err) return cb(err);
|
||||
|
||||
var changeAddress = wallet.createAddress(true);
|
||||
|
||||
utxos = _.reject(utxos, {
|
||||
locked: true
|
||||
});
|
||||
|
||||
var txp = TxProposal.create({
|
||||
creatorId: self.copayerId,
|
||||
toAddress: opts.toAddress,
|
||||
amount: opts.amount,
|
||||
message: opts.message,
|
||||
proposalSignature: opts.proposalSignature,
|
||||
changeAddress: changeAddress,
|
||||
requiredSignatures: wallet.m,
|
||||
requiredRejections: Math.min(wallet.m, wallet.n - wallet.m + 1),
|
||||
});
|
||||
|
||||
try {
|
||||
self._selectUtxos(txp, utxos);
|
||||
} catch (ex) {
|
||||
return cb(new ClientError(ex.toString()));
|
||||
}
|
||||
|
||||
if (!txp.inputs)
|
||||
return cb(new ClientError('INSUFFICIENTFUNDS', 'Insufficient funds'));
|
||||
|
||||
txp.inputPaths = _.pluck(txp.inputs, 'path');
|
||||
$.checkState(txp.inputs);
|
||||
|
||||
self.storage.storeAddressAndWallet(wallet, changeAddress, function(err) {
|
||||
if (err) return cb(err);
|
||||
|
|
|
@ -984,7 +984,7 @@ describe('Copay server', function() {
|
|||
});
|
||||
});
|
||||
|
||||
it.only('should fail with different error for insufficient funds and locked funds', function(done) {
|
||||
it('should fail with different error for insufficient funds and locked funds', function(done) {
|
||||
helpers.stubUtxos(server, wallet, [10, 10], function() {
|
||||
var txOpts = helpers.createProposalOpts('18PzpUFkFZE8zKWUPvfykkTxmB9oMR8qP7', 11, null, TestData.copayers[0].privKey_1H_0);
|
||||
server.createTx(txOpts, function(err, tx) {
|
||||
|
|
Loading…
Reference in New Issue