From b659333c942b4fd2931eb7524bc3b651dd1747d4 Mon Sep 17 00:00:00 2001 From: Ivan Socolsky Date: Thu, 30 Jul 2015 14:55:35 -0300 Subject: [PATCH] differentiate INSUFFICIENTFUNDS from INSUFFICIENTFUNDSFORFEE --- lib/server.js | 2 +- test/integration/server.js | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/server.js b/lib/server.js index 1d03ecf..b508368 100644 --- a/lib/server.js +++ b/lib/server.js @@ -896,7 +896,7 @@ WalletService.prototype._selectTxInputs = function(txp, cb) { } if (bitcoreError instanceof Bitcore.errors.Transaction.FeeError) { - return cb(new ClientError('INSUFFICIENTFUNDS', 'Insufficient funds for fee')); + return cb(new ClientError('INSUFFICIENTFUNDSFORFEE', 'Insufficient funds for fee')); } if (bitcoreError instanceof Bitcore.errors.Transaction.DustOutputs) { return cb(new ClientError('DUSTAMOUNT', 'Amount below dust threshold')); diff --git a/test/integration/server.js b/test/integration/server.js index e255205..1df33a5 100644 --- a/test/integration/server.js +++ b/test/integration/server.js @@ -1692,7 +1692,7 @@ describe('Wallet service', function() { txOpts.excludeUnconfirmedUtxos = true; server.createTx(txOpts, function(err, tx) { should.exist(err); - err.code.should.equal('INSUFFICIENTFUNDS'); + err.code.should.equal('INSUFFICIENTFUNDSFORFEE'); err.message.should.equal('Insufficient funds for fee'); done(); }); @@ -1826,7 +1826,7 @@ describe('Wallet service', function() { var txOpts = helpers.createSimpleProposalOpts('18PzpUFkFZE8zKWUPvfykkTxmB9oMR8qP7', 0.048200, null, TestData.copayers[0].privKey_1H_0); server.createTx(txOpts, function(err, tx) { should.exist(err); - err.code.should.equal('INSUFFICIENTFUNDS'); + err.code.should.equal('INSUFFICIENTFUNDSFORFEE'); err.message.should.equal('Insufficient funds for fee'); done(); }); @@ -1850,7 +1850,7 @@ describe('Wallet service', function() { var txOpts = helpers.createSimpleProposalOpts('18PzpUFkFZE8zKWUPvfykkTxmB9oMR8qP7', 0.99995, null, TestData.copayers[0].privKey_1H_0, 80000); server.createTx(txOpts, function(err, tx) { should.exist(err); - err.code.should.equal('INSUFFICIENTFUNDS'); + err.code.should.equal('INSUFFICIENTFUNDSFORFEE'); var txOpts = helpers.createSimpleProposalOpts('18PzpUFkFZE8zKWUPvfykkTxmB9oMR8qP7', 0.99995, null, TestData.copayers[0].privKey_1H_0, 5000); server.createTx(txOpts, function(err, tx) { should.not.exist(err); @@ -4367,7 +4367,7 @@ describe('Wallet service', function() { server.createTx(txOpts, function(err, tx) { should.exist(err); - err.code.should.equal('INSUFFICIENTFUNDS'); + err.code.should.equal('INSUFFICIENTFUNDSFORFEE'); var txOpts = helpers.createSimpleProposalOpts('18PzpUFkFZE8zKWUPvfykkTxmB9oMR8qP7', 0.99995, null, TestData.copayers[0].privKey_1H_0, 5000); server.createTx(txOpts, function(err, tx) { should.not.exist(err);