From 476a2d49ed289143e8098c0404d3e2d8a6500af9 Mon Sep 17 00:00:00 2001 From: Ivan Socolsky Date: Wed, 27 Apr 2016 12:45:00 -0300 Subject: [PATCH 1/2] log bad signatures data --- lib/server.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/server.js b/lib/server.js index 1726578..3944a71 100644 --- a/lib/server.js +++ b/lib/server.js @@ -2179,8 +2179,15 @@ WalletService.prototype.signTx = function(opts, cb) { var copayer = wallet.getCopayer(self.copayerId); - if (!txp.sign(self.copayerId, opts.signatures, copayer.xPubKey)) + if (!txp.sign(self.copayerId, opts.signatures, copayer.xPubKey)) { + log.warn('Error signing transaction (BAD_SIGNATURES)'); + log.warn('Wallet id: ', self.walletId); + log.warn('Copayer id: ', self.copayerId); + log.warn('Client version: ', self.clientVersion); + log.warn('Arguments: ', JSON.stringify(opts)); + log.warn('Transaction proposal: ', JSON.stringify(txp)); return cb(Errors.BAD_SIGNATURES); + } self.storage.storeTx(self.walletId, txp, function(err) { if (err) return cb(err); From c1e9a8a66ebd7972a49134ffea29f7434f57eb73 Mon Sep 17 00:00:00 2001 From: Ivan Socolsky Date: Wed, 27 Apr 2016 12:57:05 -0300 Subject: [PATCH 2/2] add raw tx to log --- lib/server.js | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/lib/server.js b/lib/server.js index 3944a71..255acd4 100644 --- a/lib/server.js +++ b/lib/server.js @@ -2181,11 +2181,13 @@ WalletService.prototype.signTx = function(opts, cb) { if (!txp.sign(self.copayerId, opts.signatures, copayer.xPubKey)) { log.warn('Error signing transaction (BAD_SIGNATURES)'); - log.warn('Wallet id: ', self.walletId); - log.warn('Copayer id: ', self.copayerId); - log.warn('Client version: ', self.clientVersion); - log.warn('Arguments: ', JSON.stringify(opts)); - log.warn('Transaction proposal: ', JSON.stringify(txp)); + log.warn('Wallet id:', self.walletId); + log.warn('Copayer id:', self.copayerId); + log.warn('Client version:', self.clientVersion); + log.warn('Arguments:', JSON.stringify(opts)); + log.warn('Transaction proposal:', JSON.stringify(txp)); + var raw = txp.getBitcoreTx().uncheckedSerialize(); + log.warn('Raw tx:', raw); return cb(Errors.BAD_SIGNATURES); }