BTCPrivate
/
bitcore-wallet-service
mirror of https://github.com/BTCPrivate/bitcore-wallet-service.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

add fetchedOn to returned rates

This commit is contained in:
Ivan Socolsky 2016-01-11 15:25:13 -03:00
parent 0922a5fa6e
commit e62e5b032d
2 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/fiatrateservice.js
View File

@ -119,6 +119,7 @@ FiatRateService.prototype.getRate = function(code, opts, cb) {
return cb(null, { return cb(null, {
ts: +ts, ts: +ts,
rate: rate ? rate.value : undefined, rate: rate ? rate.value : undefined,
fetchedOn: rate ? rate.ts : undefined,
}); });
}); });
}, function(err, res) { }, function(err, res) {

23
test/integration/fiatrateservice.js
View File

@ -48,7 +48,7 @@ describe.only('Fiat rate service', function() {
}); });
}); });
}); });
it('should get current for different currency', function(done) { it('should get current rate for different currency', function(done) {
service.storage.storeFiatRate('BitPay', [{ service.storage.storeFiatRate('BitPay', [{
code: 'USD', code: 'USD',
value: 123.45, value: 123.45,
@ -69,6 +69,7 @@ describe.only('Fiat rate service', function() {
}); });
it('should get rate for specific ts', function(done) { it('should get rate for specific ts', function(done) {
var clock = sinon.useFakeTimers(0, 'Date'); var clock = sinon.useFakeTimers(0, 'Date');
clock.tick(20);
service.storage.storeFiatRate('BitPay', [{ service.storage.storeFiatRate('BitPay', [{
code: 'USD', code: 'USD',
value: 123.45, value: 123.45,
@ -84,7 +85,9 @@ describe.only('Fiat rate service', function() {
ts: 50, ts: 50,
}, function(err, res) { }, function(err, res) {
should.not.exist(err); should.not.exist(err);
res.ts.should.equal(50);
res.rate.should.equal(123.45); res.rate.should.equal(123.45);
res.fetchedOn.should.equal(20);
clock.restore(); clock.restore();
done(); done();
}); });
@ -106,17 +109,27 @@ describe.only('Fiat rate service', function() {
}, function(err) { }, function(err) {
should.not.exist(err); should.not.exist(err);
service.getRate('USD', { service.getRate('USD', {
ts: [50, 100, 500], ts: [50, 100, 199, 500],
}, function(err, res) { }, function(err, res) {
should.not.exist(err); should.not.exist(err);
res.length.should.equal(3); res.length.should.equal(4);
res[0].ts.should.equal(50); res[0].ts.should.equal(50);
should.not.exist(res[0].rate); should.not.exist(res[0].rate);
should.not.exist(res[0].fetchedOn);
res[1].ts.should.equal(100); res[1].ts.should.equal(100);
res[1].rate.should.equal(1.00); res[1].rate.should.equal(1.00);
res[2].ts.should.equal(500); res[1].fetchedOn.should.equal(100);
res[2].rate.should.equal(4.00);
res[2].ts.should.equal(199);
res[2].rate.should.equal(1.00);
res[2].fetchedOn.should.equal(100);
res[3].ts.should.equal(500);
res[3].rate.should.equal(4.00);
res[3].fetchedOn.should.equal(400);
clock.restore(); clock.restore();
done(); done();
}); });