Commit Graph

545 Commits

Author SHA1 Message Date
Kosta Korenkov 2bdc6cf19d Make API.createTx accept preselected inputs
Add EXTERNAL tx type

It will allow clients to specify inputs and outputs when creating proposals

Extract _validateOutputs method

Use for-loop to simplify and make it fail-fast.

Do not validate outputs for EXTERNAL tx type

Outputs may be of any kind (e.g. OP_RETURN). It is assumed that outputs are validated by caller.

Move output validation to a single place

Check tx and estimate fees for EXTERNAL proposal

Set amount for external proposals

Use changeAddress to determine network

Do not shuffle outputs for EXTERNAL txp

Fix input selection to respect fees

Add more inputs, if we selected exactly the amount to spend, so we avoid 'Insufficient funds for a fee' error

Properly handle UTXO with 0 satoshis

Minor fixes

ignore invalid utxos
2015-11-11 21:23:44 +03:00
Matias Alejo Garcia a1f58a6c8c Merge pull request #393 from isocolsky/remove-bwu-dep
Remove BWU dependency
2015-11-09 10:48:09 -03:00
Ivan Socolsky 714b95b32c remove derivationStrategy field from txp 2015-11-06 12:02:41 -03:00
Ivan Socolsky 2367365707 fix GET v1/addresses/ endpoint 2015-11-04 12:36:39 -03:00
Ivan Socolsky c629b02419 test address derivation from PKR 2015-11-03 16:57:34 -03:00
Ivan Socolsky f5f530e3b3 add tests to utils.js 2015-11-03 16:15:15 -03:00
Ivan Socolsky c7611231a5 refactor email notification tests into a separate test suite 2015-11-03 15:59:52 -03:00
Ivan Socolsky 7042e240f8 refactor testing setup/teardown in helpers 2015-11-03 15:45:38 -03:00
Ivan Socolsky c1a456d32a extract helpers from integration tests 2015-11-03 13:29:52 -03:00
Ivan Socolsky e55983b151 mv Utils.buildTx -> TxProposal 2015-11-03 13:01:12 -03:00
Ivan Socolsky 795097bf04 refactor constants+defaults+utils -> common 2015-10-30 17:16:20 -03:00
Ivan Socolsky d451fff6fc clean up address scan config 2015-10-30 15:39:33 -03:00
Ivan Socolsky eb006c3db3 remove bitcore-wallet-utils dependency 2015-10-30 15:24:47 -03:00
Matias Alejo Garcia 3425f9ec57 Merge pull request #392 from isocolsky/feat/get-main-addresses-params
Add params to getMainAddresses
2015-10-29 16:38:22 -03:00
Matias Alejo Garcia 5edfe3d384 Merge pull request #390 from isocolsky/limit-address-gap
Limit nb of consecutive addresses without activity
2015-10-29 16:37:47 -03:00
Ivan Socolsky 22a19ff8cb rm .only 2015-10-29 15:46:02 -03:00
Ivan Socolsky ef18c786fb handle limit & reverse params 2015-10-29 15:17:39 -03:00
Ivan Socolsky ea8db8bb19 test getMainAddresses 2015-10-29 14:48:04 -03:00
Matias Alejo Garcia ade6458b6c add tests 2015-10-28 18:34:05 -03:00
Ivan Socolsky ff1ca22825 test cache 2015-10-28 13:42:38 -03:00
Ivan Socolsky 64a48db991 check single address activity on blockchain 2015-10-28 13:25:32 -03:00
Ivan Socolsky cf37d013b6 changed stub methods & more tests 2015-10-27 16:22:42 -03:00
Ivan Socolsky a8a6962c74 check activity of previous addresses before generating a new one 2015-10-27 16:00:29 -03:00
Ivan Socolsky 2f990f42a8 test 2015-10-27 15:38:11 -03:00
Ivan Socolsky 0a7ef7588d test new change address on every tx 2015-10-27 13:01:41 -03:00
Ivan Socolsky a84d2ae2d1 test existing addresses do not get rewinded on scan error 2015-10-27 11:28:34 -03:00
Ivan Socolsky 284c2540f9 do not go beyond max gap addresses 2015-10-26 18:31:10 -03:00
Ivan Socolsky c21683ca6f all #scan tests passing 2015-10-26 18:17:48 -03:00
Ivan Socolsky 9ffcb7e470 scan addresses 1 by 1 and rewind to last used one 2015-10-26 18:05:53 -03:00
Ivan Socolsky e7855e1e89 replace minTs with timeSpan (in secs) in /v1/notifications 2015-10-19 17:23:50 -03:00
Ivan Socolsky d6f9633a73 improve tests 2015-10-19 15:04:09 -03:00
Ivan Socolsky 09c5af073d accept minTs arg on v1/notifications but limit it to now - 60s 2015-10-19 14:58:38 -03:00
Ivan Socolsky 5c048e390c fetch new block notifications along with regular wallet notifications 2015-10-19 14:28:43 -03:00
Ivan Socolsky 19da3f8fd5 add x-service-version header 2015-10-19 11:18:26 -03:00
Braydon Fuller 8277f78df4 bitcore -> bitcore-lib 2015-10-16 18:48:21 -04:00
Ivan Socolsky c35a504696 test notifications return empty set if no new data 2015-10-15 16:37:25 -03:00
Ivan Socolsky 685df45e36 express endpoint + tests 2015-10-15 16:30:14 -03:00
Ivan Socolsky bf40b5a000 getLatestNotifications -> getNotifications 2015-10-15 16:01:23 -03:00
Ivan Socolsky 3bb097c7f4 rm getNotifications 2015-10-15 16:01:23 -03:00
Ivan Socolsky b23f412bf3 getLatestNotifications + tests 2015-10-15 16:01:23 -03:00
Braydon Fuller ab7b08cb0e Add test coverage to express app. 2015-10-06 15:03:03 -04:00
Braydon Fuller e476e86b7d Use defaults from config.js 2015-10-06 13:01:08 -04:00
Braydon Fuller 1696d38d1b Add tests for bitcore node wallet service 2015-10-06 13:01:08 -04:00
Braydon Fuller 8ea3e6c278 Single process when running as a Bitcore Node service. 2015-10-06 13:01:08 -04:00
Braydon Fuller 7f6425c74a Start of BWS as a Bitcore Node Service. 2015-10-06 13:01:08 -04:00
Ivan Socolsky 6df6c00821 do not send new txp email for 1-of-N 2015-09-25 17:07:41 -03:00
Ivan Socolsky 88240dce1a Merge pull request #362 from greggzigler/feat/get_version
clients want bws version for logging and debugging
2015-09-18 14:33:26 -03:00
Gregg Zigler 19cb11abeb rename server to service 2015-09-18 10:20:38 -07:00
Ivan Socolsky e346184339 add dryRun param 2015-09-17 11:39:23 -03:00
Ivan Socolsky d86dae7d17 test 2015-09-17 11:34:46 -03:00
Gregg Zigler bf76023869 use 'bws-' prefix to match style of bwc clientVersion values 2015-09-15 09:57:10 -07:00
Gregg Zigler 9b630002ae rename to disambiguate from clientVersion 2015-09-15 09:43:24 -07:00
Ivan Socolsky 63a7e47543 test 2015-09-11 11:15:38 -03:00
Matias Alejo Garcia 0a09dac821 Merge pull request #357 from isocolsky/ref/bip44
Ref/bip44
2015-09-10 15:46:41 -03:00
Ivan Socolsky a77c81ee7a test legacy/new clients interacting 2015-09-10 14:53:33 -03:00
Matias Alejo Garcia a8607fa11b better insight error handling
add check to getPending

add check to getPending

add tests

rm log

store TXID upon tx completion

monitor accepted txs

change delay

change _checkTxInBlockchain

change _checkTxInBlockchain

rm useless params, refactor txid param

complete tx at fetch
2015-09-09 15:14:11 -03:00
Matias Alejo Garcia 4baaa6dbab Merge pull request #336 from isocolsky/ref/feelevels
Replace feePerKB with feePerKb to match rest of API
2015-09-09 14:46:52 -03:00
Ivan Socolsky 3bf7b4d51f prioritize error messages 2015-09-07 18:52:07 -03:00
Ivan Socolsky 69ae9a63e7 add script type to address 2015-09-07 17:46:45 -03:00
Ivan Socolsky 97e63f9c6f enable both bip44/45 & p2sh/pkh 2015-09-07 17:18:32 -03:00
Ivan Socolsky 595a54322b correctly build tx proposal on P2PKH 2015-09-05 18:49:43 -03:00
Ivan Socolsky 45b7b65e99 allow p2pkh addresses in 1-of-1 2015-09-05 01:18:09 -03:00
Ivan Socolsky a9ad04692b fix tests 2015-09-04 23:11:44 -03:00
Ivan Socolsky 765ccf33a0 restrict BIP44 usage to 1-of-1 wallets 2015-09-04 21:05:39 -03:00
Ivan Socolsky e21d6dabd6 fix scan when blockchain explorer error 2015-09-04 09:38:56 -03:00
Kosta Korenkov 0ccdbf97d7 Fix typo 2015-09-03 12:55:36 +03:00
Kosta Korenkov 20af02e24f Allow arbitrary customData for tx proposals
This way Copay addons may attach related data to proposals
2015-09-03 12:52:12 +03:00
Ivan Socolsky 3f1bae6f25 Merge pull request #340 from matiu/feat/rawTx
add transaction raw HEX if tx status is "accepted"
2015-09-02 13:36:03 -03:00
Matias Alejo Garcia 9de8cfcbf2 add raw HEX if tx is "accepted" 2015-09-02 12:38:28 -03:00
Ivan Socolsky c974cf791a default address manager to BIP45 2015-09-01 12:16:26 -03:00
Ivan Socolsky e11da7cec5 remove AddressManager from copayers on BIP44 2015-08-31 17:38:39 -03:00
Ivan Socolsky fe46f95b32 test for legacy clients trying to join BIP44 wallet 2015-08-31 11:59:54 -03:00
Ivan Socolsky 3ac0bc5e27 switch tests to bip44 2015-08-28 14:54:36 -03:00
Ivan Socolsky a4f1169aa9 allow addressManager to handle BIP44 derivations 2015-08-27 17:09:14 -03:00
Ivan Socolsky 7d9e43fccc initialize version field from #create method 2015-08-27 10:47:32 -03:00
Ivan Socolsky bafe84a2e0 replace feePerKB with feePerKb to match rest of API 2015-08-26 15:02:11 -03:00
Ivan Socolsky 1a047ff2a0 restore previous test 2015-08-26 11:23:13 -03:00
Kosta Korenkov a5e44070b9 Allow to exclude certain UTXO from coin selection
Optional array of lockedUtxos (in ``txid:vout`` form) can be passed with tx proposal options.
When selecting inputs for proposal, these UTXOs will not be used.
2015-08-26 12:47:45 +03:00
Ivan Socolsky 6cba8abc5c add custom data to copayers 2015-08-25 16:12:47 -03:00
Ivan Socolsky 1007ad1b05 includeExtendedInfo switch 2015-08-25 15:15:41 -03:00
Ivan Socolsky f8d9ca542d implement get status & improve tests 2015-08-25 15:15:40 -03:00
Ivan Socolsky d47bb65fdd test 2015-08-25 15:12:41 -03:00
Matias Alejo Garcia 637a1e2d8b refactor create/fromObj 2015-08-20 14:16:43 -03:00
Matias Alejo Garcia dac564f290 adds addAccess call and tests 2015-08-20 14:15:33 -03:00
Matias Alejo Garcia edc3bc6713 supports multiple pubkeys per copayer 2015-08-20 14:15:33 -03:00
Matias Alejo Garcia 3122e9ba7c test passing, rebased 2015-08-20 14:15:33 -03:00
Matias Alejo Garcia cfbf184502 removes isTemporaryRequestKey and replaceTemporaryRequestKey feature. No longer supports joining legacy (<0.9) copayers 2015-08-20 14:15:33 -03:00
Matias Alejo Garcia 3bcabaf9e4 Merge pull request #326 from isocolsky/fee_level_def
Redefine fee levels
2015-08-14 10:29:32 -03:00
Ivan Socolsky 3bd341c65f fee levels set to 1, 2, 6 2015-08-13 17:27:06 -03:00
Ivan Socolsky a8eedc8c01 rename internal constants 2015-08-13 17:24:49 -03:00
Ivan Socolsky 6421790bb1 test 2015-08-13 16:06:14 -03:00
Ivan Socolsky fca67fba8a implement utxos for external addresses 2015-08-13 12:01:22 -03:00
Ivan Socolsky 4dbcb639fe add opts param to getUtxos 2015-08-13 11:00:27 -03:00
Ivan Socolsky ad6102c7ce fix stub 2015-08-12 18:38:38 -03:00
Matias Alejo Garcia c5fc6be856 Merge pull request #322 from isocolsky/fix/fee_rounding
Fix/fee rounding
2015-08-11 17:48:43 -03:00
Ivan Socolsky 3533b60e6b change fee rounding strategy 2015-08-11 16:52:10 -03:00
Ivan Socolsky 256fb0095b improve error message 2015-08-11 16:26:16 -03:00
Ivan Socolsky af9dd5b3fe disallow signing newer txs from legacy clients 2015-08-11 14:16:58 -03:00
Ivan Socolsky e4e138e139 add TX_NOT_FOUND 2015-08-05 10:48:36 -03:00
Ivan Socolsky 76c545b110 add WALLET_NOT_COMPLETE 2015-08-05 10:44:09 -03:00