BTCPrivate
/
bitcore
mirror of https://github.com/BTCPrivate/bitcore.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

PrivateKey: Lodash to check if undefined, and made tests not random (T2)

This commit is contained in:
Braydon Fuller 2014-12-15 10:20:38 -05:00
parent 920f25b58e
commit 96c7812ed1
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/privatekey.js
View File

@ -1,5 +1,6 @@
'use strict'; 'use strict';
var _ = require('lodash');
var Address = require('./address'); var Address = require('./address');
var base58check = require('./encoding/base58check'); var base58check = require('./encoding/base58check');
var BN = require('./crypto/bn'); var BN = require('./crypto/bn');
@ -44,7 +45,7 @@ var PrivateKey = function PrivateKey(data, network, compressed) {
}; };
// detect type of data // detect type of data
if (typeof(data) === 'undefined' || data === 'random'){ if (_.isUndefined(data)){
info.bn = PrivateKey._getRandomBN(); info.bn = PrivateKey._getRandomBN();
} else if (data instanceof BN) { } else if (data instanceof BN) {
info.bn = data; info.bn = data;

4
test/privatekey.js
View File

@ -110,7 +110,7 @@ describe('PrivateKey', function() {
it('should not be able to instantiate because compressed is non-boolean', function() { it('should not be able to instantiate because compressed is non-boolean', function() {
expect(function() { expect(function() {
var a = new PrivateKey('random', 'testnet', 'compressed'); var a = new PrivateKey(BN(2), 'testnet', 'compressed');
}).to.throw('Must specify whether the corresponding public key is compressed or not (true or false)'); }).to.throw('Must specify whether the corresponding public key is compressed or not (true or false)');
}); });
@ -122,7 +122,7 @@ describe('PrivateKey', function() {
it('should not be able to instantiate with unknown network', function() { it('should not be able to instantiate with unknown network', function() {
expect(function() { expect(function() {
var a = new PrivateKey('random', 'unknown'); var a = new PrivateKey(BN(2), 'unknown');
}).to.throw('Must specify the network ("livenet" or "testnet")'); }).to.throw('Must specify the network ("livenet" or "testnet")');
}); });