diff --git a/TransactionBuilder.js b/TransactionBuilder.js index 0c75239a9..9e741ab86 100644 --- a/TransactionBuilder.js +++ b/TransactionBuilder.js @@ -830,9 +830,9 @@ TransactionBuilder.prototype._checkMergeability = function(b) { // this assumes that the same signature can not be v0 / v1 (which shouldnt be!) -TransactionBuilder.prototype._mergeInputSig = function(s0buf, s1buf) { +TransactionBuilder.prototype._mergeInputSig = function(s0buf, s1buf, ignoreConflictingSignatures) { if (buffertools.compare(s0buf,s1buf) === 0) { - console.log('BUFFERS .s MATCH'); //TODO + //console.log('BUFFERS .s MATCH'); //TODO return s0buf; } // Is multisig? @@ -874,19 +874,24 @@ TransactionBuilder.prototype._mergeInputSig = function(s0buf, s1buf) { } } - if (emptySlots.length this fails: no way to check signatures, since PRIV Keys are not stored + b = getBuilder3([{ + address: 'mrPnbY1yKDBsdgbHbS7kJ8GVm8F66hWHLE', + amount: 16 + }]) + .sign(testdata.dataUnspentSign.keyStrings); + // merge simple + b2 = getBuilder3([{ + address: 'mrPnbY1yKDBsdgbHbS7kJ8GVm8F66hWHLE', + amount: 16 + }]) + .sign(testdata.dataUnspentSign.keyStrings); + (function() {b2.merge(b);}).should.throw(); + b2.merge(b, true); + }); + + it('#merge p2sh/steps', function() { var b = getP2shBuilder(1); var k1 = testdata.dataUnspentSign.keyStringsP2sh.slice(0,1); var k2 = testdata.dataUnspentSign.keyStringsP2sh.slice(1,2); @@ -791,8 +861,5 @@ describe('TransactionBuilder', function() { b2.signaturesAdded.should.equal(3); tx = b2.build(); tx.isComplete().should.equal(true); - - - }); });