From cdfcc265e49a3f13418e994936f0699b1fe3fa9d Mon Sep 17 00:00:00 2001 From: Esteban Ordano Date: Wed, 24 Dec 2014 12:56:35 -0300 Subject: [PATCH] contributing: Add T4, test data in JSON files --- CONTRIBUTING.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d547cb3bf..dc6277761 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -193,6 +193,10 @@ DON'T: var PublicKey = require('../lib/publickey'); ``` +### T4 - Testing: Data for tests included in a JSON file + +If possible, data for tests should be included in a different JSON file from the test. This improves interoperability with other libraries and keeps tests cleaner. + ## Pull Request Workflow Our workflow is based on GitHub's pull requests. We use feature branches, prepended with: `test`, `feature`, `fix`, `refactor`, or `remove` according to the change the branch introduces. Some examples for such branches are: