From f0b9cd0cab8963dd9e83f5b5a7db073cca9c93e4 Mon Sep 17 00:00:00 2001 From: Manuel Araoz Date: Wed, 19 Mar 2014 17:12:24 -0300 Subject: [PATCH] complete base58_keys_valid tests --- Key.js | 2 +- test/test.misc.js | 11 ++++++++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/Key.js b/Key.js index e81c7b355..97d958f4b 100644 --- a/Key.js +++ b/Key.js @@ -33,7 +33,7 @@ if (process.versions) { throw new Error('Arg should be a buffer'); } var type = p[0]; - this.compressed = type!==4; + this.compressed = type!==0x04; this._pub = p; }, get: function(){ diff --git a/test/test.misc.js b/test/test.misc.js index 8757da485..822b83679 100644 --- a/test/test.misc.js +++ b/test/test.misc.js @@ -14,6 +14,7 @@ var base58Check = base58.base58Check; var Address = bitcore.Address; var networks = bitcore.networks; +var WalletKey = bitcore.WalletKey; describe('Miscelaneous stuff', function() { it('should initialze the config object', function() { @@ -71,15 +72,19 @@ describe('Miscelaneous stuff', function() { var hexPayload = datum[1]; var meta = datum[2]; it('base58 keys valid ' + b58, function() { + var network = meta.isTestnet?networks.testnet:networks.livenet; if (meta.isPrivkey) { - (true).should.equal(true); + var k = new WalletKey({network: network}); + k.fromObj({priv: b58}); + k.privKey.compressed.should.equal(meta.isCompressed); + buffertools.toHex(k.privKey.private).should.equal(hexPayload); + new Address(b58).isValid().should.equal(false); } else { var a = new Address(b58); a.isValid().should.equal(true); a.isScript().should.equal(meta.addrType === 'script'); - a.network().should.equal(meta.isTestnet?networks.testnet:networks.livenet); + a.network().should.equal(network); } - }); });