From e295e33800ce17156a7d9d8962c26092f42fd08d Mon Sep 17 00:00:00 2001
From: Manuel Araoz <manuelaraoz@gmail.com>
Date: Thu, 6 Feb 2014 12:57:47 -0300
Subject: [PATCH 1/9] starting with Transaction class

---
 bitcore.js               |  6 +++++-
 test/index.html          |  2 ++
 test/test.Address.js     |  8 ++++----
 test/test.Script.js      | 28 ++++++++++++++++++++++++++++
 test/test.Transaction.js | 28 ++++++++++++++++++++++++++++
 test/test.misc.js        | 20 ++++++++++++++++++++
 6 files changed, 87 insertions(+), 5 deletions(-)
 create mode 100644 test/test.Script.js
 create mode 100644 test/test.Transaction.js
 create mode 100644 test/test.misc.js

diff --git a/bitcore.js b/bitcore.js
index 551a8341a..699a37aaa 100644
--- a/bitcore.js
+++ b/bitcore.js
@@ -7,7 +7,11 @@ module.exports.bignum = require('bignum');
 module.exports.base58 = require('base58-native');
 module.exports.EncodedData = require('./util/EncodedData');
 module.exports.VersionedData = require('./util/VersionedData');
-module.exports.Address= require('./Address');
+module.exports.Address = require('./Address');
+module.exports.config = require('./config');
+module.exports.log = require('./util/log');
+//module.exports.Script = require('./Script');
+//module.exports.Transaction = require('./Transaction');
 
 
 if (typeof process.versions === 'undefined') {
diff --git a/test/index.html b/test/index.html
index 0d62a92fd..54914e452 100644
--- a/test/index.html
+++ b/test/index.html
@@ -20,6 +20,8 @@
     <script src="test.EncodedData.js"></script>
     <script src="test.VersionedData.js"></script>
     <script src="test.Address.js"></script>
+    <script src="test.Script.js"></script>
+    <script src="test.misc.js"></script>
     <script>
       mocha.run();
     </script>
diff --git a/test/test.Address.js b/test/test.Address.js
index ec0787bc0..5713cf5c4 100644
--- a/test/test.Address.js
+++ b/test/test.Address.js
@@ -16,14 +16,14 @@ describe('Address', function() {
     Address = AddressModule.class();
     should.exist(Address);
   });
-  it('should be able to create Address object', function() {
+  it('should be able to create instance', function() {
     var a = new Address('1KfyjCgBSMsLqiCbakfSdeoBUqMqLUiu3T');
     should.exist(a);
   });
   it('should validate correctly', function() {
-    var a = new Address("1A1zP1eP5QGefi2DMPTfTL5SLmv7DivfNa");
-    var m = new Address("32QBdjycLwbDTuGafUwaU5p5GxzSLPYoF6");
-    var b = new Address("11111111111111111111111111122222234");
+    var a = new Address('1A1zP1eP5QGefi2DMPTfTL5SLmv7DivfNa');
+    var m = new Address('32QBdjycLwbDTuGafUwaU5p5GxzSLPYoF6');
+    var b = new Address('11111111111111111111111111122222234');
     a.validate.bind(a).should.not.throw(Error);
     m.validate.bind(m).should.not.throw(Error);
     b.validate.bind(b).should.throw(Error);
diff --git a/test/test.Script.js b/test/test.Script.js
new file mode 100644
index 000000000..93085cc4c
--- /dev/null
+++ b/test/test.Script.js
@@ -0,0 +1,28 @@
+'use strict';
+
+var chai = require('chai');
+var bitcore = require('../bitcore');
+
+var should = chai.should();
+
+var ScriptModule = bitcore.Script;
+var Script;
+
+describe('Script', function() {
+  it('should initialze the main object', function() {
+    should.exist(ScriptModule);
+  });
+  it('should be able to create class', function() {
+    Script = ScriptModule.class();
+    should.exist(Script);
+  });
+  it('should be able to create instance', function() {
+    var s = new Script();
+    should.exist(s);
+  });
+});
+
+
+
+
+
diff --git a/test/test.Transaction.js b/test/test.Transaction.js
new file mode 100644
index 000000000..98889dee9
--- /dev/null
+++ b/test/test.Transaction.js
@@ -0,0 +1,28 @@
+'use strict';
+
+var chai = require('chai');
+var bitcore = require('../bitcore');
+
+var should = chai.should();
+
+var TransactionModule = bitcore.Transaction;
+var Transaction;
+
+describe('Transaction', function() {
+  it('should initialze the main object', function() {
+    should.exist(TransactionModule);
+  });
+  it('should be able to create class', function() {
+    Transaction = TransactionModule.class();
+    should.exist(Transaction);
+  });
+  it('should be able to create instance', function() {
+    var t = new Transaction();
+    should.exist(t);
+  });
+});
+
+
+
+
+
diff --git a/test/test.misc.js b/test/test.misc.js
new file mode 100644
index 000000000..7d28cbe11
--- /dev/null
+++ b/test/test.misc.js
@@ -0,0 +1,20 @@
+'use strict';
+
+var chai = require('chai');
+var bitcore = require('../bitcore');
+
+var should = chai.should();
+
+describe('Miscelaneous stuff', function() {
+  it('should initialze the config object', function() {
+    should.exist(bitcore.config);
+  });
+  it('should initialze the log object', function() {
+    should.exist(bitcore.log);
+  });
+});
+
+
+
+
+

From 0d5573dc160c12748a4e06266ad6dfa70dfaf4de Mon Sep 17 00:00:00 2001
From: Manuel Araoz <manuelaraoz@gmail.com>
Date: Thu, 6 Feb 2014 15:49:22 -0300
Subject: [PATCH 2/9] Script class working in browser!

---
 bitcore.js               |  4 +++-
 test/index.html          |  1 +
 test/test.Opcode.js      | 39 +++++++++++++++++++++++++++++++++++++++
 test/test.Transaction.js |  2 +-
 test/test.misc.js        |  4 ++++
 util/util.js             |  6 ++++--
 6 files changed, 52 insertions(+), 4 deletions(-)
 create mode 100644 test/test.Opcode.js

diff --git a/bitcore.js b/bitcore.js
index 699a37aaa..50812f43f 100644
--- a/bitcore.js
+++ b/bitcore.js
@@ -10,7 +10,9 @@ module.exports.VersionedData = require('./util/VersionedData');
 module.exports.Address = require('./Address');
 module.exports.config = require('./config');
 module.exports.log = require('./util/log');
-//module.exports.Script = require('./Script');
+module.exports.Opcode = require('./Opcode');
+module.exports.util = require('./util/util');
+module.exports.Script = require('./Script');
 //module.exports.Transaction = require('./Transaction');
 
 
diff --git a/test/index.html b/test/index.html
index 54914e452..8cf9a0ff7 100644
--- a/test/index.html
+++ b/test/index.html
@@ -20,6 +20,7 @@
     <script src="test.EncodedData.js"></script>
     <script src="test.VersionedData.js"></script>
     <script src="test.Address.js"></script>
+    <script src="test.Opcode.js"></script>
     <script src="test.Script.js"></script>
     <script src="test.misc.js"></script>
     <script>
diff --git a/test/test.Opcode.js b/test/test.Opcode.js
new file mode 100644
index 000000000..22808630e
--- /dev/null
+++ b/test/test.Opcode.js
@@ -0,0 +1,39 @@
+'use strict';
+
+var chai = require('chai');
+var bitcore = require('../bitcore');
+
+var should = chai.should();
+
+var OpcodeModule = bitcore.Opcode;
+var Opcode;
+
+describe('Opcode', function() {
+  it('should initialze the main object', function() {
+    should.exist(OpcodeModule);
+  });
+  it('should be able to create class', function() {
+    Opcode = OpcodeModule.class();
+    should.exist(Opcode);
+  });
+  it('should be able to create instance', function() {
+    var oc = new Opcode();
+    should.exist(oc);
+  });
+  it.skip('should be able to create some constants', function() {
+    for (var i in Opcode.map) {
+      eval(i + ' = ' + Opcode.map[i] + ';');
+    }
+    should.exist(OP_HASH160);
+    should.exist(OP_RETURN);
+    should.exist(OP_EQUALVERIFY);
+    should.exist(OP_CHECKSIG);
+    should.exist(OP_CHECKMULTISIG);
+
+  });
+});
+
+
+
+
+
diff --git a/test/test.Transaction.js b/test/test.Transaction.js
index 98889dee9..02da04a9e 100644
--- a/test/test.Transaction.js
+++ b/test/test.Transaction.js
@@ -8,7 +8,7 @@ var should = chai.should();
 var TransactionModule = bitcore.Transaction;
 var Transaction;
 
-describe('Transaction', function() {
+describe.skip('Transaction', function() {
   it('should initialze the main object', function() {
     should.exist(TransactionModule);
   });
diff --git a/test/test.misc.js b/test/test.misc.js
index 7d28cbe11..ab4364ade 100644
--- a/test/test.misc.js
+++ b/test/test.misc.js
@@ -12,6 +12,10 @@ describe('Miscelaneous stuff', function() {
   it('should initialze the log object', function() {
     should.exist(bitcore.log);
   });
+  it('should initialze the util object', function() {
+    should.exist(bitcore.util);
+  });
+
 });
 
 
diff --git a/util/util.js b/util/util.js
index f12a38ff1..5568610ad 100644
--- a/util/util.js
+++ b/util/util.js
@@ -1,4 +1,5 @@
-require('buffertools');
+'use strict';
+
 var crypto = require('crypto');
 var bignum = require('bignum');
 var Binary = require('binary');
@@ -327,7 +328,8 @@ var varStrBuf = exports.varStrBuf = function varStrBuf(s) {
 exports.NULL_HASH = new Buffer(32).fill(0);
 exports.EMPTY_BUFFER = new Buffer(0);
 exports.ZERO_VALUE = new Buffer(8).fill(0);
-INT64_MAX = new Buffer('ffffffffffffffff', 'hex');
+var INT64_MAX = new Buffer('ffffffffffffffff', 'hex');
+exports.INT64_MAX = INT64_MAX;
 
 // How much of Bitcoin's internal integer coin representation
 // makes 1 BTC

From 262a5d71895a583935bcb46860a736d6e48c7a87 Mon Sep 17 00:00:00 2001
From: Manuel Araoz <manuelaraoz@gmail.com>
Date: Thu, 6 Feb 2014 16:21:15 -0300
Subject: [PATCH 3/9] Added some tests for Script

---
 browser/vendor_load.js |  2 +-
 test/test.Script.js    | 13 +++++++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/browser/vendor_load.js b/browser/vendor_load.js
index 9a4251f38..4e9748306 100644
--- a/browser/vendor_load.js
+++ b/browser/vendor_load.js
@@ -1,5 +1,5 @@
 
 // load modules needed for testing in the browser
 
-var fs = require('fs');
+//var fs = require('fs');
 
diff --git a/test/test.Script.js b/test/test.Script.js
index 93085cc4c..caee5cb63 100644
--- a/test/test.Script.js
+++ b/test/test.Script.js
@@ -6,6 +6,7 @@ var bitcore = require('../bitcore');
 var should = chai.should();
 
 var ScriptModule = bitcore.Script;
+var Address = bitcore.Address.class();
 var Script;
 
 describe('Script', function() {
@@ -20,6 +21,18 @@ describe('Script', function() {
     var s = new Script();
     should.exist(s);
   });
+  it('should be able to create Script from Address', function() {
+    var addr = new Address('1J57QmkaQ6JohJoQyaUJwngJ2vTQ3C6gHi');
+    var script = Script.createPubKeyHashOut(addr.payload());
+    should.exist(script);
+    script.isPubkeyHash().should.be.true;
+  });
+  it('isP2SH should work', function() {
+    var addr = new Address('1J57QmkaQ6JohJoQyaUJwngJ2vTQ3C6gHi');
+    var script = Script.createPubKeyHashOut(addr.payload());
+    script.isP2SH.bind(script).should.not.throw(Error);
+    script.isP2SH().should.be.false;
+  });
 });
 
 

From f6549bc570752df9f652da8a91c209e82380131c Mon Sep 17 00:00:00 2001
From: Manuel Araoz <manuelaraoz@gmail.com>
Date: Thu, 6 Feb 2014 16:25:46 -0300
Subject: [PATCH 4/9] script test fix

---
 test/test.Script.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/test/test.Script.js b/test/test.Script.js
index caee5cb63..31e8523a0 100644
--- a/test/test.Script.js
+++ b/test/test.Script.js
@@ -30,7 +30,6 @@ describe('Script', function() {
   it('isP2SH should work', function() {
     var addr = new Address('1J57QmkaQ6JohJoQyaUJwngJ2vTQ3C6gHi');
     var script = Script.createPubKeyHashOut(addr.payload());
-    script.isP2SH.bind(script).should.not.throw(Error);
     script.isP2SH().should.be.false;
   });
 });

From a26665ec80fe7ffd5aec3cb5ae7a3cfc8ccf45ef Mon Sep 17 00:00:00 2001
From: Manuel Araoz <manuelaraoz@gmail.com>
Date: Thu, 6 Feb 2014 16:58:59 -0300
Subject: [PATCH 5/9] trying to fix Opcode test

---
 test/test.Opcode.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/test/test.Opcode.js b/test/test.Opcode.js
index 22808630e..4d6336b91 100644
--- a/test/test.Opcode.js
+++ b/test/test.Opcode.js
@@ -22,8 +22,10 @@ describe('Opcode', function() {
   });
   it.skip('should be able to create some constants', function() {
     for (var i in Opcode.map) {
-      eval(i + ' = ' + Opcode.map[i] + ';');
+      console.log('var '+i + ' = ' + Opcode.map[i] + ';');
+      eval('var '+i + ' = ' + Opcode.map[i] + ';');
     }
+    should.exist(OP_VER);
     should.exist(OP_HASH160);
     should.exist(OP_RETURN);
     should.exist(OP_EQUALVERIFY);

From 286640e8276249742eff4e8b3f09f6e64d720036 Mon Sep 17 00:00:00 2001
From: Mike van Rossum <mike@mikevanrossum.nl>
Date: Sat, 15 Feb 2014 01:04:43 +0100
Subject: [PATCH 6/9] Normalized object notation

---
 networks.js | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/networks.js b/networks.js
index d5086f103..97a1fa99e 100644
--- a/networks.js
+++ b/networks.js
@@ -16,21 +16,21 @@ exports.livenet = {
     bits: 486604799
   },
   genesisBlockTx: {
-    'outs': [{
-      'v': hex('00F2052A01000000'), // 50 BTC
-      's': new Put()
+    outs: [{
+      v: hex('00F2052A01000000'), // 50 BTC
+      s: new Put()
         .word8(65) // 65 bytes of data follow
         .put(hex('04678AFDB0FE5548271967F1A67130B7105CD6A828E03909A67962E0EA1F61DEB649F6BC3F4CEF38C4F35504E51EC112DE5C384DF7BA0B8D578A4C702B6BF11D5F'))
         .word8(0xAC) // OP_CHECKSIG
         .buffer()
     }],
-    'lock_time': 0,
-    'version': 1,
-    'hash': hex('3BA3EDFD7A7B12B27AC72C3E67768F617FC81BC3888A51323A9FB8AA4B1E5E4A'),
-    'ins': [{
-      'q': 0xFFFFFFFF,
-      'o': hex("0000000000000000000000000000000000000000000000000000000000000000FFFFFFFF"),
-      's': new Put()
+    lock_time: 0,
+    version: 1,
+    hash: hex('3BA3EDFD7A7B12B27AC72C3E67768F617FC81BC3888A51323A9FB8AA4B1E5E4A'),
+    ins: [{
+      q: 0xFFFFFFFF,
+      o: hex("0000000000000000000000000000000000000000000000000000000000000000FFFFFFFF"),
+      s: new Put()
         .put(hex('04FFFF001D010445'))
         .put(new Buffer('The Times 03/Jan/2009 Chancellor on brink of ' +
                         'second bailout for banks', 'ascii'))

From ab81de3c7953e75c013eb02f89115ea56eaf3b4a Mon Sep 17 00:00:00 2001
From: Manuel Araoz <manuelaraoz@gmail.com>
Date: Mon, 17 Feb 2014 17:18:07 -0300
Subject: [PATCH 7/9] skipped problematic testcase

---
 test/test.Opcode.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/test/test.Opcode.js b/test/test.Opcode.js
index 4d6336b91..fa78f5e59 100644
--- a/test/test.Opcode.js
+++ b/test/test.Opcode.js
@@ -21,9 +21,11 @@ describe('Opcode', function() {
     should.exist(oc);
   });
   it.skip('should be able to create some constants', function() {
+    // TODO: test works in node but not in browser
     for (var i in Opcode.map) {
       console.log('var '+i + ' = ' + Opcode.map[i] + ';');
       eval('var '+i + ' = ' + Opcode.map[i] + ';');
+      console.log(eval(i));
     }
     should.exist(OP_VER);
     should.exist(OP_HASH160);

From 70c47d2943031c677445d316a4e7340a6e9b035d Mon Sep 17 00:00:00 2001
From: Manuel Araoz <manuelaraoz@gmail.com>
Date: Mon, 17 Feb 2014 17:20:50 -0300
Subject: [PATCH 8/9] remove use strict

---
 Address.js | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Address.js b/Address.js
index 35a430e40..e429a3192 100644
--- a/Address.js
+++ b/Address.js
@@ -1,5 +1,3 @@
-'use strict';
-
 require('classtool');
 
 function ClassSpec(b) {

From 05bb2ff3df346be00ddfa7955efbd453cf9891bd Mon Sep 17 00:00:00 2001
From: Manuel Araoz <manuelaraoz@gmail.com>
Date: Mon, 17 Feb 2014 17:55:56 -0300
Subject: [PATCH 9/9] change name for sin-test

---
 bitcore.js       |  1 +
 sin-test.js      |  7 -------
 test/test.SIN.js | 30 ++++++++++++++++++++++++++++++
 3 files changed, 31 insertions(+), 7 deletions(-)
 delete mode 100644 sin-test.js
 create mode 100644 test/test.SIN.js

diff --git a/bitcore.js b/bitcore.js
index 50812f43f..89eeef3ab 100644
--- a/bitcore.js
+++ b/bitcore.js
@@ -13,6 +13,7 @@ module.exports.log = require('./util/log');
 module.exports.Opcode = require('./Opcode');
 module.exports.util = require('./util/util');
 module.exports.Script = require('./Script');
+module.exports.SINKey = require('./SINKey');
 //module.exports.Transaction = require('./Transaction');
 
 
diff --git a/sin-test.js b/sin-test.js
deleted file mode 100644
index df00923bf..000000000
--- a/sin-test.js
+++ /dev/null
@@ -1,7 +0,0 @@
-
-var SINKey = require('./SINKey').class();
-
-var sk = new SINKey();
-sk.generate();
-console.dir(sk.storeObj());
-
diff --git a/test/test.SIN.js b/test/test.SIN.js
new file mode 100644
index 000000000..469c318fd
--- /dev/null
+++ b/test/test.SIN.js
@@ -0,0 +1,30 @@
+'use strict';
+
+
+
+var chai = require('chai');
+var bitcore = require('../bitcore');
+
+var should = chai.should();
+
+var SINKeyModule = bitcore.SINKey;
+var SINKey;
+
+
+describe('SINKey', function() {
+  it('should initialze the main object', function() {
+    should.exist(SINKeyModule);
+  });
+  it('should be able to create class', function() {
+    SINKey = SINKeyModule.class();
+    should.exist(SINKey);
+  });
+  it('should be able to create instance', function() {
+    var sk = new SINKey();
+    sk.generate();
+    should.exist(sk.created);
+    should.exist(sk.privKey.private);
+    should.exist(sk.privKey.public);
+    should.exist(sk.privKey.compressed);
+  });
+});