3ace170ac5
Ignore fee error when unspent output is actually negative, rather than already when the check for negative unspent output is disabled.
2015-05-23 20:13:53 -04:00
ac2fbe2777
When disableMoreOutputThanInput is set for getSerializationError, also disable the fee checks as the concept of a fee is meaningless when unspent output value is negative. This also allows for removing the opts from buildSkipTest again and simplifying the skip test for disableMoreOutputThanInput.
2015-05-23 20:13:53 -04:00
dc07788e53
Put )); on a separate line.
2015-05-23 20:13:53 -04:00
6729b38944
Expect the correct error to be thrown.
2015-05-23 20:13:53 -04:00
8c5b2c851b
When checking for transaction serialization errors, check the output amount before checking fee errors. Added a test for it and also improved buildSkipTest by specifying which error to expect and using it for some tests where it wasn't used yet.
2015-05-23 20:13:53 -04:00
001f71d1bf
Merge pull request #1245 from maraoz/reorg-tests
...
reorganize block test files
2015-05-23 17:13:05 -04:00
74e285dadd
fix imports for block tests
2015-05-23 16:44:11 -03:00
6e49ed0e40
reorganize block test files
2015-05-20 14:42:48 -03:00
ea9be99854
Bump package version to 0.12.6
2015-05-20 10:35:07 -04:00
b53f249d02
Merge pull request #1235 from maraoz/transaction/clearOutputs
...
add Transaction#clearOutputs
2015-05-18 16:24:02 -04:00
85dd29e576
Merge pull request #1227 from fanatid/fix/inBrowser
...
remove inBrowser
2015-05-18 16:22:14 -04:00
c251c2bfd1
Merge pull request #1226 from dskloet/refactor/get-serialization-error
...
Simplify transaction.getSerializationError()
2015-05-18 15:08:50 -04:00
1c8ebc0eb5
Simplify version guard
...
- Updated index.js test to run in Node.js and browsers
- Simplified message and clarified case where two of the same versions would conflict
2015-05-18 15:00:45 -04:00
83103cb5e2
Merge pull request #1239 from braydonf/bug/getdata
...
Added test case for an empty OP_RETURN for script.getData() Fixes #1237
2015-05-18 10:05:49 -05:00
7723dd302a
Added test case for an empty OP_RETURN for script.getData() Fixes #1237
2015-05-18 10:39:15 -04:00
7e3993578c
improve guard for prevent more than one instance of bitcore
2015-05-17 10:09:18 +03:00
99d8ac1957
Remove an unnecessary space.
2015-05-16 22:54:30 +02:00
3d9560c0c5
Don't break lines at 80 characters.
2015-05-16 22:50:44 +02:00
8a8412f04a
Don't break lines at 80 characters.
2015-05-16 17:06:35 +02:00
8a13a22baf
add Transaction#clearOutputs
2015-05-15 15:29:05 -03:00
5fe53ac36d
Bump package version to 0.12.5
2015-05-14 10:50:33 -04:00
796fbc2346
Merge pull request #1231 from braydonf/bug/output-to-script
...
Handling Invalid Output Scripts. Closes #1230
2015-05-14 09:31:13 -05:00
458abe069e
Fixed issue with handling invalid output scripts
...
- Changed toObject serialization to always use a hexa string for a script
- Updated inspect method to handle a null script
- Roundtrip toObject/fromObject with an invalid script
- Additional test coverage for Output
2015-05-14 01:50:14 -04:00
0dbd9db0ea
Merge pull request #1233 from carnesen/typo
...
Typo "formated"
2015-05-13 18:59:31 -04:00
ec2d726e49
typo "formated"
2015-05-13 15:48:23 -07:00
beeb294e45
Merge pull request #1217 from fanatid/fix/writeable
...
fix typo: defineProperty.writeable
2015-05-13 09:22:56 -04:00
4bc3356b78
Merge pull request #1229 from dskloet/test/fix-transaction
...
Some transaction tests were not run…
2015-05-13 09:13:54 -04:00
e294505486
Some transaction tests were not run because of the way they were built. Fixed this so they are run and fixed one test that still assumed the dust limit at 5460 instead of 546.
2015-05-13 09:14:00 +02:00
26bd5a864a
Simplify transaction.getSerializationError(). This takes care of some lint errors about number of statements and cyclomatic complexity.
2015-05-13 00:26:33 +02:00
bb843ee6a5
Merge pull request #1225 from pnagurny/feature/nullScript
...
If output.script is InvalidBuffer, return null instead of throwing error. Closes #880 . Closes #1216 .
2015-05-12 17:36:47 -04:00
de078a40d3
If output.script is InvalidBuffer, return null instead of throwing error
2015-05-12 17:23:56 -04:00
a02258dfba
Merge pull request #1218 from maraoz/docs/pubkeys
...
improve PublicKey docs and fix #1215
2015-05-12 13:31:34 -04:00
48761fd08f
formatting fixes on pubkey docs
2015-05-12 13:47:14 -03:00
8e7528d13f
Merge pull request #1219 from braydonf/coverage/transaction
...
Added coverage to transaction and fixed bug with serialization check.
2015-05-11 17:48:50 -04:00
fd36c392e4
Merge pull request #1220 from braydonf/fix/hd-docs
...
Update HDPrivateKey docs. Fixes #1209
2015-05-11 17:39:56 -04:00
993125428e
Merge pull request #1213 from braydonf/bug/is-fully-signed
...
Fixed script.isPublicKeyHashIn bug with variable length signatures.
2015-05-11 15:12:44 -04:00
55f663737f
Update HDPrivateKey docs. Fixes #1209
2015-05-11 14:30:58 -04:00
53b6171547
Added coverage to transaction and fixed bug with serialization check.
2015-05-11 13:39:53 -04:00
6a3e10539c
small doc fixes
2015-05-11 12:47:25 -03:00
951a07c011
fix PublicKey.toObject
2015-05-11 12:24:45 -03:00
74b93e228c
add compressed vs uncompressed docs
2015-05-11 12:07:17 -03:00
698625cc47
Merge pull request #1214 from dskloet/fix/fee
...
Don't ignore the fee when it's explicitly specified.
2015-05-11 10:28:19 -04:00
346b2af446
delete writable for accessor property
2015-05-10 23:55:55 +03:00
056f171e22
Remove the ability to disable the check that a specified fee is equal to the unspent value.
2015-05-10 01:32:28 +02:00
b1e54101d3
Call the parent error of the fee errors FeeError for backwards compatibility.
2015-05-10 00:38:56 +02:00
8da9c4a44a
Give the 3 fee errors a common parent error.
2015-05-10 00:32:27 +02:00
d1eb190626
Introduce different kinds of FeeError to distinguish the different cases. Fix the issue uncovered by this, which is that getFee might not be the actual fee, but only an estimate, if a change address is specified but there isn't enough to pay a fee and have change.
2015-05-09 21:06:40 +02:00
16dc489b08
Make sure a specified transaction fee and outputs add up to the sum of the inputs. Don't ignore the fee when it's explicitly specified.
2015-05-09 18:44:26 +02:00
d8e90685f4
Fixed script.isPublicKeyHashIn bug with variable length signatures.
...
- DER encoded signatures have a max length of 72 bytes, however a minimum size isn't defined.
- R and S values can have arbitrary lengths
- For more information: https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#der-encoding
2015-05-08 22:09:42 -04:00
baf39f3c5f
Bump package version to 0.12.4
2015-05-06 15:21:19 -03:00
David de Kloet
Braydon Fuller
Manuel Araoz
Patrick Nagurny
Kirill Fomichev
Chris Arnesen
Patrick Nagurny
Eric Martindale