a03e6b9385
Add base option for BN.fromString
2015-05-27 14:11:43 -04:00
4c1ba674c5
Merge pull request #1248 from braydonf/bug/misleading-error
...
Fixes bug with misleading error with getSerializationError. Closes #1236
2015-05-26 11:32:51 -06:00
a5cd5a1407
Added support for uncompressed public keys to Signature.fromCompact
2015-05-25 23:57:46 -04:00
589d017a14
Refactored transaction.getSerializationError to be more concise.
...
- _hasMoreOutputThanInput() and _isInvalidSatoshis() merged with getSerializationError()
- _isFeeDifferent(), _isFeeTooLarge() and _isFeeTooSmall merged with _hasFeeError()
2015-05-23 20:13:53 -04:00
0b6eaf0f1e
Call getUnspentValue() only once in getSerializationError().
2015-05-23 20:13:53 -04:00
3ace170ac5
Ignore fee error when unspent output is actually negative, rather than already when the check for negative unspent output is disabled.
2015-05-23 20:13:53 -04:00
ac2fbe2777
When disableMoreOutputThanInput is set for getSerializationError, also disable the fee checks as the concept of a fee is meaningless when unspent output value is negative. This also allows for removing the opts from buildSkipTest again and simplifying the skip test for disableMoreOutputThanInput.
2015-05-23 20:13:53 -04:00
8c5b2c851b
When checking for transaction serialization errors, check the output amount before checking fee errors. Added a test for it and also improved buildSkipTest by specifying which error to expect and using it for some tests where it wasn't used yet.
2015-05-23 20:13:53 -04:00
b53f249d02
Merge pull request #1235 from maraoz/transaction/clearOutputs
...
add Transaction#clearOutputs
2015-05-18 16:24:02 -04:00
c251c2bfd1
Merge pull request #1226 from dskloet/refactor/get-serialization-error
...
Simplify transaction.getSerializationError()
2015-05-18 15:08:50 -04:00
7723dd302a
Added test case for an empty OP_RETURN for script.getData() Fixes #1237
2015-05-18 10:39:15 -04:00
99d8ac1957
Remove an unnecessary space.
2015-05-16 22:54:30 +02:00
3d9560c0c5
Don't break lines at 80 characters.
2015-05-16 22:50:44 +02:00
8a8412f04a
Don't break lines at 80 characters.
2015-05-16 17:06:35 +02:00
8a13a22baf
add Transaction#clearOutputs
2015-05-15 15:29:05 -03:00
458abe069e
Fixed issue with handling invalid output scripts
...
- Changed toObject serialization to always use a hexa string for a script
- Updated inspect method to handle a null script
- Roundtrip toObject/fromObject with an invalid script
- Additional test coverage for Output
2015-05-14 01:50:14 -04:00
0dbd9db0ea
Merge pull request #1233 from carnesen/typo
...
Typo "formated"
2015-05-13 18:59:31 -04:00
ec2d726e49
typo "formated"
2015-05-13 15:48:23 -07:00
beeb294e45
Merge pull request #1217 from fanatid/fix/writeable
...
fix typo: defineProperty.writeable
2015-05-13 09:22:56 -04:00
26bd5a864a
Simplify transaction.getSerializationError(). This takes care of some lint errors about number of statements and cyclomatic complexity.
2015-05-13 00:26:33 +02:00
de078a40d3
If output.script is InvalidBuffer, return null instead of throwing error
2015-05-12 17:23:56 -04:00
a02258dfba
Merge pull request #1218 from maraoz/docs/pubkeys
...
improve PublicKey docs and fix #1215
2015-05-12 13:31:34 -04:00
8e7528d13f
Merge pull request #1219 from braydonf/coverage/transaction
...
Added coverage to transaction and fixed bug with serialization check.
2015-05-11 17:48:50 -04:00
993125428e
Merge pull request #1213 from braydonf/bug/is-fully-signed
...
Fixed script.isPublicKeyHashIn bug with variable length signatures.
2015-05-11 15:12:44 -04:00
53b6171547
Added coverage to transaction and fixed bug with serialization check.
2015-05-11 13:39:53 -04:00
951a07c011
fix PublicKey.toObject
2015-05-11 12:24:45 -03:00
346b2af446
delete writable for accessor property
2015-05-10 23:55:55 +03:00
056f171e22
Remove the ability to disable the check that a specified fee is equal to the unspent value.
2015-05-10 01:32:28 +02:00
b1e54101d3
Call the parent error of the fee errors FeeError for backwards compatibility.
2015-05-10 00:38:56 +02:00
8da9c4a44a
Give the 3 fee errors a common parent error.
2015-05-10 00:32:27 +02:00
d1eb190626
Introduce different kinds of FeeError to distinguish the different cases. Fix the issue uncovered by this, which is that getFee might not be the actual fee, but only an estimate, if a change address is specified but there isn't enough to pay a fee and have change.
2015-05-09 21:06:40 +02:00
16dc489b08
Make sure a specified transaction fee and outputs add up to the sum of the inputs. Don't ignore the fee when it's explicitly specified.
2015-05-09 18:44:26 +02:00
d8e90685f4
Fixed script.isPublicKeyHashIn bug with variable length signatures.
...
- DER encoded signatures have a max length of 72 bytes, however a minimum size isn't defined.
- R and S values can have arbitrary lengths
- For more information: https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#der-encoding
2015-05-08 22:09:42 -04:00
f8ea7e39cc
Included satoshis check during checked serialization.
2015-04-30 13:23:44 -04:00
cd12164fae
Added test coverage to transaction.verify
2015-04-30 12:09:59 -04:00
3d447ded79
Update bn.js to 2.0.4 to handle 53 bit precision number input.
2015-04-30 11:20:09 -04:00
a018a23b6b
fix bug in recognizing p2sh input scripts
2015-04-30 03:24:15 -03:00
db6234b500
remove duplicate code, increase coverage
2015-04-29 19:45:41 -03:00
fe17f20a97
remove console.log
2015-04-29 18:57:17 -03:00
d556a0c33d
fix regressions
2015-04-29 18:55:42 -03:00
dfc075e5d1
fix block parsing problem
2015-04-29 17:29:33 -03:00
270413a655
add simpler test that fails
2015-04-29 15:54:41 -03:00
722eddb894
add test that exposes bug
2015-04-29 15:31:46 -03:00
a03daab866
Merge pull request #1196 from maraoz/script/coverage
...
increase script test coverage
2015-04-29 10:20:45 -04:00
e1921429cf
remove stray console.log
2015-04-28 19:17:45 -03:00
100e370295
fix regressions after changes
2015-04-28 17:10:06 -03:00
9a50958943
fix Block#toObject API
2015-04-28 16:42:56 -03:00
dff0891871
add failing test for Block#toObject
2015-04-28 15:17:41 -03:00
05a8cf9630
sighash: remove dead branch
2015-04-27 18:49:45 +10:00
2cccf20c9d
improve docs to show signatures type
2015-04-22 14:33:09 -03:00
Braydon Fuller
Patrick Nagurny
David de Kloet
Manuel Araoz
Chris Arnesen
Patrick Nagurny
Eric Martindale
Kirill Fomichev
Daniel Cousens