ac2fbe2777
When disableMoreOutputThanInput is set for getSerializationError, also disable the fee checks as the concept of a fee is meaningless when unspent output value is negative. This also allows for removing the opts from buildSkipTest again and simplifying the skip test for disableMoreOutputThanInput.
2015-05-23 20:13:53 -04:00
dc07788e53
Put )); on a separate line.
2015-05-23 20:13:53 -04:00
6729b38944
Expect the correct error to be thrown.
2015-05-23 20:13:53 -04:00
8c5b2c851b
When checking for transaction serialization errors, check the output amount before checking fee errors. Added a test for it and also improved buildSkipTest by specifying which error to expect and using it for some tests where it wasn't used yet.
2015-05-23 20:13:53 -04:00
74e285dadd
fix imports for block tests
2015-05-23 16:44:11 -03:00
6e49ed0e40
reorganize block test files
2015-05-20 14:42:48 -03:00
b53f249d02
Merge pull request #1235 from maraoz/transaction/clearOutputs
...
add Transaction#clearOutputs
2015-05-18 16:24:02 -04:00
85dd29e576
Merge pull request #1227 from fanatid/fix/inBrowser
...
remove inBrowser
2015-05-18 16:22:14 -04:00
1c8ebc0eb5
Simplify version guard
...
- Updated index.js test to run in Node.js and browsers
- Simplified message and clarified case where two of the same versions would conflict
2015-05-18 15:00:45 -04:00
7723dd302a
Added test case for an empty OP_RETURN for script.getData() Fixes #1237
2015-05-18 10:39:15 -04:00
7e3993578c
improve guard for prevent more than one instance of bitcore
2015-05-17 10:09:18 +03:00
8a13a22baf
add Transaction#clearOutputs
2015-05-15 15:29:05 -03:00
458abe069e
Fixed issue with handling invalid output scripts
...
- Changed toObject serialization to always use a hexa string for a script
- Updated inspect method to handle a null script
- Roundtrip toObject/fromObject with an invalid script
- Additional test coverage for Output
2015-05-14 01:50:14 -04:00
e294505486
Some transaction tests were not run because of the way they were built. Fixed this so they are run and fixed one test that still assumed the dust limit at 5460 instead of 546.
2015-05-13 09:14:00 +02:00
de078a40d3
If output.script is InvalidBuffer, return null instead of throwing error
2015-05-12 17:23:56 -04:00
a02258dfba
Merge pull request #1218 from maraoz/docs/pubkeys
...
improve PublicKey docs and fix #1215
2015-05-12 13:31:34 -04:00
8e7528d13f
Merge pull request #1219 from braydonf/coverage/transaction
...
Added coverage to transaction and fixed bug with serialization check.
2015-05-11 17:48:50 -04:00
993125428e
Merge pull request #1213 from braydonf/bug/is-fully-signed
...
Fixed script.isPublicKeyHashIn bug with variable length signatures.
2015-05-11 15:12:44 -04:00
53b6171547
Added coverage to transaction and fixed bug with serialization check.
2015-05-11 13:39:53 -04:00
951a07c011
fix PublicKey.toObject
2015-05-11 12:24:45 -03:00
b1e54101d3
Call the parent error of the fee errors FeeError for backwards compatibility.
2015-05-10 00:38:56 +02:00
8da9c4a44a
Give the 3 fee errors a common parent error.
2015-05-10 00:32:27 +02:00
d1eb190626
Introduce different kinds of FeeError to distinguish the different cases. Fix the issue uncovered by this, which is that getFee might not be the actual fee, but only an estimate, if a change address is specified but there isn't enough to pay a fee and have change.
2015-05-09 21:06:40 +02:00
16dc489b08
Make sure a specified transaction fee and outputs add up to the sum of the inputs. Don't ignore the fee when it's explicitly specified.
2015-05-09 18:44:26 +02:00
d8e90685f4
Fixed script.isPublicKeyHashIn bug with variable length signatures.
...
- DER encoded signatures have a max length of 72 bytes, however a minimum size isn't defined.
- R and S values can have arbitrary lengths
- For more information: https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#der-encoding
2015-05-08 22:09:42 -04:00
b688334bf3
Added test case for zero in isNaturalNumber tests.
2015-05-06 13:37:17 -04:00
f8ea7e39cc
Included satoshis check during checked serialization.
2015-04-30 13:23:44 -04:00
cd12164fae
Added test coverage to transaction.verify
2015-04-30 12:09:59 -04:00
3d447ded79
Update bn.js to 2.0.4 to handle 53 bit precision number input.
2015-04-30 11:20:09 -04:00
a018a23b6b
fix bug in recognizing p2sh input scripts
2015-04-30 03:24:15 -03:00
bbd48f868d
remove comment
2015-04-29 19:47:35 -03:00
db6234b500
remove duplicate code, increase coverage
2015-04-29 19:45:41 -03:00
d556a0c33d
fix regressions
2015-04-29 18:55:42 -03:00
dfc075e5d1
fix block parsing problem
2015-04-29 17:29:33 -03:00
270413a655
add simpler test that fails
2015-04-29 15:54:41 -03:00
722eddb894
add test that exposes bug
2015-04-29 15:31:46 -03:00
a03daab866
Merge pull request #1196 from maraoz/script/coverage
...
increase script test coverage
2015-04-29 10:20:45 -04:00
100e370295
fix regressions after changes
2015-04-28 17:10:06 -03:00
9a50958943
fix Block#toObject API
2015-04-28 16:42:56 -03:00
dff0891871
add failing test for Block#toObject
2015-04-28 15:17:41 -03:00
ee6f8d35ef
increase script test coverage
2015-04-22 14:32:10 -03:00
ca96359f40
Immutable network Object
2015-04-11 17:05:46 +03:00
bcd4efb724
Added `checkState` for positive integer in Output satoshis
2015-04-10 18:39:08 -04:00
3005e19cbf
Added precondition to transaction.to for a positive integer as an amount
2015-04-10 18:07:20 -04:00
aaa8c8aa67
fix index.html
2015-04-08 17:38:18 -03:00
e331c4ea49
allow addresses to have surrounding whitespace in validation
2015-03-31 17:54:06 -03:00
c010cb8c50
drop cached value for inputAmount and outputAmount
2015-03-31 16:22:27 +03:00
53d23e501c
Merge pull request #1162 from fanatid/fix/isPublicKeyHashOut
...
[BUG] Script.isPublicKeyHashOut
2015-03-30 02:31:09 -03:00
4f4b2b93fb
Allow arrays as second arg to Networks.get
2015-03-29 22:56:29 -03:00
116024a7cb
fix Script.isPublicKeyHashOut
2015-03-29 20:55:13 +03:00
David de Kloet
Manuel Araoz
Braydon Fuller
Kirill Fomichev
Patrick Nagurny
Eric Martindale
eordano