Commit Graph

108 Commits

Author SHA1 Message Date
David de Kloet 8c5b2c851b When checking for transaction serialization errors, check the output amount before checking fee errors. Added a test for it and also improved buildSkipTest by specifying which error to expect and using it for some tests where it wasn't used yet. 2015-05-23 20:13:53 -04:00
Braydon Fuller b53f249d02 Merge pull request #1235 from maraoz/transaction/clearOutputs
add Transaction#clearOutputs
2015-05-18 16:24:02 -04:00
Braydon Fuller c251c2bfd1 Merge pull request #1226 from dskloet/refactor/get-serialization-error
Simplify transaction.getSerializationError()
2015-05-18 15:08:50 -04:00
David de Kloet 99d8ac1957 Remove an unnecessary space. 2015-05-16 22:54:30 +02:00
David de Kloet 3d9560c0c5 Don't break lines at 80 characters. 2015-05-16 22:50:44 +02:00
David de Kloet 8a8412f04a Don't break lines at 80 characters. 2015-05-16 17:06:35 +02:00
Manuel Araoz 8a13a22baf add Transaction#clearOutputs 2015-05-15 15:29:05 -03:00
Braydon Fuller beeb294e45 Merge pull request #1217 from fanatid/fix/writeable
fix typo: defineProperty.writeable
2015-05-13 09:22:56 -04:00
David de Kloet 26bd5a864a Simplify transaction.getSerializationError(). This takes care of some lint errors about number of statements and cyclomatic complexity. 2015-05-13 00:26:33 +02:00
Braydon Fuller 53b6171547 Added coverage to transaction and fixed bug with serialization check. 2015-05-11 13:39:53 -04:00
Kirill Fomichev 346b2af446 delete writable for accessor property 2015-05-10 23:55:55 +03:00
David de Kloet 056f171e22 Remove the ability to disable the check that a specified fee is equal to the unspent value. 2015-05-10 01:32:28 +02:00
David de Kloet b1e54101d3 Call the parent error of the fee errors FeeError for backwards compatibility. 2015-05-10 00:38:56 +02:00
David de Kloet 8da9c4a44a Give the 3 fee errors a common parent error. 2015-05-10 00:32:27 +02:00
David de Kloet d1eb190626 Introduce different kinds of FeeError to distinguish the different cases. Fix the issue uncovered by this, which is that getFee might not be the actual fee, but only an estimate, if a change address is specified but there isn't enough to pay a fee and have change. 2015-05-09 21:06:40 +02:00
David de Kloet 16dc489b08 Make sure a specified transaction fee and outputs add up to the sum of the inputs. Don't ignore the fee when it's explicitly specified. 2015-05-09 18:44:26 +02:00
Braydon Fuller f8ea7e39cc Included satoshis check during checked serialization. 2015-04-30 13:23:44 -04:00
Braydon Fuller cd12164fae Added test coverage to transaction.verify 2015-04-30 12:09:59 -04:00
Braydon Fuller 3d447ded79 Update bn.js to 2.0.4 to handle 53 bit precision number input. 2015-04-30 11:20:09 -04:00
Manuel Araoz d556a0c33d fix regressions 2015-04-29 18:55:42 -03:00
Manuel Araoz e1921429cf remove stray console.log 2015-04-28 19:17:45 -03:00
Manuel Araoz 9a50958943 fix Block#toObject API 2015-04-28 16:42:56 -03:00
Braydon Fuller 3005e19cbf Added precondition to transaction.to for a positive integer as an amount 2015-04-10 18:07:20 -04:00
Braydon Fuller 6367cbe368 Fixed typos in transaction.verify error messages 2015-04-08 12:46:18 -04:00
Kirill Fomichev c010cb8c50 drop cached value for inputAmount and outputAmount 2015-03-31 16:22:27 +03:00
Chris Arnesen 8af63ec8d0 update transaction.getFee() JSDoc 2015-03-26 15:41:41 -07:00
eordano 294ff097a1 Add error if shuffle function doesnt return an expected result 2015-03-11 15:49:42 -03:00
eordano a37e7b140c Add functionality to randomize outputs 2015-03-11 15:38:53 -03:00
Manuel Araoz b92fd915eb increase coverage for Input and Output, fix some bugs 2015-02-27 18:46:27 -03:00
Manuel Araoz d5fd3919c9 add Transaction#inputAmount and outputAmount 2015-02-27 16:38:48 -03:00
eordano 405f4f43df Update dust amount 2015-02-24 17:24:22 -03:00
eordano 2f86f323c0 Add link when throwing a serialization error 2015-02-24 16:41:15 -03:00
eordano 97671abfdc Add more docs on serialization checks 2015-02-24 16:36:08 -03:00
eordano b81624480a transaction: Fix verbosity of jsdocs 2015-02-24 16:34:52 -03:00
eordano c5d7eacfac Add check for output amount > input amount 2015-02-24 16:34:52 -03:00
eordano f0f90c5d6a Change unnecesarily big name 2015-02-24 13:04:40 -03:00
eordano a6df7a175e Better granularity on serialize() checks 2015-02-24 13:02:34 -03:00
Manuel Aráoz e2ff93b714 Merge pull request #1083 from eordano/feature/multisigchecks
Transaction: Check that threshold is less than amount of signatures
2015-02-18 12:01:58 -03:00
eordano c19d5c6501 Transaction: Check that threshold is less than amount of signatures 2015-02-18 11:52:50 -03:00
Manuel Aráoz 4c822e06c5 Merge pull request #1078 from eordano/fix/smallFee
Add check for small fees
2015-02-18 11:30:21 -03:00
eordano 7e88167891 Add check for small fees 2015-02-16 12:47:53 -03:00
Trevin Hofmann 59a9e40f13 Properly capitalize BufferUtil everywhere
Right out of CONTRIBUTING.md

https://github.com/bitpay/bitcore/blob/master/CONTRIBUTING.md#g6---naming-utility-namespaces
2015-02-13 21:21:06 -06:00
Trevin Hofmann ea2a0163c4 Remove redundant util requirement
The Transaction class was requiring bitcore.util.js twice, as `util` and
`JSUtil`. It seems `JSUtil` is the standard name in other classes.
2015-02-13 21:06:51 -06:00
Manuel Aráoz a9533546b2 remove console.log 2015-02-11 19:28:15 -03:00
Manuel Araoz 0e1de0403e remove logs 2015-02-11 12:21:42 -03:00
Manuel Araoz 8ca396c34f refactor transaction input deserializtion 2015-02-11 11:40:24 -03:00
Manuel Araoz 0f17927fde fix 0 fee error 2015-02-10 18:29:14 -03:00
Manuel Araoz aa1158097d fix bug in change calculation 2015-02-10 18:12:45 -03:00
Manuel Araoz 986264e181 add locktime docs and Transaction#getLockTime 2015-02-10 13:03:07 -03:00
Esteban Ordano f8974b383a transaction: Change variable name from time to height 2015-02-10 10:29:29 -03:00