From 0ceaa31acb120a1c4efcbe65701835d8c7e15324 Mon Sep 17 00:00:00 2001 From: Jason Dreyzehner Date: Mon, 19 Feb 2018 11:45:26 -0500 Subject: [PATCH] lint: reenable tslint no-console, ignore in logger, e2e --- src/providers/logger/logger.ts | 1 + test/e2e/screenshots.ts | 1 + tslint.json | 1 - 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/providers/logger/logger.ts b/src/providers/logger/logger.ts index 6a3d4a29d..96f1f492a 100644 --- a/src/providers/logger/logger.ts +++ b/src/providers/logger/logger.ts @@ -96,6 +96,7 @@ export class Logger { else v = JSON.stringify(v); } } catch (e) { + // tslint:disable-next-line:no-console console.log('Error at log decorator:', e); v = 'undefined'; } diff --git a/test/e2e/screenshots.ts b/test/e2e/screenshots.ts index 64665697f..1ad3ca037 100644 --- a/test/e2e/screenshots.ts +++ b/test/e2e/screenshots.ts @@ -29,6 +29,7 @@ export async function takeScreenshot(name: string) { const pngData = await browser.takeScreenshot(); const path = join(dir, `${name}_${deviceName}.png`); writeFile(path, pngData, { encoding: 'base64' }, err => { + // tslint:disable-next-line:no-console err ? console.error(err) : console.log(`File written: ${path}`); }); } diff --git a/tslint.json b/tslint.json index b15847754..c667e6d1d 100644 --- a/tslint.json +++ b/tslint.json @@ -24,7 +24,6 @@ "interface-name": false, "prefer-conditional-expression": false, "prefer-for-of": false, - "no-console": false, "forin": false, "prefer-const": false, "ban-types": false,