Merge pull request #8083 from bitjson/fix-prod-build

Fix `ionic build --prod`

app-template/apply.js

@@ -82,7 +82,7 @@ var getCommitHash = function() {
 
   var hash = shell.exec('git rev-parse HEAD', {
     silent: true
-  }).output.trim().substr(0, 7);
+  }).stdout.trim().substr(0, 7);
   return hash;
 }
 

package.json

@@ -33,7 +33,7 @@
     "ionic:build": "ionic-app-scripts build",
     "ionic:serve": "ionic-app-scripts serve",
     "watch": "ng test --browsers=Chrome",
-    "test": "test:lint && npm run test:ci && npm run e2e:capture-latest && npm run test:visual",
+    "test": "npm run test:lint && npm run test:ci && npm run e2e:capture-latest && npm run test:visual",
     "test:coverage": "ng test --code-coverage",
     "test:ci": "ng test --watch=false --code-coverage --no-progress",
     "test:lint": "tslint --project . --format codeFrame && tslint '{test,electron,src}/**/*.ts' --format codeFrame && prettier --list-different '{*,**/*}.{js,ts,md,json,scss}'",
@@ -73,7 +73,7 @@
     "@angular/platform-browser": "^5.1.3",
     "@angular/platform-browser-dynamic": "^5.1.3",
     "@angular/tsc-wrapped": "^4.4.6",
-    "@biesbjerg/ngx-translate-po-http-loader": "^2.0.1",
+    "@biesbjerg/ngx-translate-po-http-loader": "^3.0.1",
     "@ionic-native/android-fingerprint-auth": "^4.5.2",
     "@ionic-native/clipboard": "^4.5.2",
     "@ionic-native/core": "^4.5.2",
@@ -86,12 +86,10 @@
     "@ionic-native/toast": "^4.5.2",
     "@ionic-native/touch-id": "^4.5.2",
     "@ionic/storage": "^2.1.3",
-    "@ngx-translate/core": "^8.0.0",
+    "@ngx-translate/core": "^9.1.1",
     "@nsalaun/ng-logger": "^5.0.0",
     "@types/papaparse": "^4.1.33",
-    "ajv": "^5.5.2",
     "angular2-moment": "^1.7.1",
-    "autoprefixer": "^7.2.4",
     "bitauth": "git+https://github.com/bitpay/bitauth.git#copay",
     "bitcore-wallet-client": "^6.5.0",
     "buffer-compare": "^1.1.1",
@@ -137,22 +135,19 @@
   "devDependencies": {
     "@angular/cli": "^1.6.8",
     "@biesbjerg/ngx-translate-extract": "^2.3.4",
-    "@ionic/app-scripts": "^3.1.7",
-    "@types/chrome": "^0.0.57",
+    "@ionic/app-scripts": "^3.1.8",
     "@types/cordova-plugin-qrscanner": "^1.0.31",
     "@types/jasmine": "^2.8.6",
     "@types/jasminewd2": "^2.0.3",
-    "@types/lodash": "^4.14.92",
-    "angular2-template-loader": "^0.6.2",
+    "@types/lodash": "^4.14.104",
     "codecov": "^3.0.0",
     "connect": "^3.6.5",
-    "fs-extra": "^4.0.3",
+    "fs-extra": "^5.0.0",
     "html-loader": "^0.5.4",
     "ionic": "3.19.1",
     "ionic-mocks": "^1.2.1",
     "jasmine-core": "^2.99.1",
     "jasmine-reporters": "^2.3.0",
-    "jasmine-spec-reporter": "^4.2.1",
     "karma": "^2.0.0",
     "karma-chrome-launcher": "^2.2.0",
     "karma-cli": "^1.0.1",
@@ -160,23 +155,16 @@
     "karma-jasmine": "^1.1.1",
     "karma-jasmine-html-reporter": "^0.2.2",
     "karma-junit-reporter": "^1.2.0",
-    "karma-mocha-reporter": "^2.2.5",
-    "karma-phantomjs-launcher": "^1.0.4",
-    "karma-remap-istanbul": "^0.6.0",
-    "karma-sourcemap-loader": "^0.3.7",
-    "karma-webpack": "^2.0.9",
     "mkdirp": "^0.5.1",
-    "null-loader": "^0.1.1",
     "path": "^0.12.7",
     "plist": "^2.1.0",
     "prettier": "^1.10.2",
     "protractor": "^5.3.0",
-    "reg-cli": "^0.11.0",
+    "reg-cli": "^0.11.2",
     "serve-static": "^1.13.2",
-    "shelljs": "^0.3.0",
+    "shelljs": "^0.8.1",
     "trash-cli": "^1.4.0",
-    "ts-loader": "^3.2.0",
-    "ts-node": "^4.1.0",
+    "ts-node": "^5.0.0",
     "tslint": "^5.8.0",
     "tslint-config-prettier": "^1.7.0",
     "typescript": "^2.6.2"
@@ -223,4 +211,4 @@
   "prettier": {
     "singleQuote": true
   }
-}
+}

src/providers/release/release.ts

@@ -1,5 +1,6 @@
 import { HttpClient } from '@angular/common/http';
 import { Injectable } from '@angular/core';
+import { map } from 'rxjs/operators';
 import { AppProvider } from '../../providers/app/app';
 
 @Injectable()
@@ -18,7 +19,7 @@ export class ReleaseProvider {
   }
 
   public getLatestAppVersion() {
-    return this.http.get(this.LATEST_RELEASE_URL).map(x => x['tag_name']);
+    return this.http.get(this.LATEST_RELEASE_URL).pipe(map(x => x['tag_name']));
   }
 
   private verifyTagFormat(tag: string) {

tslint.json

@@ -5,6 +5,7 @@
     "no-submodule-imports": [
       true,
       "zone.js",
+      "rxjs",
       "@angular",
       "ts-md5/dist/md5",
       "ionic-angular/gestures/gesture"