diff --git a/js/models/core/PublicKeyRing.js b/js/models/core/PublicKeyRing.js index 38fc912e0..f6f3909a0 100644 --- a/js/models/core/PublicKeyRing.js +++ b/js/models/core/PublicKeyRing.js @@ -241,24 +241,26 @@ PublicKeyRing.prototype.getRedeemScriptMap = function () { return ret; }; -PublicKeyRing.prototype._checkInPRK = function(inPKR, ignoreId) { +PublicKeyRing.prototype._checkInPKR = function(inPKR, ignoreId) { if (!ignoreId && this.walletId !== inPKR.walletId) { - throw new Error('inPRK walletId mismatch'); + throw new Error('inPKR walletId mismatch'); } - if (this.network.name !== inPKR.network.name) - throw new Error('inPRK network mismatch'); + if (this.network.name !== inPKR.network.name) { + throw new Error('inPKR network mismatch. Should be '+this.network.name + + ' and found '+inPKR.network.name); + } if ( this.requiredCopayers && inPKR.requiredCopayers && (this.requiredCopayers !== inPKR.requiredCopayers)) - throw new Error('inPRK requiredCopayers mismatch '+this.requiredCopayers+'!='+inPKR.requiredCopayers); + throw new Error('inPKR requiredCopayers mismatch '+this.requiredCopayers+'!='+inPKR.requiredCopayers); if ( this.totalCopayers && inPKR.totalCopayers && (this.totalCopayers !== inPKR.totalCopayers)) - throw new Error('inPRK totalCopayers mismatch'+this.totalCopayers+'!='+inPKR.requiredCopayers); + throw new Error('inPKR totalCopayers mismatch'+this.totalCopayers+'!='+inPKR.requiredCopayers); }; @@ -296,7 +298,7 @@ PublicKeyRing.prototype._mergePubkeys = function(inPKR) { PublicKeyRing.prototype.merge = function(inPKR, ignoreId) { var hasChanged = false; - this._checkInPRK(inPKR, ignoreId); + this._checkInPKR(inPKR, ignoreId); if (this.indexes.merge(inPKR.indexes)) hasChanged = true; diff --git a/js/models/core/Wallet.js b/js/models/core/Wallet.js index 202cdff91..78e79e8ee 100644 --- a/js/models/core/Wallet.js +++ b/js/models/core/Wallet.js @@ -32,6 +32,7 @@ function Wallet(opts) { this.id = opts.id || Wallet.getRandomId(); this.name = opts.name; this.netKey = opts.netKey || SecureRandom.getRandomBuffer(8).toString('base64'); + this.networkName = opts.networkName; // Renew token every 24hs if (opts.tokenTime && new Date().getTime() - opts.tokenTime < 86400000) { @@ -318,7 +319,7 @@ Wallet.prototype.toObj = function() { opts: optsObj, publicKeyRing: this.publicKeyRing.toObj(), txProposals: this.txProposals.toObj(), - privateKey: this.privateKey.toObj() + privateKey: this.privateKey?this.privateKey.toObj():undefined }; return walletObj; @@ -459,7 +460,6 @@ Wallet.prototype.sign = function(ntxid, cb) { var txp = self.txProposals.txps[ntxid]; if (!txp || txp.rejectedBy[myId] || txp.signedBy[myId]) { if (cb) cb(false); - throw new Error('Invalid transaction to sign: '+ntxid); } var pkr = self.publicKeyRing; diff --git a/js/models/core/WalletFactory.js b/js/models/core/WalletFactory.js index 58054502b..c94537b33 100644 --- a/js/models/core/WalletFactory.js +++ b/js/models/core/WalletFactory.js @@ -18,6 +18,7 @@ var Wallet = require('./Wallet'); function WalletFactory(config, version) { var self = this; config = config || {}; + console.log('asd'); this.storage = new Storage(config.storage); this.network = new Network(config.network); diff --git a/test/test.TxProposals.js b/test/test.TxProposals.js index 35360d5c7..78bd50196 100644 --- a/test/test.TxProposals.js +++ b/test/test.TxProposals.js @@ -395,6 +395,7 @@ var _dumpChunks = function (scriptSig, label) { tx = w.txps[k].builder.build(); tx.isComplete().should.equal(false); tx.countInputMissingSignatures(0).should.equal(1); + }); diff --git a/test/test.Wallet.js b/test/test.Wallet.js index 925d7df5c..1cb665281 100644 --- a/test/test.Wallet.js +++ b/test/test.Wallet.js @@ -8,6 +8,8 @@ var Wallet = require('../js/models/core/Wallet'); var Storage = require('./mocks/FakeStorage'); var Network = require('./mocks/FakeNetwork'); var Blockchain = require('./mocks/FakeBlockchain'); +var bitcore = bitcore || require('bitcore'); +var TransactionBuilder = bitcore.TransactionBuilder; var addCopayers = function(w) { for (var i = 0; i < 4; i++) { @@ -22,10 +24,6 @@ describe('Wallet model', function() { totalCopayers: 5, spendUnconfirmed: 1, reconnectDelay: 100, - blockchain: { - host: 'test.insight.is', - port: 80 - }, networkName: 'testnet', }; @@ -241,14 +239,14 @@ describe('Wallet model', function() { var w = createW2(); var testTime = 1000; var callCount = 0; - var cT=w.reconnectDelay; - var t=0; + var cT = w.reconnectDelay; + var t = 0; do { callCount++; t += cT; cT *= 2; - } while (t