From c9407a717d59aa17a6db4cf3425e14955a63162d Mon Sep 17 00:00:00 2001
From: Jason Dreyzehner <jason@dreyzehner.com>
Date: Wed, 14 Feb 2018 14:38:22 -0500
Subject: [PATCH] test: better naming for e2e screenshots

---
 e2e/app.e2e-spec.ts                                 |   2 +-
 e2e/screenshots.ts                                  |   2 +-
 .../{1024x720_landing.png => landing_1024x720.png}  | Bin
 ...{1920x1080_landing.png => landing_1920x1080.png} | Bin
 .../{Nexus5X_landing.png => landing_Nexus5X.png}    | Bin
 .../bitpay/{iPad_landing.png => landing_iPad.png}   | Bin
 .../{iPadPro_landing.png => landing_iPadPro.png}    | Bin
 .../{iPhone8_landing.png => landing_iPhone8.png}    | Bin
 .../{iPhoneX_landing.png => landing_iPhoneX.png}    | Bin
 .../{1024x720_landing.png => landing_1024x720.png}  | Bin
 ...{1920x1080_landing.png => landing_1920x1080.png} | Bin
 .../{Nexus5X_landing.png => landing_Nexus5X.png}    | Bin
 .../copay/{iPad_landing.png => landing_iPad.png}    | Bin
 .../{iPadPro_landing.png => landing_iPadPro.png}    | Bin
 .../{iPhone8_landing.png => landing_iPhone8.png}    | Bin
 .../{iPhoneX_landing.png => landing_iPhoneX.png}    | Bin
 16 files changed, 2 insertions(+), 2 deletions(-)
 rename test/approved/bitpay/{1024x720_landing.png => landing_1024x720.png} (100%)
 rename test/approved/bitpay/{1920x1080_landing.png => landing_1920x1080.png} (100%)
 rename test/approved/bitpay/{Nexus5X_landing.png => landing_Nexus5X.png} (100%)
 rename test/approved/bitpay/{iPad_landing.png => landing_iPad.png} (100%)
 rename test/approved/bitpay/{iPadPro_landing.png => landing_iPadPro.png} (100%)
 rename test/approved/bitpay/{iPhone8_landing.png => landing_iPhone8.png} (100%)
 rename test/approved/bitpay/{iPhoneX_landing.png => landing_iPhoneX.png} (100%)
 rename test/approved/copay/{1024x720_landing.png => landing_1024x720.png} (100%)
 rename test/approved/copay/{1920x1080_landing.png => landing_1920x1080.png} (100%)
 rename test/approved/copay/{Nexus5X_landing.png => landing_Nexus5X.png} (100%)
 rename test/approved/copay/{iPad_landing.png => landing_iPad.png} (100%)
 rename test/approved/copay/{iPadPro_landing.png => landing_iPadPro.png} (100%)
 rename test/approved/copay/{iPhone8_landing.png => landing_iPhone8.png} (100%)
 rename test/approved/copay/{iPhoneX_landing.png => landing_iPhoneX.png} (100%)

diff --git a/e2e/app.e2e-spec.ts b/e2e/app.e2e-spec.ts
index 8a4045a7d..f6001c35d 100644
--- a/e2e/app.e2e-spec.ts
+++ b/e2e/app.e2e-spec.ts
@@ -7,7 +7,7 @@ describe('Copay', () => {
   });
 
   it('Should display the logo on the landing view', async () => {
-    takeScreenshot('landing.png');
+    takeScreenshot('landing');
     const present = await element(by.css('#logo')).isPresent();
     expect(present).toEqual(true);
   });
diff --git a/e2e/screenshots.ts b/e2e/screenshots.ts
index 728115462..7d6ee96ca 100644
--- a/e2e/screenshots.ts
+++ b/e2e/screenshots.ts
@@ -15,7 +15,7 @@ export async function takeScreenshot(name: string) {
   const config = await browser.getProcessedConfig();
   const deviceName = config['capabilities']['name'];
   const pngData = await browser.takeScreenshot();
-  const path = join(dir, `${name}_${deviceName}`);
+  const path = join(dir, `${name}_${deviceName}.png`);
   writeFile(path, pngData, { encoding: 'base64' }, err => {
     err ? console.error(err) : console.log(`File written: ${path}`);
   });
diff --git a/test/approved/bitpay/1024x720_landing.png b/test/approved/bitpay/landing_1024x720.png
similarity index 100%
rename from test/approved/bitpay/1024x720_landing.png
rename to test/approved/bitpay/landing_1024x720.png
diff --git a/test/approved/bitpay/1920x1080_landing.png b/test/approved/bitpay/landing_1920x1080.png
similarity index 100%
rename from test/approved/bitpay/1920x1080_landing.png
rename to test/approved/bitpay/landing_1920x1080.png
diff --git a/test/approved/bitpay/Nexus5X_landing.png b/test/approved/bitpay/landing_Nexus5X.png
similarity index 100%
rename from test/approved/bitpay/Nexus5X_landing.png
rename to test/approved/bitpay/landing_Nexus5X.png
diff --git a/test/approved/bitpay/iPad_landing.png b/test/approved/bitpay/landing_iPad.png
similarity index 100%
rename from test/approved/bitpay/iPad_landing.png
rename to test/approved/bitpay/landing_iPad.png
diff --git a/test/approved/bitpay/iPadPro_landing.png b/test/approved/bitpay/landing_iPadPro.png
similarity index 100%
rename from test/approved/bitpay/iPadPro_landing.png
rename to test/approved/bitpay/landing_iPadPro.png
diff --git a/test/approved/bitpay/iPhone8_landing.png b/test/approved/bitpay/landing_iPhone8.png
similarity index 100%
rename from test/approved/bitpay/iPhone8_landing.png
rename to test/approved/bitpay/landing_iPhone8.png
diff --git a/test/approved/bitpay/iPhoneX_landing.png b/test/approved/bitpay/landing_iPhoneX.png
similarity index 100%
rename from test/approved/bitpay/iPhoneX_landing.png
rename to test/approved/bitpay/landing_iPhoneX.png
diff --git a/test/approved/copay/1024x720_landing.png b/test/approved/copay/landing_1024x720.png
similarity index 100%
rename from test/approved/copay/1024x720_landing.png
rename to test/approved/copay/landing_1024x720.png
diff --git a/test/approved/copay/1920x1080_landing.png b/test/approved/copay/landing_1920x1080.png
similarity index 100%
rename from test/approved/copay/1920x1080_landing.png
rename to test/approved/copay/landing_1920x1080.png
diff --git a/test/approved/copay/Nexus5X_landing.png b/test/approved/copay/landing_Nexus5X.png
similarity index 100%
rename from test/approved/copay/Nexus5X_landing.png
rename to test/approved/copay/landing_Nexus5X.png
diff --git a/test/approved/copay/iPad_landing.png b/test/approved/copay/landing_iPad.png
similarity index 100%
rename from test/approved/copay/iPad_landing.png
rename to test/approved/copay/landing_iPad.png
diff --git a/test/approved/copay/iPadPro_landing.png b/test/approved/copay/landing_iPadPro.png
similarity index 100%
rename from test/approved/copay/iPadPro_landing.png
rename to test/approved/copay/landing_iPadPro.png
diff --git a/test/approved/copay/iPhone8_landing.png b/test/approved/copay/landing_iPhone8.png
similarity index 100%
rename from test/approved/copay/iPhone8_landing.png
rename to test/approved/copay/landing_iPhone8.png
diff --git a/test/approved/copay/iPhoneX_landing.png b/test/approved/copay/landing_iPhoneX.png
similarity index 100%
rename from test/approved/copay/iPhoneX_landing.png
rename to test/approved/copay/landing_iPhoneX.png