Commit Graph

4083 Commits

Author SHA1 Message Date
ThomasV 11fc93dc4a Merge pull request #892 from Tafelpoot/whitespace_v2
removed trailing whitespace and fixed indentation in history widget
2014-10-21 23:56:01 +02:00
Tafelpoot d9c5250a6f removed trailing whitespace and fixed indentation in history widget 2014-10-21 19:05:51 +02:00
ThomasV 49c0a3a08f Merge pull request #878 from imrehg/fee
Fix "Invalid Fee" issue when start with fiat in send (exchange rate plugin)
2014-10-10 10:13:47 +02:00
Gergely Imreh 3c3d064cad Fix "Invalid Fee" issue when start with fiat in send (exchange rate plugin)
Problem:

Using the exchange rate plugin in the send dialog one can start with
entering a fiat amount, e.g. 5 USD, and the BTC amount is updated,
but no fee is calculated.

In this case can get "Invalid fee" error until the BTC amount is
touched manually and fee is calculated. This can cause confusion
when "set transaction fees manually" is disabled.

Reproducing:

* enable exchange rate plugin
* start Electrum
* in send dialog fill out any receive address
* add a value (e.g. 5) into the fiat dialog and see the BTC value filled out
* fee is not filled out, or if disabled the manual transaction fees then directly
  get "Invalid Fee" error

Expectation:

* Fees are calculated just as it would be by filling out the BTC field

Fix:

Fixed by triggering a fee setting the same way as it is done when
the BTC field is edited, by calling `textEdited.emit("")` of the relevant
`BTCAmountEdit` element. One problematic  thing is that this also triggers
a change on the fiat we just edited, and thus cursor positions need to be saved
and restored. This is not ideal, there should be a way to avoid such cascades
and trigger fee calculation directly instead of by proxy.

Editing the fiat field with these changes is more or less okay, there can be
some strange steps when the decimal point is edited, but IMHO not worse
than the BTC field when the decimal point is edited there.
2014-09-30 11:28:42 +08:00
ThomasV 60e5450a0e rm print statement 2014-09-28 23:20:52 +02:00
ThomasV 584bb00faa Merge branch 'master' of git://github.com/spesmilo/electrum 2014-09-28 23:20:24 +02:00
ThomasV 0c0da6a36d use certs from request module in interface.py 2014-09-28 23:19:52 +02:00
ThomasV 05cbc9da6e Merge pull request #877 from dabura667/update_jpwlst
Update Japanese wordlist
2014-09-28 16:28:57 +02:00
waheebyaqub fb7136227b Update plot.py 2014-09-28 18:20:33 +04:00
dabura667 68efcb2ddf Update Japanese wordlist
1. First 3 characters are all unique now.
2. smallest word is not 3 characters long.
2014-09-28 22:11:08 +09:00
waheebyaqub 7cff7e31d5 Update plot.py 2014-09-27 17:05:17 +04:00
waheebyaqub 8e3e2fc1f6 Create plot.py 2014-09-27 17:02:00 +04:00
waheebyaqub 2045043212 Update main_window.py 2014-09-27 16:59:23 +04:00
waheebyaqub 374182e4bf Update setup.py
plugin name added
2014-09-27 16:56:26 +04:00
ThomasV 6c6293c777 Merge pull request #859 from PabloCastellano/master
setup.py: Install qrscanner (it's a library now)
2014-09-21 19:24:15 +02:00
ThomasV 10aba39d4e Merge pull request #858 from btchip/labelfix
Fix behavior when calling get_master_public_key from an external context
2014-09-21 19:23:34 +02:00
ThomasV 38fb26f1e8 Merge pull request #857 from btchip/deny_export_private_key
Do not crash when asked to export private keys
2014-09-21 19:23:06 +02:00
ThomasV 23933b20e1 Merge pull request #856 from btchip/fixerrorsigning
Fix bad initializer
2014-09-21 19:22:38 +02:00
wozz 12e9e40fce Merge pull request #864 from wozz/default-lang
Add default language for mnemonic
2014-09-21 10:49:55 -04:00
Michael Wozniak 27a663091b Add default language for mnemonic
Add en as default language for mnemonic
2014-09-21 10:46:03 -04:00
Pablo Castellano ce89c0a7e7 setup.py: Install qrscanner (it's a library now) 2014-09-21 00:58:31 +02:00
BTChip 7f2a360c6a Fix behavior when calling get_master_public_key from an external context 2014-09-21 00:49:36 +02:00
BTChip f296e5e5ef Do not crash when asked to export private keys 2014-09-20 14:46:26 +02:00
BTChip 94db6cc94b Fix bad initializer 2014-09-20 14:27:13 +02:00
ThomasV c02faeba2d Merge pull request #851 from molecular/test
fix typo in btcchip second factor prompt dialog
2014-09-19 21:00:48 +02:00
molecular e90d567435 fix typo in btcchip second factor prompt dialog 2014-09-19 20:58:16 +02:00
ThomasV fde5dd577a fix #849 2014-09-19 20:23:24 +02:00
ThomasV 7dd7918a30 Merge pull request #848 from btchip/firmwareupdate
Firmwareupdate
2014-09-19 16:24:00 +02:00
ThomasV 44b0fab4c0 Merge pull request #847 from btchip/tx-2fa-message
Improve 2FA message and dongle reconnection
2014-09-19 16:23:02 +02:00
BTChip 2c096f9669 Add firmware check 2014-09-19 16:02:09 +02:00
BTChip 796d52ac09 Delegate firmware update and better error message when connection to the dongle fails 2014-09-19 15:51:10 +02:00
ThomasV 11e7a6644e do not store wallet_type right at the first screen 2014-09-19 14:30:16 +02:00
ThomasV cfa965fdae set env to python2 2014-09-19 14:05:00 +02:00
ThomasV fd1f083958 simplify names 2014-09-19 13:48:49 +02:00
BTChip 86c0bffa3e Improve 2FA message and dongle reconnection 2014-09-19 13:39:12 +02:00
ThomasV 6cd00eb36b request history rates asynchronously 2014-09-19 13:36:30 +02:00
ThomasV 692f49e7af init not_enough_funds variable 2014-09-19 11:29:39 +02:00
ThomasV 7ef86d8bbb better error message 2014-09-19 11:20:26 +02:00
ThomasV e7d24c31bd don't set negative amounts in amount field 2014-09-19 11:14:16 +02:00
ThomasV 17006e5285 qr scanner: show error if not installed 2014-09-19 11:08:43 +02:00
ThomasV 44464e7e21 remove http protocols from gui selector 2014-09-19 10:46:18 +02:00
ThomasV 52450289ff we must check host name if cert is signed by CA 2014-09-19 10:18:33 +02:00
ThomasV 889ac782c1 simplify interface.get_socket, and fix a bug with new certificates 2014-09-19 09:25:44 +02:00
ThomasV 99b60980cd Merge branch 'master' of git://github.com/spesmilo/electrum 2014-09-19 05:18:54 +02:00
ThomasV 27c966c5f6 add socks 2014-09-19 05:18:42 +02:00
ThomasV 042ed24b9d Merge pull request #841 from btchip/issue839
Fix query fees
2014-09-19 05:02:50 +02:00
ThomasV c724e2dce5 fix: wordlists are in data 2014-09-18 23:43:25 +02:00
ThomasV 2fd94a185c remove socks from list of modules 2014-09-18 23:41:03 +02:00
ThomasV fbb0801d15 better workaround for tlslite issue 2014-09-18 23:38:30 +02:00
BTChip c6dcbcb005 Fix query fees 2014-09-18 22:11:24 +02:00