lnd/chainntnfs
Olaoluwa Osuntokun 36c299c1d8
chainntnfs/neutrinonotify: fix early historical confirmation dispatch
In this commit, we fix an existing bug within the logic of the neutrino
notifier. Rather than properly dispatching only once a transaction had
reached the expected number of confirmations, the historical dispatch
logic would trigger as soon as the transaction reached a single
confirmation.

This was due to the fact that we were using the scanHeight variable
which would be set to zero to calculate the number of confirmations.
The value would end up being the current height, which is generally
always greater than the number of expected confirmations. To remedy
this, we’ll now properly use the block height the transaction was
originally confirmed in to know when to dispatch.

This also applies a fix that was discovered in
93981a85c0.
2017-12-07 19:08:48 -08:00
..
btcdnotify chainntnfs: Use the new ConcurrentQueue in btcd notifier. 2017-11-16 15:15:22 -08:00
neutrinonotify chainntnfs/neutrinonotify: fix early historical confirmation dispatch 2017-12-07 19:08:48 -08:00
README.md multi: fix formatting issues in packge README's 2017-03-27 16:25:25 -07:00
interface.go lnwallet: use new ChainNotifier API, typo fixes 2017-05-11 15:21:05 -07:00
interface_test.go chainntnfs: expand historical dispatch test case to detect early dispatches 2017-12-07 19:05:40 -08:00
log.go lnd: remove seelog logger 2017-06-25 14:19:56 +01:00
queue.go chainntnfs: Implement unbounded concurrent-safe FIFO queue. 2017-11-16 15:15:22 -08:00
queue_test.go chainntnfs: Implement unbounded concurrent-safe FIFO queue. 2017-11-16 15:15:22 -08:00

README.md

chainntnfs

Build Status MIT licensed GoDoc

The chainntnfs package implements a set of interfaces which allow callers to receive notifications in response to specific on-chain events. The set of notifications available include:

  • Notifications for each new block connected to the current best chain.
  • Notifications once a txid has reached a specified number of confirmations.
  • Notifications once a target outpoint (txid:index) has been spent.

These notifications are used within lnd in order to properly handle the workflows for: channel funding, cooperative channel closures, forced channel closures, channel contract breaches, sweeping time-locked outputs, and finally pruning the channel graph.

This package is intentionally general enough to be applicable outside the specific use cases within lnd outlined above. The current sole concrete implementation of the ChainNotifier interface depends on btcd.

Installation and Updating

$ go get -u github.com/lightningnetwork/lnd/chainntnfs