From c0f66c0b29ed7f9f956e2a64414a42fea6c458bc Mon Sep 17 00:00:00 2001
From: hellcatz <kg6ypi@remotehams.com>
Date: Wed, 3 May 2017 23:41:00 -0700
Subject: [PATCH] Update paymentProcessor.js

Updates to comments in code...
---
 libs/paymentProcessor.js | 24 ++++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)

diff --git a/libs/paymentProcessor.js b/libs/paymentProcessor.js
index d60427d..7c2e087 100644
--- a/libs/paymentProcessor.js
+++ b/libs/paymentProcessor.js
@@ -736,6 +736,7 @@ function SetupForPool(logger, poolOptions, setupFinished){
                                 }
                                 // account feature not implemented at this time
                                 addressAccount = "";
+                                // begin payments for generated coins
                                 callback(null, workers, rounds, addressAccount);
                             });
                         });
@@ -945,32 +946,39 @@ function SetupForPool(logger, poolOptions, setupFinished){
                         return;
                     }
                     
-                    // perform the sendmany operation
+                    // POINT OF NO RETURN! GOOD LUCK!
+                    // WE ARE SENDING PAYMENT CMD TO DAEMON
+                    
+                    // perform the sendmany operation .. addressAccount
                     daemon.cmd('sendmany', ["", addressAmounts], function (result) {
                         // check for failed payments, there are many reasons
                         if (result.error && result.error.code === -6) {
-                            // not enough minerals...
-                            var higherPercent = withholdPercent + 0.01;
-                            logger.warning(logSystem, logComponent, 'Not enough funds to cover the tx fees for sending out payments, decreasing rewards by '
-                                + (higherPercent * 100) + '% and retrying');
-
+                            // we thought we had enough funds to send payments, but apparently not...
+                            // try decreasing payments by a small percent to cover unexpected tx fees?
+                            var higherPercent = withholdPercent + 0.001;
+                            logger.warning(logSystem, logComponent, 'Not enough funds to cover the tx fees for sending out payments, decreasing rewards by ' + (higherPercent * 100) + '% and retrying');
                             trySend(higherPercent);
+                            //callback(true); not a complete failure...
+                            return;
                         }
                         else if (result.error && result.error.code === -5) {
                             // invalid address specified in addressAmounts array
                             logger.error(logSystem, logComponent, 'Error sending payments ' + result.error.message);
+                            // payment failed, prevent updates to redis
                             callback(true);
                             return;
                         }
                         else if (result.error && result.error.message != null) {
-                            // unknown error from daemon
+                            // error from daemon
                             logger.error(logSystem, logComponent, 'Error sending payments ' + result.error.message);
+                            // payment failed, prevent updates to redis
                             callback(true);
                             return;
                         }
                         else if (result.error) {
-                            // some other unknown error
+                            // unknown error
                             logger.error(logSystem, logComponent, 'Error sending payments ' + JSON.stringify(result.error));
+                            // payment failed, prevent updates to redis
                             callback(true);
                             return;
                         }