From 08a0d6bc0afe9e3d4cfcacc4dfaed98e8ae63678 Mon Sep 17 00:00:00 2001 From: Pedro Alvarez Date: Fri, 4 Sep 2020 12:24:29 +0100 Subject: [PATCH] Fix compilation warning with unecessary comparison. --- lib/include/srslte/mac/pdu.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/include/srslte/mac/pdu.h b/lib/include/srslte/mac/pdu.h index b90b32bed..0f9659d5a 100644 --- a/lib/include/srslte/mac/pdu.h +++ b/lib/include/srslte/mac/pdu.h @@ -211,7 +211,7 @@ public: // Get subheader at specified index SubH* get(uint32_t idx) { - if (nof_subheaders > 0 && idx >= 0 && idx < (uint32_t)nof_subheaders) { + if (nof_subheaders > 0 && idx < (uint32_t)nof_subheaders) { return &subheaders[idx]; } else { return nullptr; @@ -289,10 +289,10 @@ class subh public: virtual ~subh() {} - virtual bool read_subheader(uint8_t** ptr) = 0; - virtual void read_payload(uint8_t** ptr) = 0; - virtual void write_subheader(uint8_t** ptr, bool is_last) = 0; - virtual void write_payload(uint8_t** ptr) = 0; + virtual bool read_subheader(uint8_t** ptr) = 0; + virtual void read_payload(uint8_t** ptr) = 0; + virtual void write_subheader(uint8_t** ptr, bool is_last) = 0; + virtual void write_payload(uint8_t** ptr) = 0; virtual std::string to_string() = 0; pdu* parent = nullptr; @@ -357,7 +357,7 @@ public: void set_padding(uint32_t padding_len); void set_type(subh_type type_); - void init(); + void init(); std::string to_string(); bool set_next_mch_sched_info(uint8_t lcid, uint16_t mtch_stop); @@ -433,7 +433,7 @@ public: void set_temp_crnti(uint16_t temp_rnti); void set_sched_grant(uint8_t grant[RAR_GRANT_LEN]); - void init(); + void init(); std::string to_string(); private: @@ -453,7 +453,7 @@ public: bool has_backoff(); uint8_t get_backoff(); - bool write_packet(uint8_t* ptr); + bool write_packet(uint8_t* ptr); std::string to_string(); private: