PentHertz
/
srsLTE
mirror of https://github.com/PentHertz/srsLTE.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Added memset(0) to PDCP status report bitmap before starting to fill it in.

This commit is contained in:
Pedro Alvarez 2021-02-11 19:06:48 +00:00
parent 9bc08af880
commit 90113419c2
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lib/src/upper/pdcp_entity_lte.cc
View File

@ -435,14 +435,22 @@ bool pdcp_entity_lte::send_status_report()
// Add bitmap of missing PDUs, if necessary
if (not undelivered_sdus_queue.empty()) {
uint32_t byte_offset = 0;
// First check size of bitmap
uint32_t last_sn = undelivered_sdus_queue.rbegin()->first;
uint32_t bitmap_sz = std::ceil((float)(last_sn - (fms - 1)) / 8);
memset(&pdu->msg[pdu->N_bytes], 0, bitmap_sz);
logger.debug(
"Setting status report bitmap. Last SN acked=%d, Last SN acked in sequence=%d, Bitmap size in bytes=%d",
last_sn,
fms - 1,
bitmap_sz);
for (auto it = undelivered_sdus_queue.begin(); it != undelivered_sdus_queue.end(); it++) {
uint32_t offset = it->first - fms;
uint32_t bit_offset = offset % 8;
byte_offset = offset / 8;
uint32_t offset = it->first - fms;
uint32_t bit_offset = offset % 8;
uint32_t byte_offset = offset / 8;
pdu->msg[pdu->N_bytes + byte_offset] |= 1 << (7 - bit_offset);
}
pdu->N_bytes += (byte_offset + 1);
pdu->N_bytes += bitmap_sz;
}
// Write PDU to RLC