From 93fbf741d761bee176cb926dcc74898c2e3c268d Mon Sep 17 00:00:00 2001 From: Pedro Alvarez Date: Mon, 24 Feb 2020 19:40:33 +0000 Subject: [PATCH] Remove unecessary context lookup in increment_ue_sqn --- srsepc/hdr/hss/hss.h | 2 +- srsepc/src/hss/hss.cc | 11 +++-------- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/srsepc/hdr/hss/hss.h b/srsepc/hdr/hss/hss.h index 1ab8053d2..b12a22534 100644 --- a/srsepc/hdr/hss/hss.h +++ b/srsepc/hdr/hss/hss.h @@ -101,7 +101,7 @@ private: std::vector split_string(const std::string& str, char delimiter); void get_uint_vec_from_hex_str(const std::string& key_str, uint8_t* key, uint len); - void increment_ue_sqn(uint64_t imsi); + void increment_ue_sqn(hss_ue_ctx_t* ue_ctx); void increment_seq_after_resync(uint64_t imsi); void increment_sqn(uint8_t* sqn, uint8_t* next_sqn); void set_sqn(uint64_t imsi, uint8_t* sqn); diff --git a/srsepc/src/hss/hss.cc b/srsepc/src/hss/hss.cc index 0cf15afc9..9268c5d35 100644 --- a/srsepc/src/hss/hss.cc +++ b/srsepc/src/hss/hss.cc @@ -272,7 +272,7 @@ bool hss::gen_auth_info_answer(uint64_t imsi, uint8_t* k_asme, uint8_t* autn, ui gen_auth_info_answer_milenage(ue_ctx, k_asme, autn, rand, xres); break; } - increment_ue_sqn(imsi); + increment_ue_sqn(ue_ctx); return true; } @@ -546,15 +546,10 @@ bool hss::resync_sqn_milenage(uint64_t imsi, uint8_t* auts) return true; } -void hss::increment_ue_sqn(uint64_t imsi) +void hss::increment_ue_sqn(hss_ue_ctx_t* ue_ctx) { - hss_ue_ctx_t* ue_ctx = get_ue_ctx(imsi); - if (ue_ctx == nullptr) { - return; - } - increment_sqn(ue_ctx->sqn, ue_ctx->sqn); - m_hss_log->debug("Incremented SQN -- IMSI: %015" PRIu64 "\n", imsi); + m_hss_log->debug("Incremented SQN -- IMSI: %015" PRIu64 "\n", ue_ctx->imsi); m_hss_log->debug_hex(ue_ctx->sqn, 6, "SQN: "); }