PentHertz
/
srsLTE
mirror of https://github.com/PentHertz/srsLTE.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Addressed review comments: 

1 - enb,cfg: fix typo
2 - enb,config: added back deleted config option
3 - ue,rrc_nr: fix wrong log level in log message
4 - enb,config: remove unused parameter
This commit is contained in:
Pedro Alvarez 2022-05-11 16:09:07 +01:00
parent 97b32f2fb6
commit a72279dcbd
4 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
srsenb/rb.conf.example
View File

@ -10,9 +10,12 @@
// poll_byte = -1; // poll_byte = -1;
// max_retx_thresh = 4; // max_retx_thresh = 4;
// }; // };
// dl_am = { // dl_am = {
// t_reassembly = 50; // t_reordering = 35;
// t_status_prohibit = 50; // t_status_prohibit = 0;
// };
// enb_specific = {
// dl_max_retx_thresh = 32;
// }; // };
// }; // };
// } // }
@ -29,6 +32,9 @@
// t_reordering = 35; // t_reordering = 35;
// t_status_prohibit = 0; // t_status_prohibit = 0;
// }; // };
// enb_specific = {
// dl_max_retx_thresh = 32;
// };
// }; // };
// } // }

2
srsenb/src/enb_cfg_parser.cc
View File

@ -644,7 +644,7 @@ int field_5g_srb::parse(libconfig::Setting& root)
cfg.present = true; cfg.present = true;
} }
// RLC-UM Should not exist section // RLC-UM must not exist in this section
if (root.exists("ul_um") || root.exists("dl_um")) { if (root.exists("ul_um") || root.exists("dl_um")) {
ERROR("Error SRBs must be AM."); ERROR("Error SRBs must be AM.");
return SRSRAN_ERROR; return SRSRAN_ERROR;

3
srsgnb/hdr/stack/rrc/rrc_nr_config.h
View File

@ -46,8 +46,7 @@ struct rrc_cell_cfg_nr_t {
typedef std::vector<rrc_cell_cfg_nr_t> rrc_cell_list_nr_t; typedef std::vector<rrc_cell_cfg_nr_t> rrc_cell_list_nr_t;
struct srb_5g_cfg_t { struct srb_5g_cfg_t {
int enb_dl_max_retx_thres = -1; bool present = false;
bool present = false;
asn1::rrc_nr::rlc_cfg_c rlc_cfg; asn1::rrc_nr::rlc_cfg_c rlc_cfg;
}; };

2
srsue/src/stack/rrc_nr/rrc_nr.cc
View File

@ -1062,7 +1062,7 @@ bool rrc_nr::apply_rlc_add_mod(const rlc_bearer_cfg_s& rlc_bearer_cfg)
return false; return false;
} }
} else if (not is_drb) { } else if (not is_drb) {
logger.error("Using default RLC configs for SRB%d", srb_id); logger.debug("Using default RLC configs for SRB%d", srb_id);
rlc_cfg = rlc_config_t::default_rlc_am_nr_config(); rlc_cfg = rlc_config_t::default_rlc_am_nr_config();
} else { } else {
logger.error("In RLC bearer cfg does not contain rlc cfg"); logger.error("In RLC bearer cfg does not contain rlc cfg");