Commit Graph

2402 Commits

Author SHA1 Message Date
Xavier Arteaga 0346564241 Fix NR-PUCCH encoding 2021-03-02 15:40:40 +01:00
Xavier Arteaga 784f4be72e SRSUE: NR CSI report fixes 2021-03-02 15:40:40 +01:00
Xavier Arteaga 4679e9f871 Initial NR CSI reports 2021-03-02 15:40:40 +01:00
Francisco 202c4d7566 remove uses of method .clear() of stack timers 2021-03-02 11:25:38 +01:00
Francisco be7e78da53 limit allocation of PDCP SDU+Timer buffer to DRB+RLC AM cases 2021-03-02 11:25:38 +01:00
Pedro Alvarez 8dfa87c377 Disable undelivered SDU queue for SRBs. 2021-03-02 11:25:38 +01:00
Francisco a3cb21d378 move undelivered_pdcp_sdus class methods to .cc file. Fixed the forwarding of pending PDCP SNs during S1 handover 2021-03-02 11:25:38 +01:00
Francisco 17fa79f24c couple the pdcp discard timers and sdu buffer management into same subclass. Add asserts to ensure there is no ambiguity in the PDCP SN assignment and buffering. Extend the discard timer and pdcp sdu buffering to SN lengths above 12 2021-03-02 11:25:38 +01:00
Pedro Alvarez 4723dd0aa9 Converted undelivered sdus queue in the PDCP to use a vector.
This was done to improve the performance of the notify_delivery().
2021-03-02 11:25:38 +01:00
Xavier Arteaga 6c9ff3ac92 Fix packed sequence genration for non multiples of 8 2021-03-01 15:30:33 +01:00
Xavier Arteaga 1e55d68b55 Removed set RNTI from API 2021-03-01 15:30:33 +01:00
Xavier Arteaga 93752fb2c4 Fix LDPC compilation for GCC 10 2021-03-01 13:26:05 +01:00
Xavier Arteaga 576a923a4c Added i8 zero vector 2021-03-01 13:26:05 +01:00
Francisco 4b09507c19 remove srslte.h includes from upper layers 2021-02-26 16:44:57 +01:00
Francisco b329e25bbb move ue phy interfaces to separate interfaces header file 2021-02-26 16:44:57 +01:00
Francisco b8bd869d0f move ue rlc interfaces to separate interfaces header file 2021-02-26 16:44:57 +01:00
Francisco a988351f46 move ue pdcp interfaces to separate interfaces header file 2021-02-26 16:44:57 +01:00
Francisco ea04104e8e move ue gw interfaces to separate interfaces header file 2021-02-26 16:44:57 +01:00
David Rupprecht 8f49b92760 Using PDCP entity lte instead of nr for nr bearer 2021-02-26 15:13:41 +01:00
Pedro Alvarez c0b5edf6db
Make sure discard timers are initialized, even when timeout is infinite. (#2400) 2021-02-26 10:36:04 +00:00
Francisco 6e64933335 handle the scenario when the network thread fails to allocate a byte buffer 2021-02-25 15:56:40 +01:00
Francisco f610a7b83d Change background worker pool to become a global variable
Allocate rrc::ue objects in batches in the background worker pool
2021-02-25 15:56:40 +01:00
Xavier Arteaga 126fc09b7d SRSUE: Added initial SR procedure for NR 2021-02-25 09:04:04 +01:00
Andre Puschmann 822abc763e rlc_am_lte: when max retx is reached, remove SN from tx window
this fixes an issue when the RLC bearer isn't reset from RRC.
In this case, the RLC would retransmit the same PDU over and over
again despite the max retx counter being reached.
2021-02-24 21:57:56 +01:00
Francisco 0b6b62324f convert rlc am retx_queue to circular buffer 2021-02-24 21:19:15 +01:00
Andre Puschmann 9c4146442a mac,phy: refactor NR MAC/PHY UL data passing interface
inspired by accepted (but not yet merged) PR to include the
(unique_)byte_buffer_t for MAC/PHY interfacing, this patch adds
a few more useful bits to that. Buffer management for UL data is now
done in MAC and only a pointer to the data is passed in the UL action.

* Move Tx softbuffer to MAC (until UL HARQ class is ready)
* Remove temparal data member in cc_worker
* Remove memcpy after packing MAC PDU
2021-02-24 20:28:43 +01:00
David Rupprecht fc9d5befda Remove header test case 2021-02-24 20:23:54 +01:00
Andre Puschmann 06e7f169c6 rlc_um_nr: fix unpacking of 12bit UM PDU 2021-02-24 20:23:54 +01:00
Francisco 138685399e remove allocations from rlc_am_tx::handle_control_pdu 2021-02-24 12:06:34 +01:00
David Rupprecht cc0c091a39 pcap checksum to null for decoding if checksum check is enabled 2021-02-23 17:02:23 +01:00
Xavier Arteaga 6ba9f8fd41 SRSUE: Remove UL hard-coded phase and more PUSCH logging info 2021-02-23 17:02:23 +01:00
David Rupprecht 1fcd006a7c fixed segfaulting 2021-02-23 17:02:23 +01:00
Xavier Arteaga b768002a93 SRSUE Added RAR unpacking and other fixes 2021-02-23 17:02:23 +01:00
David Rupprecht 82a8dcc77a Change interface to unique_byte_buffer
logging message for msg3 preparing
2021-02-23 17:02:23 +01:00
Francisco 9a6512f4e8 fix RLC AM undelivered PDCN SNs reset bug 2021-02-22 22:56:19 +01:00
Francisco 1ede82bb30 use circular array for buffered PDCP SNs in RLC AM to limit memory allocations 2021-02-22 22:56:19 +01:00
Francisco 2a65bf9636 fix undelivered PDCP SNs buffers in RLC AM to handle SN=-1 case 2021-02-22 22:56:19 +01:00
Francisco bad2302e31 avoid the use of two arrays for managing buffered pdcp sns in RLC AM 2021-02-22 22:56:19 +01:00
Francisco 299634b319 use of vector to store undelivered PDCP SNs in RLC AM 2021-02-22 22:56:19 +01:00
David Rupprecht 0f1586dd2d Deleted all HAVE_5GNR in CC and h files
CMakeList and travis yaml
2021-02-22 21:16:04 +01:00
Pedro Alvarez d8f3878ce1
RLC failure to deliver notifications and discard timer limits to 1500ms (#2368)
* Added interfaces for the RLC to notify the PDCP of failure to transmit
SDU

* Limit discard timer to 1500ms, to avoid issues of lingering SDUs in the undeliverd_sdus_queue.

* Fix bug in early exit of notify_delivery and notify_failure

* fix compilation issue in rlc-pdcp notification

Co-authored-by: Francisco <francisco.paisana@softwareradiosystems.com>
2021-02-22 10:36:14 +00:00
Francisco 2f75abcc7a fix failing rlc am test 2021-02-21 21:24:24 +01:00
Francisco abe4f4c7eb use tx_window to store the map of rlc sn to pdcp sns 2021-02-21 21:24:24 +01:00
Francisco f86eb84876 conversion of RLC AM tx window from std::map to array 2021-02-21 21:24:24 +01:00
Francisco 1660fc81a0 fix comment regarding PDCP SN value for status report 2021-02-21 12:50:32 +01:00
Francisco 047dd2a56d use function helper for discard timer lookup and stopping in the PDCP 2021-02-21 12:50:32 +01:00
Francisco c6fa011eec fix pdcp discard timer list creation 2021-02-21 12:50:32 +01:00
Francisco 82bb0a7d81 implementation of pdcp discard timers using a vector for efficiency 2021-02-21 12:50:32 +01:00
Andre Puschmann 40d7934267 rlc: call PDCP notify without holding Tx lock
move notify_info_vec as stack variable and unlock mutex
before calling PDCP notify
2021-02-21 11:03:44 +01:00
Francisco 93b1450e03 fix enb crash during close down of enb and epc 2021-02-20 16:00:31 +01:00
Francisco Paisana cd8ee37f74
Use a reverse lookup to avoid iteration over a std::map (#2363)
* reuse vector capacity for pdcp sn notification
* use an extra lookup data structure to find PDCP SNs that an RLC SN contains
* fix rlc sn->pdcp sn lookup datastructure in rlc
* fix rlc failing test
2021-02-20 15:08:00 +01:00
Pedro Alvarez d947a0bccf Used the used SN to insert into the discard timer instead of the TX_COUNT 2021-02-19 20:15:39 +00:00
Pedro Alvarez 3f2fe4e5f6 Disable PDCP discard timer when using RLC UM. 2021-02-19 20:15:39 +00:00
Xavier Arteaga b8b27709b9 Radio: implement resampling buffer protection 2021-02-19 17:23:59 +01:00
Pedro Alvarez 24d5b9071c Fix issue with status report test config 2021-02-19 13:30:48 +00:00
Pedro Alvarez 6ecd6e273c Make sure that the status report is sent in RLF and PDCP reestablishment triggered by Handover 2021-02-19 13:30:48 +00:00
Pedro Alvarez 6a6bffcf5c Changed log of discarding SN due limit to info level 2021-02-19 12:07:15 +00:00
Pedro Alvarez c66c96aac7 Simplify if condition in checking the maximum allocated SNs in PDCP 2021-02-19 12:07:15 +00:00
Pedro Alvarez 33808a5cb8 Making sure that SNs don't wrap-around in PDCP with RLC AM. 2021-02-19 12:07:15 +00:00
Ismael Gomez 543e84d873 Fix compilation error in PPC 2021-02-19 13:00:39 +01:00
faluco 613d397d0a - Dump the PDCP metrics into the JSON file.
- Fix the PDCP metrics getting reset periodically which invalidated the byte counters.
2021-02-19 09:54:41 +01:00
faluco a940e169a3 Add the enb_cc_idx value to S1 events. 2021-02-19 09:54:41 +01:00
faluco b750647cd8 - Remove the cause field in the rrc disconnect event.
- Add the sib9 enb home name field to the sectors events, but leave the value as a TODO.
2021-02-19 09:54:41 +01:00
faluco 7b9dab3a73 Rename cc_idx variable to enb_cc_idx for specific upper layer events. 2021-02-19 09:54:41 +01:00
faluco a4605883f0 Implement second revision of the events and metrics document. 2021-02-19 09:54:41 +01:00
Pedro Alvarez 0e828aeb4b Remove unecessary mutex. PDCP metrics are accessed from the stack thread. 2021-02-19 02:55:17 +00:00
Pedro Alvarez c39905744c Fix metrics of TX PDUs and TX_PDU bytes in PDCP 2021-02-19 02:55:17 +00:00
Pedro Alvarez 451c305790 Add mutex to isolate metrics_hub thread from the stack thread when
getting the metrics from the PDCP
2021-02-19 02:55:17 +00:00
Pedro Alvarez 0c240a80aa Fix up PDCP metrics to calculate the buffered bytes when get_metrics is
called.
2021-02-19 02:55:17 +00:00
Xavier Arteaga 70a55ebf1e Fix ZMQ sleep time 2021-02-18 18:59:30 +01:00
Pedro Alvarez 46cd29e0ac Temporarly disable sending status report and retrasnsmissions on reestablishment in PDCP 2021-02-18 14:51:29 +00:00
Pedro Alvarez df501d1500 Clear underlivered SDUs info map for SRBs on reestablishment 2021-02-18 14:51:29 +00:00
Pedro Alvarez d705fa2106 Tentative fix for errors due to status report already present in RLC info queue 2021-02-18 14:51:29 +00:00
Pedro Alvarez ba5367bc56 Change order which reestablish is called in eNB
Make sure that RLC info queue is reset when reestablish happens
2021-02-18 14:51:29 +00:00
David Rupprecht 876858b44c Added mac nr prach common config convert function with test case 2021-02-18 14:34:15 +01:00
David Rupprecht a3be380e3b workaround to mitigate the linking error 2021-02-18 14:34:15 +01:00
Andre Puschmann e0495d1da8 zmq: fix parsing of log_trx_timeout
add temp var for this param. the bug cause log_trx_timeout
to have the value of the previously parsed fail_on_disconnect
2021-02-17 21:06:28 +01:00
Pedro Alvarez cfd94441a5 Added metrics to srsenb PDCP 2021-02-17 18:40:12 +00:00
Pedro Alvarez 8873b7c42f Added computation for the metrics 2021-02-17 18:40:12 +00:00
Pedro Alvarez d34aba8065 Added interfaces to get metrics from PDCP entities. 2021-02-17 18:40:12 +00:00
Pedro Alvarez eb2f5b978f Starting to add metrics to lib/upper/pdcp.cc 2021-02-17 18:40:12 +00:00
Pedro Alvarez 3eab97340b Fix issue in getting PDCP discard timer from configs 2021-02-17 17:53:03 +00:00
Xavier Arteaga 784a33583b SRSUE: Initial NR MAC-PHY interfaces
SRSUE Fix compilation

SRSUE: temporary fixes LTE/NR PHY/Stack interface problem

fix

fix
2021-02-17 16:34:00 +01:00
Francisco 6a178693a8 handle rrc configs with pdcp with sn=15 or 18 bits 2021-02-17 11:03:52 +01:00
Francisco faf2adde90 set last_submitted_pdcp_rx_sn to -1 of the next ul rx sn 2021-02-17 11:03:52 +01:00
Pedro Alvarez e2d2951b00 Added some extra logging for the PDCP get_buffered_pdus and notification reception. 2021-02-17 11:03:52 +01:00
Pedro Alvarez 963dff34af Added retransmissions to the UE's PDCP on re-establishment. 2021-02-17 11:03:52 +01:00
Xavier Arteaga 8ac6d7382f Fix PRACH sequence generation 2021-02-17 10:34:34 +01:00
Xavier Arteaga 2fd618a295 Avoid FFTW re-planning if no DFT change is required 2021-02-17 10:34:34 +01:00
Xavier Arteaga 596c8f52a9 PRACH set config avoids modulo operation 2021-02-17 10:34:34 +01:00
Xavier Arteaga 1e073b8b67 PRACH: avoid general cexp for sequence generation using LUT 2021-02-17 10:34:34 +01:00
Andre Puschmann c1a1c92e1b zmq: optionally log rx/tx timout from ZMQ ringbuffers to stderr
this patch adds two new config flags to the ZMQ driver that allows to:
* configure the default ZMQ trx timeout in ms
* turn on error logging if the timeout occurs

Use with, e.g.:
device_args = log_trx_timeout=true,trx_timeout_ms=3333
2021-02-16 20:38:19 +01:00
Xavier Arteaga 984c4a4748 Changed license header 2021-02-16 15:57:58 +01:00
Pedro Alvarez e0542a4651 Fix issue in sending PDCP status PDU from the eNB due to non-existing LCID at the RLC. 2021-02-16 13:21:50 +00:00
Pedro Alvarez b0fe302f8e Added interfaces so the upper layers can trigger the PDCP status report. Added ability to the UE to send Status Report aftre reestablishment. 2021-02-16 13:21:50 +00:00
Pedro Alvarez 89a23cec7e Added statusReportRequired to the PDCP entity config. 2021-02-16 13:21:50 +00:00
David Rupprecht 24123313bf Added MAC NR RA procedure with a minimal test case 2021-02-16 09:42:09 +01:00
Xavier Arteaga 3d3c80262c Modified Error messages 2021-02-16 09:12:47 +01:00
Xavier Arteaga d9805f7ba7 Added AVX512 LDPC 2021-02-16 09:12:47 +01:00
Xavier Arteaga 2e39e103f8 Minor NR related corrections 2021-02-15 12:54:17 +01:00