Commit Graph

2026 Commits

Author SHA1 Message Date
Ismael Gomez 1fd9d4300c Move pdu buffer mutex in mac::ue to each carrier buffer map 2021-07-14 18:59:04 +02:00
Xavier Arteaga b25681f9de gnb,prach: add PRACH to gNB
rebase of Xavier's feature_gnb_prach branch
2021-07-14 14:30:58 +02:00
Xavier Arteaga 47747e3148 SRSENB: RRC measurement report for NR are appended 2021-07-14 12:56:39 +02:00
David Rupprecht 59ca11db68 Added missing target_link_libs 2021-07-14 09:41:37 +02:00
Andre Puschmann 6c82d63aa6 remove legacy PNF/VNF code
the code hasn't been maintained for a while an likely needs to be
adapted for a real-world scenarios.

in order to avoid having to maintain two MAC/PHY interfaces we
remove the code from now.
2021-07-12 19:24:02 +02:00
Xavier Arteaga 96cb25b868 Add arguments to NR PHY test 2021-07-09 22:32:40 +02:00
Xavier Arteaga ecc0b92142 Integrated PUSCH decoder in gNb 2021-07-08 16:47:07 +02:00
Andre Puschmann 068267992d rnti_pool: add rrc_endc class and extra 1024B to UE memblock size
this should fix #3045

however, this hard-coded size seems pretty unflexible anyway so we might
have to increase/add to it, or find an alternative way to calculate the size?
2021-07-08 15:21:28 +02:00
Andre Puschmann e460739152 rrc_ue: only create and call endc_handler if NR RRC is available 2021-07-06 21:57:44 +02:00
Andre Puschmann 3f81d3e969 enb,rrc_endc: add handler for measurements and UE capabilities 2021-07-06 21:57:44 +02:00
Andre Puschmann 8d443d79e5 enb,rrc: add skeleton code for new RRC internal interface for SgNB addition 2021-07-06 21:57:44 +02:00
Andre Puschmann 8dd7075d12 enb,stack: add NR components for NSA mode
adds the main NR components for RLC, PDCP, MAC and RRC
for NSA operation.
2021-07-06 21:57:44 +02:00
Andre Puschmann ec3465bb98 s1ap: fix compilation of test on 32bit 2021-07-06 12:48:41 +02:00
Andre Puschmann 19996a4059 sched_nr: fix compilation 2021-07-06 10:11:50 +02:00
Xavier Arteaga 5307fec2f0 Added GNB MAC UL info initial interface and fix PHY implementation 2021-07-05 17:51:27 +02:00
Xavier Arteaga e764a26136 Integrated PUCCH decoding in gNb 2021-07-05 17:51:27 +02:00
Xavier Arteaga 3fe9176750 Added PUCCH dedocder to slot worker 2021-07-05 17:51:27 +02:00
Xavier Arteaga 658b47d917 Added NR PUSCH and PUCCH decoder in gnb_ul 2021-07-05 17:51:27 +02:00
Xavier Arteaga f6fc215541 Refactored enb_dl_nr to gnb_dl and initial gnb_ul 2021-07-05 17:51:27 +02:00
David Rupprecht f90e359208 Moved cp to test common 2021-07-02 17:23:06 +02:00
Ismael Gomez 4e39982a19
Fix TSAN warnings in UE (#3021)
* Protect PHY SR signal management in a class

* Protect intra_freq_meas vector

* Protect cell and srate shared variables in thread-safe classes

* srsue,srsenb: include TSAN options header

* Protect ue_rnti_t and rnti scheduling windows behind thread-safe classes

* Protect access to state variable in sync_state

* Protect access to metrics configuration

* Protect access to is_pending_sr

* Protect access to UE prach worker

* Protect UE mux

* Avoid unlocking mutex twice

* Fix data races in RF/ZMQ

* Fix data races in intra_measure and PHY

* Fix minor data races in MAC

* Make TSAN default behaviour to not halt on error

* Fix blocking in intra cell measurement

* Address comments

Co-authored-by: Andre Puschmann <andre@softwareradiosystems.com>
2021-07-01 17:39:54 +02:00
Ismael Gomez c0fd64c4e6 Fix data races in srsENB MAC 2021-07-01 17:39:06 +02:00
Pedro Alvarez 1b676aa406 Moved lib GTPU to its own folder 2021-06-30 18:19:20 +01:00
Pedro Alvarez 865298f8d5 Moved lib PDCP to its own folder 2021-06-30 18:19:20 +01:00
Pedro Alvarez 171d5727be Moved lib RLC into it's own folder 2021-06-30 18:19:20 +01:00
Francisco Paisana 30802777cf fix,enb: fix enb.conf param description 2021-06-29 20:39:32 +02:00
Francisco Paisana 4d014e7ceb s1ap,feature: make the ts1 reloc timers configurable via the enb.conf 2021-06-29 20:39:32 +02:00
Francisco 4c316aa9ea sched,nr: integrate mac-phy interface types into the scheduler 2021-06-29 14:19:35 +02:00
Francisco 5b3c5ded63 sched,nr: implement NR PDCCH allocation algorithm 2021-06-29 14:19:35 +02:00
Xavier Arteaga 6f5614a0cc Suggested modifications on gNb MAC/PHY interface 2021-06-28 00:27:36 +02:00
Xavier Arteaga 8378c85ec4 Refactored gNb PHY 2021-06-28 00:27:36 +02:00
Xavier Arteaga c4e13f70a2 SRSENB: fix NR worker pointer check 2021-06-28 00:27:36 +02:00
Xavier Arteaga aef3e5a40a More NR PHY test and GNB PHY development 2021-06-28 00:27:36 +02:00
Xavier Arteaga d49734b1bc SRSENB: Refactor to accomodate 5G NR 2021-06-28 00:27:36 +02:00
Francisco de05e1e549 sched,nr: fix invalid memory write 2021-06-24 16:22:42 +01:00
Francisco 75153c7c83 sched,nr: implementation of sched sim test class 2021-06-24 16:22:42 +01:00
Francisco f1b3cfc764 sched,nr: implementation of sched NR harq retxs. Refactor of rb grid classes. 2021-06-24 16:22:42 +01:00
Francisco d950433cbd sched,nr: fix time-domain parallelization sched nr test. creation of util class to handle acquisition of boolean resources 2021-06-24 16:22:42 +01:00
Francisco 35a236b1b9 sched,nr: fix sched_nr_test. Resolve data race issues. Created new config structs used across the scheduler. 2021-06-24 16:22:42 +01:00
Francisco 407da794e1 sched,nr: implementation of slot grid class 2021-06-24 16:22:42 +01:00
Francisco 4fa27f3841 sched,nr: implementation of main classes for NR scheduler, and basic test for concurrency 2021-06-24 16:22:42 +01:00
Andre Puschmann 483a216bd5 ue,stack: refactor handling of radio bearears in UE stack
this is a rather large commit that is hard to split because
it touches quite a few components.

It's a preparation patch for adding NR split bearers in the next
step.

We realized that managing RLC and PDCP bearers for both NR and LTE
in the same entity doesn't work. This is because we use the LCID
as a key for all accesses. With NR dual connectivity however we
can have the same LCID active at the same time for both LTE and NR
carriers.

The patch solves that by creating a dedicated NR instance for RLC/PDCP
in the stack. But then the question arises for UL traffic on, e.g. LCID 4
what PDCP instance the GW should use for pushing SDUs. It doesnt' know
that. And in fact it doesn't need to. It just needs to know EPS
bearer IDs. So the next change was to remove the knowledge of what
LCIDs are from the GW. Make is agnostic and only work on EPS bearer IDs.

The handling and mapping between EPS bearer IDs and LCIDs for LTE
or NR (mainly PDCP for pushing data) is done in the Stack because
it has access to both.

The NAS also has a EPS bearer map but only knows about default and
dedicated bearers. It doesn't know on which logical channels they
are transmitted.
2021-06-24 16:52:58 +02:00
Francisco e70b8c2472 sched,bugfix: fix SI scheduler logging 2021-06-24 14:24:00 +01:00
Andre Puschmann 4b069d9b86 enb,mac: fix concurrent access to cell structs
this patch moves the rwlock that protects the UE database outside
to also protect the cell struct.

It also adds a missing write guard when setting the cell
2021-06-23 12:38:19 +02:00
Andre Puschmann ff72c78745 enb,mac: fix indention 2021-06-23 12:38:19 +02:00
David Rupprecht ec19919246 Fix NGAP valgrind test 2021-06-22 20:53:43 +02:00
Pedro Alvarez aae266e848 Added configuration option for S1AP SCTP bind port 2021-06-22 11:11:54 +01:00
Francisco 78acf81cf0 bugfix,sched: avoid instability in TPCs around PHR~0 2021-06-21 17:35:24 +01:00
Xavier Arteaga b1e4720721 SRSUE/SRSENB: added tx_enable flag in worker_end 2021-06-21 18:07:53 +02:00
Xavier Arteaga 027201d457 SRSUE/SRSENB: Refactor NR workers to generalise lower PHY 2021-06-21 18:07:53 +02:00
yagoda ce30b7e1ce fixing eMBMS after new ue_db architecture and scheduler changes 2021-06-21 11:20:03 +02:00
Pedro Alvarez 181b903117 Small log fix for RNTI in integrity failure notifications 2021-06-18 23:17:39 +02:00
Ismael Gomez 02ec4dd3d0 Remove unused variable 2021-06-18 23:17:14 +02:00
Ismael Gomez dd9889e07c Add carrier index to uplink PCAP captures 2021-06-18 23:17:14 +02:00
Bedran Karakoc c280ac5ad6 Introducing extended NGAP functionality
Remove unused logger for now in ngap::ue to pass tests
2021-06-17 13:05:29 +02:00
Francisco 5a82a63bb5 bugfix,srsenb: fix intraenb handover softbuffer allocation during handover 2021-06-16 10:21:13 +01:00
Francisco d5234b5f65 sched,bugfix: avoid using UL SNR average in tpc control loop 2021-06-15 19:12:24 +01:00
Francisco c111b23255 config,enb: change the max sib coderate to 0.3 2021-06-14 18:55:51 +01:00
Francisco 2a009eb340 sched,feature: Enable configuring maximum coderate for SIB allocations 2021-06-14 18:55:51 +01:00
Francisco 6ababf401b feature,sched: allow setting initial DL CQI in enb.conf 2021-06-14 15:55:23 +01:00
Francisco 4cf5a8b25a fix: avoid configuring the phy mbsfn from the rrc, when phy is not fully initialized 2021-06-14 15:55:10 +01:00
Francisco f55e1c5a73 fix,srsenb: start stack before the radio to avoid stack methods to be called when stack is not fully initialized 2021-06-14 15:55:10 +01:00
Francisco e8983b88f0 refactor: use enb_cc_idx instead of ue_cc_idx in mac::ue 2021-06-14 13:18:47 +01:00
Xavier Arteaga 63de691351 SRSENB: Added sleep command description 2021-06-14 09:21:29 +02:00
Xavier Arteaga 4bfe092a24 Added multi-command line in srsenb 2021-06-14 09:21:29 +02:00
Francisco 99960c72fa bugfix,srsenb: extend rrc mobility unit test for intraenb handover 2021-06-10 09:46:01 +01:00
Francisco 69b7a7eb19 bugfix,srsenb: the lcids beloging to SRB1 and SRB2 were not being reactivated correctly during intra-eNB handover 2021-06-10 09:46:01 +01:00
Francisco a0ba2d576d remove unused return variable 2021-06-09 11:12:06 +01:00
Francisco 048d487921 bugfix,gtpu: send end marker via the forwarding tunnel, when the source enb receives ue ctxt release command. Improve GTPU unit testing 2021-06-09 11:12:06 +01:00
Francisco 8cbbebdea2 bugfix,scheduler: make sure UL harq pending data is cleared up when the last retx falls in a measurement gap 2021-06-09 10:52:43 +01:00
Francisco 51c9fc514d refactor,sched: fix log lines related with meas gap collisions 2021-06-09 10:52:43 +01:00
Pedro Alvarez 163976f050 Fix releasing on on RRC and not on S1AP on integrity failure. 2021-06-08 18:52:22 +01:00
Pedro Alvarez a53b321ab8 Release UE upon reception of integrity error. 2021-06-08 18:52:22 +01:00
Pedro Alvarez 299d2ee35d Added interface to make the PDCP notify the RRC of integrity check
failures.
2021-06-08 18:52:22 +01:00
Francisco 5c7ea6f6df bugfix,srsenb,rrc: remove redundant calls to setup PDCP/RLC bearer state during reestablishment 2021-06-08 16:21:57 +01:00
Francisco fd3901e4a2 bugfix,srsenb,rrc: delete old context right away after sending Reestablishment msg.
Following ReestablishmentRequests should use the most recent rnti as old context.
2021-06-08 16:21:57 +01:00
Andre Puschmann f65faba756 sched_harq: fix uninitialized values in HARQ
detected with Valgrind memcheck
2021-06-05 11:04:33 +02:00
Francisco 35cea3d104 enb,optimization: consider mac::ue object in rnti pool memory block size 2021-06-04 21:29:13 +01:00
Francisco 7e77da6a15 mac,optimization: use rnti memory pool to create mac::ue objects 2021-06-04 21:29:13 +01:00
Francisco fd1d73666c bugfix,srsenb,mac: avoid sanity check for UL PDU length if CRC=KO 2021-06-04 20:03:38 +01:00
Francisco 76004a3054 enb,mac,refactor: mac::ue now uses byte_buffer_pool for UL PDUs 2021-06-04 20:03:38 +01:00
Francisco 9e2a7d4592 bugfix,tpc: only cap PUSCH TPC when PHR is negative. I also extended TPC unit test 2021-06-04 17:39:51 +01:00
Francisco bdc4362475 bugfix,tpc: place a cap on TPC due to PHR only when TPC is positive 2021-06-04 17:39:51 +01:00
Francisco 7badfb1c88 bugfix: avoid multiple TPC=0 for a single PHR<0 2021-06-04 17:39:51 +01:00
Francisco e2c37ad513 bugfix: missing early return in TPC derivation 2021-06-04 17:39:51 +01:00
Francisco 75eebd6b5d bugfix,gtpu: close forwarding tunnel during reestablishment due to handover failure 2021-06-04 14:59:12 +01:00
Francisco 597f993706 sched,improvement: filter out Msg3 UL SNR estimates from the TPC control loop 2021-06-04 13:45:10 +01:00
Andre Puschmann c0be8187c8 rlc interface: convert entire read_pdu() interface to return uint32_t
we had it returning int but had a bug in using the return value properly,
i.e. handling when -1 was returned in RLC TM.

Thinking about it more, it doesn't make sense to have a negative return
value here anyway. Either the RLC can return a PDU or not. If it can't the
returned lenght is zero.
2021-06-04 13:23:54 +02:00
Xavier Arteaga 090022568e DCI NCCE find considers L and NCCE 2021-06-04 11:13:23 +02:00
Andre Puschmann aaffdeb326 rrc,rlc: add method to signal protocol failure to RRC
general-purpose method for lower layers to signal protocol
failures to higher layers, i.e. RRC.

In the current case, implement a direct release of the UE (enb) or
a reestablishment (UE).
2021-06-03 21:11:47 +02:00
Andre Puschmann 107f6334dd compile: fix compilation on 32bit systems that require -latomic 2021-06-03 20:45:02 +02:00
Andre Puschmann 80a89ec4bf enb,mac: protect concurrent access to ue_db from different threads
race condition between PHY worker(s) and Stack thread when
accessing ue_db member. RWlock needs to be hold.

partly fixes #2932
2021-06-03 20:43:37 +02:00
faluco 3df72cb6ab Move out a free call in a RT thread when doing lots of rachs. 2021-06-03 20:41:04 +02:00
Francisco ceaef3523f sched,feature: Enable setting the target PHR below which the maximum UL grant size starts decreasing 2021-06-03 15:33:38 +01:00
Francisco 486823e5de sched,bugfix: The PHR handling scheme now considers the number of PRBs of the UL grant that carried the PHR. Before, it was assuming the most conservative scenario of Nprb=1 2021-06-03 15:33:38 +01:00
Francisco f7aef3ffc1 sched,bugfix: fix nof_retx update when UL HARQs are resumed 2021-06-02 20:21:32 +01:00
Ismael Gomez 5cef780789 Radio-link KO notification. Measgap fix 2021-06-02 12:37:36 +02:00
Francisco 92e272ce3e limit minimum UL grant size to accommodate both BSR and RLC headers 2021-06-02 12:37:36 +02:00
Francisco 3b61df4b64 test,sched: update TPC test to reflect changes in SNR estimatioN 2021-06-02 10:08:34 +01:00
Francisco 89406b07d6 make eNB UL SNR initial value an exponential average alpha configurable 2021-06-02 10:08:34 +01:00