Commit Graph

9371 Commits

Author SHA1 Message Date
Alejandro Leal Conejos ee0ec564ef Fixes coverity 373333 2021-10-26 21:09:44 +02:00
Alejandro Leal Conejos 4c518b8c82 Fixes coverity 373325 2021-10-26 21:09:44 +02:00
Joaquim 93649429dd
WIP: Fix Coverity issues in PHY lib (#3507)
Fix several Coverity issues

This commit adrresses the following code issues found by Coverity:

CID 339785 Division by zero, in fading_channel_test.c
CID 355272 Division by zero, in awgn_channel_test.c
CID 355277 NULL ptr dereference, in awgn_channel_test.c
CID 359663 NULL ptr dereference, in delay_channel_test.c
CID 369544 NULL ptr dereference, in chest_dl_nbiot.c
CID 373326 Resource Leak, in dft_fftw.c
CID 373329 Resource Leak, in dft_fftw.c
CID 372878 Division by zero, in sliv_test.c
CID 372871 Division by zero, in dmrs_pdcch.c
CID 370622 Negative loop bound, in csr_rs.c
CID 370624 Negative loop bound, in csr_rs.c
CID 370626 Negative loop bound, in csr_rs.c
CID's 369568, 369594 NULL ptr dereference, in ch_awgn.c
CID 369540 Logically dead code, in refsignal_dl.c
CID 369608 Logically dead code, in refsignal_ul.c
CIDs 366291, 366296, 366297 Out-of-bounds access, in zc_sequence.c
CID 372209 Division by zero, in cqi.c
CID 370992 Uninitialized pointer read, in pdcch_test.c
CID 373334 Integer overflow, in ue_sync.h
CID 370993, 370995 Undefined division, in pdcch_test.c
CID 370994 Undefined division, in ssb_decode_test.c
CIDs 353368 353364 353365 359673 353366 353367
Explicit null dereferenced, in psss_file_test.c
CID 371865 Unchecked return value, in rf_uhd_imp.cc
CID 363810 Undefined division, in ldpc_rm_chain_test.c
CID 372209, 372211, 372213, 372216 Undefined modulo, in cqi.c
CID 339834 Array compared against 0, in chest_dl.c
CID 369589 Out of bounds access, in dmrs_pucch.c
CID 371681 Out of bounds access, in ue_sync_nr_test.c
CIDs 370761, 370825 Copy-paste error, in ssb.c
CID 369599 out of bounds read, in dmrs_pdcch_test.c
CID 363795 out of bounds read, in ldpc_dec_c_avx2_flood.c
CID 363805 out of bounds read, in ldpc_dec_c_avx2long_flood.c
CID 363821 out of bounds read, in ldpc_dec_c_flood.c
2021-10-26 19:59:45 +02:00
Ismael Gomez bdbaf7357a ue,nr: Protect pending_cfgs in PHY worker_pool 2021-10-26 19:04:02 +02:00
faluco b058945142 Fix data race in sync::current_earfcn. 2021-10-26 19:04:02 +02:00
faluco 92b81b200f Fix data race in ul_harq_process::current_irv. 2021-10-26 19:04:02 +02:00
Francisco c928615952 nr,gnb,sched: avoid scheduling RAR for RNTIs whose ue object is not yet created in the scheduler 2021-10-26 16:58:55 +02:00
faluco dc31fb05a3 Fix ODR issue detected by ASAN in arch for the srsran_verbose global variable. 2021-10-26 16:56:11 +02:00
faluco fa8e8ddf1f Fix an ODR issue detected by ASAN in arch, where the global variable handler_registered was defined multiple times. 2021-10-26 16:56:11 +02:00
Nils Fürste 6c8324d95e srsenb.conf.example: Fix typos and make layout consistent 2021-10-26 16:33:42 +02:00
Pedro Alvarez b194bd8e63 Added comment and usage example to epc.conf.example to the request IMEI-SV option 2021-10-26 15:46:21 +02:00
Matan Perelman f4adf80263 Add option to request IMEISV 2021-10-26 15:46:21 +02:00
yagoda 5d6b48311e fixing a few regression bugs in embms 2021-10-26 15:35:18 +02:00
Pedro Alvarez bc903b13d5 Added nia0 to hardcoded configuration of nr-bearer-config 2021-10-26 14:59:40 +02:00
Pedro Alvarez a40a2dc191 Disable integrity/encription at PDCP-NR, as it will break when packets arrive out-of-order. 2021-10-26 14:59:40 +02:00
Carlo Galiotto dcc2c1c694 rrc,nr: defer rem_user after msg3 timer expires
This commits is to fix the issue of user removal from rrc_nr
after msg3 timer expires.
The issue was caused because the rrc_nr is accessing the ue object
after it gets removed from the users list in rrc_nr.
This commits defers the removal of the users, so there won't be any
access to invalid memory locations.

Fixes #3545

Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-10-26 14:57:56 +02:00
Andre Puschmann 497e183487 rf_zmq_imp: disable Tx baseband scaling
until the correct gain settings are documented and potential
mis-configuration are handled. It seems that the default
Tx/rx gains values are not working with this function.
2021-10-26 14:56:44 +02:00
Andre Puschmann e2d26b5a8c rlc_um_nr: log PDU without SN if full SDU is transmitted
PDUs that contain full SDUs don't have SNs, so the log should be
without it
2021-10-26 13:32:48 +02:00
Andre Puschmann 3eb1862ab9 gnb_interface: reduce MAX_GRANTS to 4
see #3530 for detailed discussion. This change saves some CPU cycles it seems
2021-10-25 21:52:03 +02:00
Andre Puschmann d48ce8a07a add changelog and bump version for 21.10 2021-10-25 21:39:33 +02:00
Francisco 67a39fbb81 nr,sched: push BSRs into the scheduler when nr_phy_test is run with PUSCH enabled 2021-10-25 20:55:00 +02:00
Fabian Eckermann 32a1646536
nr,gnb,rrc: Derive RRC parameters from config.
* Derive RRC parameters from config.
* nr,gnb,rrc: hard code prach config index to 8 to avoid expiring RA proc window.
2021-10-25 20:54:32 +02:00
Francisco 4d8a354b17 nr,gnb,rrc: implement reestablishment reject in case of reestablishment with cause reconfigfailure and no NR carrier 2021-10-25 20:50:18 +02:00
faluco 91677a9dcb Fix data race in sync::state, the stop() did not acquire the required lock. 2021-10-25 20:30:57 +02:00
faluco 5ff6b2eaa9 Fix data race in ZMQ where nsamples and running variables could be read concurrently. 2021-10-25 20:30:57 +02:00
Xavier Arteaga 2f5a1ad2e3
SRSENB: MAC controller recover MAC bearer state after PDSCH KO burst (#3225)
* SRSENB: MAC controller recover MAC bearer state after PDSCH KO burst

* mac,lte: simplify scheduler phy config enable configuration

Co-authored-by: Francisco Paisana <francisco.paisana@softwareradiosystems.com>
2021-10-25 10:56:12 +02:00
Xavier Arteaga 322f57a952
Initial real-time Tx gain setting (#2976)
* Make filename const in filesink

* Sine generation returns the next phase

* Avoid malloc/free in radio class

* Implement Tx gain in ZMQ

* Initial ratio RT gain test

* UHD: use timed Tx gain commands to align changes to subframes

* Minor improvement in test_radio_rt_gain

* Fix compilation

* Check RF gain thread id before joining

* Remove redundant zero initialization.

Co-authored-by: Fabian Eckermann <fabian@srs.io>
2021-10-25 10:54:17 +02:00
Xavier Arteaga ebab12403f
Asynchronous NR PHY configuration (#3527)
* Fix a race condition when accessing the NR PHY cfg by the RRC and phy workers.
Rework how the phy cfg is handled, now workers have their own copy that gets updated after a reconfig moving it out of the state class.

* Default initialize sf_len member in sf_worker for consistency.

* Asynchronous NR PHY configuration

* Fix compilation

* Corrected method override and fix unitialised value

* Added carrier equal comparison to avoid aligment byte padding comparison

Co-authored-by: faluco <borja.ferrer@softwareradiosystems.com>
2021-10-25 10:51:02 +02:00
faluco 28887a4384 Relax memory ordering for atomic load for the ul_harq::current_tx_nb member. 2021-10-23 21:26:00 +02:00
faluco 0ada9a01ec Whitelist TSAN issue in srsenb::mac::sr_detected. 2021-10-23 21:26:00 +02:00
faluco 3ecc8bb4c6 Fix data race in gw::deactivate_eps_bearer. 2021-10-23 21:26:00 +02:00
faluco a1b2f3915d Whitelist lock order inversion tsan issue in srsenb::rlc::rb_is_um. 2021-10-23 21:26:00 +02:00
faluco 5f93ff6ed0 Batch of data race fixes in the following classes: RLC AM, Intra measure, UL HARQ, PHY common. 2021-10-23 21:26:00 +02:00
Andre Puschmann dd5eda04e3 ue,rrc_nr: clear DRB to LCID lookup during RRC release 2021-10-23 21:09:26 +02:00
Francisco e4247517d0 nr,sched: update sched_nr_test to support the new DL sched no-copy api 2021-10-23 21:09:26 +02:00
Andre Puschmann be388aa53f rrc_nr: temporary fix of heap-use-after free
see https://github.com/softwareradiosystems/srsLTE/issues/3545
2021-10-23 21:09:26 +02:00
Francisco 87459bad17 nr,sched: avoid resetting Tx softbuffer every time a new DL HARQ proc is allocated 2021-10-23 21:09:26 +02:00
Andre Puschmann 8294724aad gnb_interface: reduce MAX_GRANTS to 4
this significantly reduces data copies when providing the PHY
with scheduler results.
2021-10-23 21:09:26 +02:00
Andre Puschmann cf4b6d0bea sched_nr_interface: make PHY results a reference to avoid copying 2021-10-23 21:09:26 +02:00
Andre Puschmann 2cee65bb88 enb,slot_worker: skip UL signal demod if scheduler returns empty results 2021-10-23 21:09:26 +02:00
Xavier Arteaga b54d4ad8e2 Avoid copying gNb common configuration in slot basis 2021-10-23 17:23:08 +02:00
Xavier Arteaga 95bf85b3d3 Reduced maximum number of CSI reports 2021-10-23 17:23:08 +02:00
Paul Sutton bbacd47e02 Update ISSUE_TEMPLATE.md 2021-10-23 13:16:16 +02:00
Paul Sutton 7ab4da9d11 Update mailing list 2021-10-23 13:16:09 +02:00
Andre Puschmann 905b9dcb37 update mailing list link 2021-10-23 13:15:56 +02:00
Francisco 0663594aa1 nr,gnb,sched: add extra checks to sched to ensure the max nof grants is not exceeded 2021-10-23 09:20:28 +01:00
Carlo Galiotto 0c35045543 rrc,nr: remove default value from input arg + ...
change input arg name

Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-10-22 19:43:19 +01:00
Carlo Galiotto ebaab9b1d0 rrc,nr: add private fnc to overload public method...
... and propagate input to calling function

Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-10-22 19:43:19 +01:00
Carlo Galiotto 4f6905363f rrc,nr: add MSG3 activity timer to rrc_nr
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-10-22 19:43:19 +01:00
Francisco ceec108831 nr,sched: fix fmt string in sched nr harq 2021-10-22 18:08:43 +01:00