Commit Graph

2606 Commits

Author SHA1 Message Date
Pedro Alvarez f99d6bc224 lib,rlc: changed get_bearer() to get_lcid(). 2021-11-12 22:41:37 +00:00
Pedro Alvarez 3b150e26cb rlc_am_nr: Changed header_t to HeaderType typename in RLC data structs.
Fix issue in clear_pdcp_sdu()
2021-11-12 22:41:37 +00:00
Pedro Alvarez 123ac16653 rlc_am_nr: fixed issue with pointers from rx entity to tx entity 2021-11-12 22:41:37 +00:00
Pedro Alvarez f99e841421 Changed using a rlc_am_lte and rlc_am_nr entity, to a single rlc_am entity. 2021-11-12 22:41:37 +00:00
Pedro Alvarez eefedcfccd rlc_am_nr: renamed rlc_am_base to just rlc_am 2021-11-12 22:41:37 +00:00
Pedro Alvarez aef87d5366 rlc_am_nr: Change rlc_am_base to use unique_ptr to hold rx/tx entities 2021-11-12 22:41:37 +00:00
Pedro Alvarez debb4a0c6b Refactored RLC AM segment pool for re-use in both LTE and NR
Moved RLC AMD PDU definitions from rlc_am_lte.h to rlc_common.h to make them re-usable in both RLC LTE and RLC NR
2021-11-12 22:41:37 +00:00
Pedro Alvarez 54be15e7a6 Moved write pdu to rlc_am_base::rlc_am_base_rx 2021-11-12 22:41:37 +00:00
Pedro Alvarez 476f9e1156 Changed logger initialization in RLC AM entities 2021-11-12 22:41:37 +00:00
Pedro Alvarez 022c51493b Refactored RLC AM NR/LTE Rx and Tx entities to use a rlc_am_base_rx/tx class.
This was done to make it easier to share entity specific code between LTE and NR.
This removes the previously used templates.
2021-11-12 22:41:37 +00:00
Pedro Alvarez b15f63f32f Added an RLC AM base class to avoid code duplication in the RLC AM NR entity.
This class is based on a template that receives as argument the
rlc_am_*_tx/rx entities, so that those are different for LTE and NR.

Moved code from rlc_am_lte/nr entities so that they use the new base class.
2021-11-12 22:41:37 +00:00
Pedro Alvarez e65bcd7147 Changed default max S1 Setup retries to infinity 2021-11-12 15:09:39 +00:00
Pedro Alvarez 930e3699d0 Added max_s1_retries parameter 2021-11-12 15:09:39 +00:00
Francisco 83c1fb65d7 nr,gnb,rrc: add rrc nr message handler and send functions to establish an SA RRC connection 2021-11-12 14:46:44 +00:00
Francisco 16753a006a nr,gnb,rrc: add test logger delimiter; handle rrc setup complete 2021-11-11 10:55:35 +00:00
Francisco 9734f2e393 adt: fix optional_vector ctor, and add emplace method 2021-11-05 16:13:09 +00:00
Andre Puschmann 0967cda042 gnb,stack: move gNB components into own folder
* move RRC, MAC, NGAP, SDAP into gnb folder
* move testing code below respective layers
2021-11-05 15:26:06 +01:00
Francisco 5f3afffd05 nr,gnb: implementation of sib and mib asn1 generation functions 2021-11-04 18:05:14 +00:00
Francisco 96fd3aae3c nr,gnb: small gnb interface refactors and fix of byte buffer operator= 2021-11-04 18:05:14 +00:00
Pedro Alvarez d528d8af4c Added initial skeleton for RLC AM NR entity 2021-11-04 16:12:07 +00:00
Pedro Alvarez 2bb249bf09 Moved RLC AM LTE and NR packing functions to their own file. 2021-11-04 16:12:07 +00:00
Pedro Alvarez f93d428e49 Moved RLC AM data structures to their own file 2021-11-04 16:12:07 +00:00
Francisco dab6e8bdcd nr,gnb: updates in parsing and phy files to allow the splitting of NR and LTE stacks 2021-11-04 15:24:57 +00:00
Francisco 8d719db43d nr,gnb,mac: implement zero-copy get_dl_sched/get_ul_sched NR scheduler interface 2021-11-03 21:21:45 +01:00
Carlo Galiotto ba50bbfb76 rlc,rrc,nr: remove rb_type from rlc_um_config
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-11-03 19:31:47 +01:00
Carlo Galiotto 9c2099f680 rrc,rlc,nr: fix RB label in RLC-NR for UE logs + ..
add rb_type in rlc_um_config

Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-11-03 19:31:47 +01:00
Carlo Galiotto d95c31d2de rlc,rrc,nr: fix rlc bearer string diplayed in logs
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-11-03 19:31:47 +01:00
Francisco f6e1ecdaf3 nr,gnb,mac: remove redundant checks and unused lcid enum constants 2021-11-03 13:31:16 +00:00
Francisco c615df9d1d nr,gnb,mac: prioritize CRNTI CE handling over remaining SDUs and CEs in gNB mac receiver 2021-11-03 13:31:16 +00:00
Francisco 4286ab81d9 nr,gnb,mac: fix const-correctness of some methods of class srsran::mac_sch_pdu_nr 2021-11-03 13:31:16 +00:00
faluco 74456bf3d2 Whitelist a reported deadlock involving read lock. 2021-10-29 12:45:47 +02:00
Francisco dfc2ea0a3e nr,gnb,pdcp: extend the use of local rb_name member to pdcp nr 2021-10-28 21:21:46 +01:00
Francisco c64be663d2 nr,gnb,pdcp: store the PDCP RB name in base class for easier use 2021-10-28 21:21:46 +01:00
Francisco 5b8d4c39af pdcp,lte: fix drb/srb id logging to account for dynamic mapping 2021-10-28 21:21:46 +01:00
Ismael Gomez 8a53a9d35c ssb_decode_test: Fix stack overflow pbch_msg buffer 2021-10-28 16:13:02 +02:00
Bedran Karakoc a14cc451d0 Addition NGAP cleanup 2021-10-27 19:37:49 +02:00
Nils Fürste b036da07de Extend ASN1 utils function from_number() 2021-10-27 17:53:28 +02:00
Fabian Eckermann 8753ea1be5 Fix coverty defects. 2021-10-27 17:39:51 +02:00
Carlo Galiotto 9c74dda039 rrc,nr: add msg5 and inactivity timers to RRC-NR
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-10-26 23:18:17 +02:00
faluco edf0926a2f Batch of LGTM fixes. 2021-10-26 21:49:17 +02:00
Francisco 7ad1ad800e lte,enb,rlc: atomically compute DL buffer state and update the scheduler in the eNB 2021-10-26 21:44:59 +02:00
Ismael Gomez d972fb368c
Some LGTM fixes (#3564)
* Fix LGTM issues

* ue: add logging to switch on function

* Fix new LGTM issues
2021-10-26 21:15:36 +02:00
faluco dc31fb05a3 Fix ODR issue detected by ASAN in arch for the srsran_verbose global variable. 2021-10-26 16:56:11 +02:00
faluco fa8e8ddf1f Fix an ODR issue detected by ASAN in arch, where the global variable handler_registered was defined multiple times. 2021-10-26 16:56:11 +02:00
Andre Puschmann 3eb1862ab9 gnb_interface: reduce MAX_GRANTS to 4
see #3530 for detailed discussion. This change saves some CPU cycles it seems
2021-10-25 21:52:03 +02:00
Xavier Arteaga 322f57a952
Initial real-time Tx gain setting (#2976)
* Make filename const in filesink

* Sine generation returns the next phase

* Avoid malloc/free in radio class

* Implement Tx gain in ZMQ

* Initial ratio RT gain test

* UHD: use timed Tx gain commands to align changes to subframes

* Minor improvement in test_radio_rt_gain

* Fix compilation

* Check RF gain thread id before joining

* Remove redundant zero initialization.

Co-authored-by: Fabian Eckermann <fabian@srs.io>
2021-10-25 10:54:17 +02:00
Xavier Arteaga ebab12403f
Asynchronous NR PHY configuration (#3527)
* Fix a race condition when accessing the NR PHY cfg by the RRC and phy workers.
Rework how the phy cfg is handled, now workers have their own copy that gets updated after a reconfig moving it out of the state class.

* Default initialize sf_len member in sf_worker for consistency.

* Asynchronous NR PHY configuration

* Fix compilation

* Corrected method override and fix unitialised value

* Added carrier equal comparison to avoid aligment byte padding comparison

Co-authored-by: faluco <borja.ferrer@softwareradiosystems.com>
2021-10-25 10:51:02 +02:00
faluco 0ada9a01ec Whitelist TSAN issue in srsenb::mac::sr_detected. 2021-10-23 21:26:00 +02:00
faluco a1b2f3915d Whitelist lock order inversion tsan issue in srsenb::rlc::rb_is_um. 2021-10-23 21:26:00 +02:00
Andre Puschmann 8294724aad gnb_interface: reduce MAX_GRANTS to 4
this significantly reduces data copies when providing the PHY
with scheduler results.
2021-10-23 21:09:26 +02:00
Xavier Arteaga 95bf85b3d3 Reduced maximum number of CSI reports 2021-10-23 17:23:08 +02:00
Pedro Alvarez fbcffb84bd Check if RLC is suspended before transmiting PDCP SDU.
This was done to avoid integrity issues, when the UE's RRC erroneously sent
measurement reports while the re-establishment was already in progress.

As errously sending PDCP PDUs on DRBs can cause issues as well, this was
disabled too.
2021-10-22 17:27:32 +01:00
Xavier Arteaga d9bdc3f83e Add CSI resource information and fix segmentation fault 2021-10-22 12:46:44 +02:00
Carlo Galiotto 284207dad6 WIP: fixing collision in the the users_map
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-10-21 23:26:46 +02:00
Ismael Gomez 7920e084b8 Revert "Do not abort tsan"
This reverts commit e8e1d101c553912f733070e71d020a33ec895280.
2021-10-21 21:31:21 +02:00
Ismael Gomez 80c48a8b01 rlc: protect access to tx_enabled 2021-10-21 21:31:21 +02:00
Ismael Gomez bf566fbd29 radio: protect concurrent access from tx_end and tx 2021-10-21 21:31:21 +02:00
Ismael Gomez 4239222909 Do not abort tsan 2021-10-21 21:31:21 +02:00
Francisco c6226b0d94 lte,enb,rrc: parse cellIndividualOffset in rr.conf and propagate it to measConfig sent to UE 2021-10-21 16:16:01 +01:00
Pedro Alvarez e721504f8e Removed the sctp_init_server for consistency. Added listen method to unique_socket class. 2021-10-21 14:50:44 +01:00
Pedro Alvarez e9a7e6dbae Getting rid of sctp_init_client function. The only thing it does is call the sctp_init_socket function. 2021-10-21 14:50:44 +01:00
Francisco 7aa5f731ce lte,enb,rlc: push to scheduler pending prioritized bytes both in case of RLC timer expiry or in case of new buffer state detection 2021-10-21 09:31:03 +01:00
Francisco 4a58c10f30 lte,enb,rlc: compute and forward to scheduler the number of bytes pending for retx and status pdu in RLC AM bearer 2021-10-21 09:31:03 +01:00
Xavier Arteaga 8e5fe9018b Corrected LBRM functionality 2021-10-20 10:27:45 +02:00
Xavier Arteaga 9ecea014bd Added PUSCH DMRS minimum SNR 2021-10-19 23:05:16 +02:00
Francisco 0b51848dda nr,gnb,rrc: use multiqueue to forward x2 tasks to NR stack 2021-10-19 22:50:57 +02:00
Fabian Eckermann 59df04547e Increase buffer size for NR. 2021-10-19 10:18:44 +02:00
Andre Puschmann 3bf09021f9 enb: remove unused parameter 2021-10-18 14:17:53 +02:00
Francisco 7a16be9692 rrc,nr: ensure coresets and search spaces are passed to scheduler cell_cfg and ue_cfg 2021-10-16 22:43:23 +01:00
Andre Puschmann af69551c8d mac_sch_pdu_nr: add LBSR unpacking
* add LBSR unpacking
* add pretty printer
* also simplify and unify general unpacking code
2021-10-16 21:50:07 +02:00
Francisco 81174bda64 nr,ue,rrc: release NR logical channels during RRC release 2021-10-15 18:28:09 +01:00
Xavier Arteaga 3c40cd2840 Improved NR PHY logging info 2021-10-15 18:19:04 +02:00
Xavier Arteaga a5f6aa9f31 Added CSI string in PDSCH and PUSCH decode 2021-10-15 18:19:04 +02:00
Xavier Arteaga 003c6e524c Added short NR CSI information 2021-10-15 18:19:04 +02:00
faluco dacf40f63e Delete move constructor and move assignment operator explictly for mac_pcap_base and s1ap_pcap classes.
Move emergency handlers header file into the support folder.

Refactored signal handling:
- Remove the dependency with the running static variable in the header file.
- Move implementations down to cc files.
- Allow specifying a new signal handler that will be used to stop the applications.
- Move signal handling files to support.
2021-10-15 15:05:37 +02:00
faluco 9075251627 Move the cleanup code from the signal handlers down to the new emergency handlers for the ue, epc and enb. 2021-10-15 15:05:37 +02:00
faluco 2c1e9c0c55 Implement an emergency cleanup handler registration mechanism to allow modules to clean themselves before application gets killed.
Flush PCAP contents just before killing the application.
2021-10-15 15:05:37 +02:00
Francisco f427a25a30 nr,gnb,mac: account for header space larger than 2 when packing PDSCH 2021-10-15 11:03:02 +02:00
Francisco ed2e88524f asn1,rrc_nr: implement to_json in setup_release_c 2021-10-14 21:38:48 +01:00
Francisco 9df6c6b936 sched,nr: ensure the ue_cfg_t passed to the scheduler in NR FDD mode has the correct harq delay 2021-10-14 21:38:12 +01:00
Andre Puschmann 255ddb1329 enb,gnb: add basic support for sgnb release procedure
the procedure is currently started when the EUTRA UE object
is deleted (after RRC release) in order to clean-up the
ENDC resources on the gNB.
2021-10-14 21:30:14 +02:00
Francisco ea324e8cbe nr,sched,test: update sched nr test to better reflect MAC-PHY FAPI 2021-10-14 19:27:52 +01:00
faluco 28bbaa7816 Blacklist TSAN issues from libusb and libuhd. 2021-10-14 08:55:06 +02:00
Alejandro Leal Conejos 1a64c6adad Enum fixes so clang 12 can build the repo 2021-10-14 08:48:04 +02:00
Carlo Galiotto f53e01cfa3 mac: apply changes by PR reviewers
- reinstate write_lock on ue metrics
- change "rwlock" variable name in mac_nr.h

Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-10-13 11:12:03 +02:00
Carlo Galiotto dc3e3a89f8 mac: update CQI in MAC with CSI reports from PHY
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-10-13 11:12:03 +02:00
Francisco 11ee4ab9dd nr,gnb,rrc: fix scheduler FDD configuration 2021-10-12 17:49:12 +01:00
Francisco 1b595b6eff nr,gnb: if no nr cell is initiated, do not enable endc in the LTE RRC 2021-10-11 18:21:51 +01:00
Francisco 43b12b9ffb rrc,nr: transfer SSB config to both UE and NR scheduler 2021-10-09 16:53:14 +01:00
Carlo Galiotto 43a7d822fa stack,rrc: fix double removal of EPS bearer
The EPS bearer was removed twice, causing an error in the logs.

Fix issue #3380

Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-10-08 11:19:12 +02:00
Xavier Arteaga 25bd0d6219 Added SSB pattern to/from string functions 2021-10-08 09:49:07 +02:00
Francisco 47e5e85449 refactor: clean unnecessary includes of the asn1/rrc_nr.h 2021-10-07 23:08:07 +01:00
Xavier Arteaga 1bdb1bb62d Store PUSCH CSI from PUSCH DMRS 2021-10-07 16:31:26 +02:00
Bedran Karakoc 850606f20b Added deregistration (UE terminating) 2021-10-06 20:01:00 +02:00
Xavier Arteaga d5b34696b4 Sepparate CSI report configuration from quantification and integrate in nr_phy_test with assertions 2021-10-06 16:33:51 +02:00
faluco 388b1e5d92 Fix data race in radio::is_start_of_burst. 2021-10-06 12:49:34 +02:00
faluco 7b0b76d58e Whitelist two lock order inversion TSAN issues that acquire a readlock. 2021-10-06 12:49:34 +02:00
Francisco Paisana b7f40b2baf rrc,nr: reenable CSI reporting in gNB 2021-10-06 10:58:29 +01:00
Fabian Eckermann cb721aa292 fix calculation of ssb frequency. 2021-10-05 18:21:58 +02:00
Francisco Paisana b58915d7ed rrc,nr: make gnb cell CSI NZP configuration consistent with UE NSA configuration. 2021-10-05 10:28:36 +02:00