Commit Graph

9420 Commits

Author SHA1 Message Date
faluco 3b2f0d2f65 Fix several issues in GW class:
- Avoid triggering an assertion when the  gw thread is pending termination.
- Re-order gw::stop method to avoid a race condition when closing the TUN device while the gw thread is still running.
2021-10-28 17:42:08 +02:00
Andre Puschmann 229b1eef21 radio,test: fix Coverity warning about dead code
add default in switch instead of using the the END state directly
that is checked before entering the switch. Coverity correctly
reports this as dead code.
2021-10-28 17:25:21 +02:00
Ismael Gomez 8a53a9d35c ssb_decode_test: Fix stack overflow pbch_msg buffer 2021-10-28 16:13:02 +02:00
Francisco 1272f4c327 nr,gnb,mac: fix log tti context overflow 2021-10-28 14:49:29 +01:00
Andre Puschmann 4c7bc57b01 enb,ue_nr: fix warning when unpacking MAC PDU with padding 2021-10-28 10:45:54 +02:00
Pedro Alvarez 5735118ea0 Make sure SCTP notifications are not handled. Improve logging of SCTP ASSOC CHANGE 2021-10-27 21:45:48 +02:00
Andre Puschmann 5f837c0c67 enb,nr: rewrite UL PDU processing to handle CEs in reverse order but SDUs in order
this makes sure that C-RNTI CE gets processed before any SDU gets processed.
but it also makes sure that all SDUs then are processed in-order to
avoid reordering at higher layers.
2021-10-27 19:50:35 +02:00
Andre Puschmann 6d0aafcf69 rlc_um_nr: fix has_missing_byte_segment() routine
return true if rx_window contains segment of this SN
2021-10-27 19:50:35 +02:00
Andre Puschmann 5b025cfbf8 rlc_um_nr: reimplement update of RX_Next_Reassembly 2021-10-27 19:50:35 +02:00
Andre Puschmann 2366dc286d rlc_um_nr: improve logging 2021-10-27 19:50:35 +02:00
Andre Puschmann 85e478d8ad rlc_um_nr_test: add TC to reproduce reassembly issue
* add TC to reproduce reassembly issue that causes low TCP throughput
* fix PCAP writing
* fix other testcase to wait for t_reassembly to expire
2021-10-27 19:50:35 +02:00
Alejandro Leal Conejos ca7a377878 Fixes coverity 262740 2021-10-27 19:47:45 +02:00
Alejandro Leal Conejos f3be849d6b Fixes coverity 339793 2021-10-27 19:47:45 +02:00
Alejandro Leal Conejos 4bd8b6f2de Fixes coverity 359677 2021-10-27 19:47:45 +02:00
Alejandro Leal Conejos af3a2ef589 Fixes coverity 359789 2021-10-27 19:47:45 +02:00
Alejandro Leal Conejos eb889d740d Fixes coverity 369513 2021-10-27 19:47:45 +02:00
Alejandro Leal Conejos 6cd917fca5 Fixes coverity 370816 2021-10-27 19:47:45 +02:00
Alejandro Leal Conejos 0fdbfcffd0 Removes unnecesary cast 2021-10-27 19:47:45 +02:00
Bedran Karakoc 9943c79c4a Return error in ul nas transport if AMF ctxt is not available 2021-10-27 19:37:49 +02:00
Bedran Karakoc a14cc451d0 Addition NGAP cleanup 2021-10-27 19:37:49 +02:00
Bedran Karakoc fa87715724 Increase context rx count for handled messages 2021-10-27 19:37:49 +02:00
Bedran Karakoc b6b0dd911b Apply NAS security for Identity Response 2021-10-27 19:37:49 +02:00
Bedran Karakoc 66ed8b9065 Add NSSAI slice differentiator, currently only 0 supported 2021-10-27 19:37:49 +02:00
Bedran Karakoc 7c53f1cbab Add stdout for successful NG connection 2021-10-27 19:37:49 +02:00
Bedran Karakoc 4e60475200 Apply security to Deregistration Request (UE Originating) 2021-10-27 19:37:49 +02:00
faluco f1385640c4 Fix data race in proc_bsr and ul_harq classes. 2021-10-27 18:15:28 +02:00
faluco 3f0d4f0293 Fix data races in proc_bsr_nr and proc_ra_nr. 2021-10-27 18:15:28 +02:00
Andre Puschmann 08e9b0b5c1 enb,rrc: reduce log level when inactivity event is received from NR 2021-10-27 18:04:14 +02:00
Andre Puschmann 7f6801cb1e ue_sync: fix 32bit compilation
fix printf format string on 32bit arches like ARMv7

FAILED: lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o
/usr/bin/gcc -DASSERTS_ENABLED -DENABLE_TIMEPROF -DENABLE_TTCN3 -DHAVE_BACKWARD -DHAVE_MBEDTLS -DHAVE_PCSC -I/usr/include/PCSC -I/usr/include/SoapySDR -Ilib/include -I../lib/include -Wno-unused-but-set-variable -Wall -Wno-comment -Wno-write-strings -Wno-unused-result -Wformat -Wmissing-field-initializers -Wtype-limits -std=c99 -fno-strict-aliasing -D_GNU_SOURCE -O3 -fno-trapping-math -fno-math-errno -DBUILD_TYPE_RELEASE -DIS_ARM -DHAVE_NEON -mfloat-abi=hard -mfpu=neon -fvisibility=hidden -fdiagnostics-color=always -Werror --param large-function-growth=1600 -O3 -DNDEBUG -fPIC -MD -MT lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o -MF lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o.d -o lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o   -c ../lib/src/phy/ue/ue_sync.c
In file included from ../lib/include/srsran/srsran.h:31,
                 from ../lib/src/phy/ue/ue_sync.c:13:
../lib/src/phy/ue/ue_sync.c: In function ‘srsran_ue_sync_set_tti_from_timestamp’:
../lib/include/srsran/phy/utils/debug.h:59:23: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘uint64_t’ {aka ‘long long unsigned int’} [-Werror=format=]
       fprintf(stdout, "[DEBUG]: " _fmt "\n", ##__VA_ARGS__);                                                           \
                       ^~~~~~~~~~~
../lib/src/phy/ue/ue_sync.c:1044:3: note: in expansion of macro ‘DEBUG’
   DEBUG("rx time with 3gpp base in ms %lu\n", time_3gpp_msecs);
   ^~~~~
../lib/src/phy/ue/ue_sync.c:1044:41: note: format string is defined here
   DEBUG("rx time with 3gpp base in ms %lu\n", time_3gpp_msecs);
                                       ~~^
                                       %llu
cc1: all warnings being treated as errors
2021-10-27 18:03:03 +02:00
joaquim-SRS 00b82bc772 Fix more issues in PHY lib
Fix variable shadowing issues in chest_test
Fix mutex unlock position in dft_fftw.c
CID 371598 Out of bounds access, in ssb_decode_test.c
2021-10-27 18:02:00 +02:00
joaquim-SRS 9b74e3429c Fix more Coverity issues in the PHY lib
CID 369560 Missing unlock, in dft_fftw.c
CID 363710 Logically dead code, in resampler.c
CID 55097 Result is not floating point, in chest_test_dl.c
CID 351020 Result is not floating point, in chest_nbiot_test_dl.c
2021-10-27 18:02:00 +02:00
Nils Fürste 3b1131936e Fix GTP-U bearer address conversion
Addresses with a leading 0 in hex represenatation were converted
without the leading 0 and padded afterwards with a trailing 0. This
leaded to wrong IPs in the GTP-U bearer setup.
2021-10-27 17:53:28 +02:00
Nils Fürste b036da07de Extend ASN1 utils function from_number() 2021-10-27 17:53:28 +02:00
Fabian Eckermann 0007473c7a Initialize variable. 2021-10-27 17:39:51 +02:00
Fabian Eckermann f539851128 Fix possible out-of-bounds-read. 2021-10-27 17:39:51 +02:00
Fabian Eckermann 3e9590fd13 Initialize variable. 2021-10-27 17:39:51 +02:00
Fabian Eckermann 1c75ed10a8 Initialize variable. 2021-10-27 17:39:51 +02:00
Fabian Eckermann 1b2d77a49d Fix possible out-of-bounds-read. 2021-10-27 17:39:51 +02:00
Fabian Eckermann 8753ea1be5 Fix coverty defects. 2021-10-27 17:39:51 +02:00
Carlo Galiotto 5972345c9d rrc,nr: increase msg5 timer to 5s and inactivity...
timer to 10s

Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-10-26 23:18:17 +02:00
Carlo Galiotto 0d67fbc36c rrc: change call to release user
We call s1ap instead of rrc

Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-10-26 23:18:17 +02:00
Carlo Galiotto 9c74dda039 rrc,nr: add msg5 and inactivity timers to RRC-NR
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-10-26 23:18:17 +02:00
Andre Puschmann 0cfcd612b0 enb.conf.example: fix merge conflict 2021-10-26 22:19:29 +02:00
faluco edf0926a2f Batch of LGTM fixes. 2021-10-26 21:49:17 +02:00
Francisco 529e2bdf55 nr,rlc: call bsr update callback in RLC UM NR 2021-10-26 21:44:59 +02:00
Francisco 7ad1ad800e lte,enb,rlc: atomically compute DL buffer state and update the scheduler in the eNB 2021-10-26 21:44:59 +02:00
Ismael Gomez d972fb368c
Some LGTM fixes (#3564)
* Fix LGTM issues

* ue: add logging to switch on function

* Fix new LGTM issues
2021-10-26 21:15:36 +02:00
Alejandro Leal Conejos 2a2518b7e4 Fixes coverity 372096 2021-10-26 21:09:44 +02:00
Alejandro Leal Conejos 547ebf11f7 Fixes coverity 372880 2021-10-26 21:09:44 +02:00
Alejandro Leal Conejos ee0ec564ef Fixes coverity 373333 2021-10-26 21:09:44 +02:00