Commit Graph

1629 Commits

Author SHA1 Message Date
Andre Puschmann db9f093b63 add debug log when handling reordering timer 2019-07-12 13:06:39 +02:00
Andre Puschmann 849ad2655c fix creation of malformed RLC AM status PDU
the issue was caused by an unneeded length check during the
assembly of the status PDU. This length check caused an too early
break from the while-loop that adds all missing SNs to the status PDU
leaving the PDU struct in an invalid state where ack_sn was equal to
one of the NACK_SNs.
The fix is to simply remove the length check during the generation to
fully generate the status PDU. If, for whatever reason, MAC provides
a too small grant to fully fit the status PDU, the PDU will not be
generated, i.e. the calling function checks the return value and does
not pass the (then too big PDU) down the stack.
2019-07-12 13:06:39 +02:00
Andre Puschmann 9f3a947c02 modify RLC AM retx test to provide exactly a MAC opportunity of the size
that is reported as buffer state
2019-07-12 13:06:39 +02:00
Xavier Arteaga aa6652155c Phy: added ue_ul normalization mode parameter 2019-07-12 13:05:10 +02:00
Xavier Arteaga 20823e191d SRSUE: Added UL force amplitude optional parameter 2019-07-12 13:05:10 +02:00
Andre Puschmann 4e86b2f6b2 introduce layerd architecture we use for UE to eNB
- this allows flexible use of different PHYs and radios
- use common radio_multi (moved to lib)
2019-07-12 04:17:56 +02:00
Xavier Arteaga 2530894374 Channel emulator: added input pointer checks 2019-07-11 10:28:13 -04:00
Ismael Gomez d595c4d882 Fixes issue #545 and unlocking of tti_sync condvar before closing causing deadlock at stop 2019-07-11 14:55:35 +02:00
Andre Puschmann aff26abc89 fix memleak in Soapy driver when no device was found 2019-07-10 22:46:33 +02:00
Ismael Gomez 773c2a9721 Fixed multiple issues in Random Access procedure and extended MAC test 2019-07-08 17:14:25 +02:00
Andre Puschmann 6b2961fcee add MAC DL-SCH unpacking test 2019-07-05 17:24:06 +02:00
Andre Puschmann 92f0d58856 mac: move further init/config into ctor to allow early logging, etc. 2019-07-05 17:24:06 +02:00
Francisco Paisana 92b4b168fe added default rlc um and am in the interface as factories 2019-07-05 10:44:15 +02:00
Francisco Paisana b903c1a52c made default init for rlc um test 2019-07-05 10:44:15 +02:00
Francisco Paisana 58e2e51044 removed rlc_interfaces. The rlc_cnfg types are now part of the rrc_interface_types. Removed implicit RB initialization in the RLC. 2019-07-05 10:44:15 +02:00
Francisco Paisana c5509caece added extra operators and remove rrc_asn1 in some cmake targets 2019-07-05 10:44:15 +02:00
Francisco Paisana b936629221 removed rrc asn1 header from bcd_helpers, from rlc_interface, and rlc tests 2019-07-05 10:44:15 +02:00
Francisco Paisana bb0dbf0f1c created a asn1 utils with helper functions and types related to the asn1. These types/functions will help isolate the rrc_asn1 lib from most of the layers, reducing this way the compile times, and leading to better isolation. This will also make the transition to NR smoother. I removed the asn1 types from the NAS and USIM interface so far. 2019-07-05 10:44:15 +02:00
Francisco Paisana 416f9896ec fixes to include the findings from PR #550 2019-07-05 10:38:28 +02:00
Guillem Foreman 46724c336d Fixed errors for phy_dl_test and pdsch test 2019-07-04 15:49:43 +02:00
Guillem Foreman 4627737c87 Revert "Disable 256QAM tests failing in CentOS"
This reverts commit 833ce5224a.
2019-07-04 15:49:43 +02:00
Guillem Foreman c71763dc93 Fixed minor message in modem test 2019-07-04 15:49:43 +02:00
Guillem Foreman db4127ca64 Fixes 256QAM, added pdsch table 2, fixed warnings 2019-07-04 15:49:43 +02:00
Guillem Foreman 535325bc37 srsLTE: added resource allocation extended tables for 256QAM and integration with PDSCH test 2019-07-04 15:49:43 +02:00
Andre Puschmann 62a4fa1c93 fix various potential buffer overruns
this is based on suggested fixes by Dirk Grabinski and David who
have fuzzed various parts of srsLTE using afl
2019-07-04 14:43:59 +02:00
Andre Puschmann 701db61fde rlc: extend stress tester to simulate MAC PDU corruption 2019-07-04 14:43:20 +02:00
Andre Puschmann ecb6a0f99b fixing RLC AM bug where corrupted PDU causes segfault
the underlaying issue is that a corrupted PDU is passed to RLC
which claims to have segments whose total size exceed the size
of the entire PDU. Those PDUs are not ignored.
2019-07-04 14:43:20 +02:00
Xavier Arteaga a417d3a70a Added DCI trace if cqi is requested 2019-07-02 16:36:06 +02:00
Xavier Arteaga 87433c83da SRSUE: 64QAM R8 compatible 2019-07-02 16:36:06 +02:00
Ismael Gomez 833ce5224a Disable 256QAM tests failing in CentOS 2019-07-01 18:22:49 +02:00
Pedro Alvarez 498f1b8e4b Small PDCP fixes:
- Moved most the initialization of the pdcp_entity to the header.
  - Initilize some variables in gtpu_ntoa.
  - Removed debug print.
  - Format eNB GTP-u debugging code.
2019-06-27 17:09:52 +02:00
Pedro Alvarez 1c51d2ca9a Small clang format changes. 2019-06-27 17:09:52 +02:00
Pedro Alvarez 5d8dcbe4cb Make sure that PDCP SN is initialized properly in the eNB. UE attaches again when using encription. 2019-06-27 17:09:52 +02:00
Pedro Alvarez 53d2220aab Resolved conflicts with unique pointers after rebase in PDCP entity. 2019-06-27 17:09:52 +02:00
Pedro Alvarez 2643b9070f Fixing mistake in setting PDCP last_submitted_pdcp_rx_sn 2019-06-27 17:09:52 +02:00
Pedro Alvarez 6d5dbdedfa Fixed mistake in comparison in pdcp_entity. 2019-06-27 17:09:52 +02:00
Pedro Alvarez 693338da07 Added TX HFN print to make it easier to debug HFN mis-match 2019-06-27 17:09:52 +02:00
Pedro Alvarez 6b59cc0760 Debug print for PDCP Reestablish. 2019-06-27 17:09:52 +02:00
Pedro Alvarez 5ca6238877 Adding encription debug prints. 2019-06-27 17:09:52 +02:00
Pedro Alvarez b97d1191f4 Added more debug info at eNB GTP-U. Changed the pdcp_entity to follow the standard more strictly for RLC AM DRBs. 2019-06-27 17:09:52 +02:00
Pedro Alvarez f4fd6034ba Starting to add separate functions for PDCP handling for UM DRBs and AM DRBs 2019-06-27 17:09:52 +02:00
Pedro Alvarez 6578cf1d01 Making sure that next_pdcp_rx_sn is reset at reestablish. 2019-06-27 17:09:52 +02:00
Pedro Alvarez 6cbcc5154d Starting to use received SN to do user plane decription. 2019-06-27 17:09:52 +02:00
Andre Puschmann 58763fb714 stack: move initialization of log object into ctor
this fixes the issue when the stack is torn down if, for example,
the radio couldn't be loaded correctly. it will hence call stop() on all stack
components which are not initialzized yet, and logging therefore doesn't work.
the log object is know during contruction time and therefore can be passed
in as soon as possible.
2019-06-27 14:51:33 +02:00
Pedro Alvarez 8f5ad55c4a Added attach request as a UL info trasnfer in the UE. Added interface to remove eps bearer map when going idle. Fixed bug in GW in assignment of IPv4 addresses. UE seems to rebound from the service reject now. 2019-06-26 18:04:41 +02:00
Andre Puschmann 82a69fb51c mux: fix packing of short MAC PDUs 2019-06-26 17:57:25 +02:00
Andre Puschmann 0012868e91 rlc_am: reduce log level when provided PDU size is too small 2019-06-26 17:57:25 +02:00
Andre Puschmann 4aaa0473b9 pdu: remove unused variable total_sdu_len 2019-06-26 17:57:25 +02:00
Andre Puschmann fab75592ec fix MAC PDU padding with only padding and add test accordingly 2019-06-26 17:57:25 +02:00
Andre Puschmann b6d7fd5def improve error handling in PDU packing 2019-06-26 17:57:25 +02:00
Andre Puschmann da35f41dd5 rework MAC logical channel prioritization 2019-06-26 17:57:25 +02:00
Andre Puschmann 6d586d84a8 extend MAC PDU test 2019-06-26 17:57:25 +02:00
Xavier Arteaga 5d792e7ebe AGC: Fixed gain hysteresis 2019-06-25 09:12:28 +02:00
Andre Puschmann e0a28cf4c0 simplify PDCP init and also bypass it for SRB0 on eNB 2019-06-21 15:49:46 +02:00
Andre Puschmann 0ef96f789b bypass PDCP for SRB0 processing chain 2019-06-21 15:49:46 +02:00
Andre Puschmann 218f136254 remove default PDCP entity for SRB0 2019-06-21 15:49:46 +02:00
Andre Puschmann f5a929e425 pdcp: print length when processing incoming PDU 2019-06-21 15:49:46 +02:00
Francisco Paisana ce29ed545d moved mac thread to the stack. Protect the interface of the stack with PHY and gateway via a queue of tasks 2019-06-21 13:01:41 +02:00
Francisco Paisana 10a56e2a84 moved GW out of the UE stack. This is important to keep concurrency out of the stack once it becomes single-threaded 2019-06-20 15:26:52 +02:00
Xavier Arteaga bb26a42fb6 Fixed backtrace symbols free 2019-06-19 11:49:55 +02:00
Andre Puschmann 414e55fafc pcap: add dtor
this fixes issue if object is destroyed and PCAP is still open
2019-06-18 20:50:23 +02:00
Ismael Gomez 67b6a40c1b Use correlation for neighbour RSRP measurement 2019-06-18 17:55:41 +02:00
Andre Puschmann abef6ce152 move own ipv6 header definition into own header file and use it in tft filter 2019-06-18 16:06:52 +02:00
Guillem Foreman 269e21e3af Fixed minor format 2019-06-17 18:04:32 +02:00
Guillem Foreman 50edd9a325 Initial 256QAM Modem and Demodulator 2019-06-17 18:04:32 +02:00
Joseph Giovatto 0bb7f590b3 Moved include complex.h from header files to impl files to prevent
error /wr to complex.h and c linkage in CentOS 7.
2019-06-14 12:19:57 +02:00
Andre Puschmann 2b82f21fd2 fix compiler warning 2019-06-14 11:26:19 +02:00
Andre Puschmann acbe7fabe4 rlc: fix class member initialization
uninitialized member detected by coverity, now converted all default
initialization to be done in class definition
2019-06-14 11:26:19 +02:00
Andre Puschmann b32254c5e2 use lock_guard for GW 2019-06-12 20:44:23 +02:00
Andre Puschmann 89416a67c7 increase timeout for rlc stress tests
for valgrind where we sometimes hit the default timeout of 1500s
2019-06-12 20:44:23 +02:00
Xavier Arteaga 1f4cf8121b SRSUE: Initial UL channel simulator 2019-06-11 12:06:11 +02:00
Andre Puschmann 2b7b4d0e7e remove hard-coded LCID for dedicated bearer in GW 2019-06-07 21:40:03 +02:00
Pedro Alvarez 2723aa9b12 Added EPS bearer id to apply_tft interface. Sending packets to the correct LCID if they match the packet filter. 2019-06-07 21:40:03 +02:00
Pedro Alvarez a7e0a0624b Starting to add interface apply_traffic_flow_template between NAS and GW. 2019-06-07 21:40:03 +02:00
Pedro Alvarez 2fcf8c1827 Starting to add packing and unpacking tests to activate EPS bearer context request. 2019-06-07 21:40:03 +02:00
Francisco Paisana 415d3418b6 reorganized enb to mirror ue director/class structure with a stack class 2019-06-07 15:41:56 +02:00
Pedro Alvarez d67d18cc6b Removing deplicated error codes. 2019-06-07 13:51:56 +02:00
Xavier Arteaga bd3ec34f7b SRSUE: Apply CLang format phy args structure 2019-06-06 15:00:26 +02:00
Xavier Arteaga fd3671a7e5 SRSUE: Enable AGC 2019-06-06 15:00:26 +02:00
Andre Puschmann e8d6236975 remove init for all RLC TM/UM/AM
- all RLC entities are now initialized during contruction
- there is no need to check for, e.g., existance of timers, during
  runtime
- there is also no need to call re-init during resume
- timers are freed in dtor
2019-06-06 14:34:25 +02:00
Ismael Gomez f24c0cef8c Use timer interface instead of local boolean to query timer state 2019-06-06 14:34:25 +02:00
Ismael Gomez c2e9817f41 Possible solution to RLC Reestablishment 2019-06-06 14:34:25 +02:00
Ismael Gomez 14b526f2aa Add PDCP per-bearer reestablish 2019-06-06 14:34:25 +02:00
Ismael Gomez ade720e032 Add RLC resume procedure 2019-06-06 14:34:25 +02:00
Andre Puschmann 3f613d7183 nas/gw/rrc: make LCID for DRB dynamic
- add interface to RRC to allow NAS to query the DRB for a given
  EPS bearer id
- extend interface for NAS to setup GW to also pass LCID of bearer
- in NAS, use this new interface to pass actual LCID of the default
  DRB when creating the TUN device
2019-06-05 20:50:52 +02:00
Andre Puschmann f357c995fc liblte_mme: fix packing and unpacking of modify EPS bearer context
this just skips the security bits but the packing/unpacking of
the values, i.e. new TFT may still be wrong
2019-06-05 17:41:46 +02:00
Ismael Gomez b31b668a8e Remove unnecessary find_package(GUI) 2019-06-04 13:31:31 +02:00
Ismael Gomez 594d62f229 Added read_block function to ringbuffer 2019-06-03 21:39:24 +02:00
Ismael Gomez 19cb5c172b Added read-and-convert function to ringbuffer 2019-06-03 21:19:06 +02:00
Andre Puschmann e47010130f extend thread class to set unique thread name in ctor
this will also extend all classes that use srslte::thread
to specify the name of the thread in the ctor as well
as to set the name of the worker threads in the thread pool
the thread name will be displayed in gdb.
2019-06-03 15:03:20 +02:00
Andre Puschmann 0e95867f13 remove task dispatcher class 2019-06-03 15:03:20 +02:00
Andre Puschmann acf95fdd85 rlc_am: fix newline in logs 2019-05-31 12:20:30 +02:00
Xavier Arteaga b903e61548 Initialise all channel emulator attributes by default 2019-05-31 10:51:11 +02:00
Andre Puschmann b3f1915f7b pdu: fix zero-padding of RAR PDUs 2019-05-30 15:31:54 +02:00
Xavier Arteaga 9c84f8e3fd SRSLTE: Added Uniform Random vector generator; Delay channel test; Fixed Delay channel SEGFAULT; SRSUE channel unique pointer; 2019-05-30 13:07:23 +02:00
Xavier Arteaga 2ffa1f9f1e SRSUE: Added RLF simulator in channel emulator and integrated it in SRSUE. Removed Zeros Command 2019-05-30 13:07:23 +02:00
Xavier Arteaga 7c97e40e63 SRSUE: Improved internal channel emulator help 2019-05-30 13:07:23 +02:00
Xavier Arteaga 9ab2b2de81 SRSUE: Created delay channel emulator and added fading to the UE 2019-05-30 13:07:23 +02:00
Andre Puschmann 709e769d0d pdu: fix formatting 2019-05-30 13:06:42 +02:00
Andre Puschmann ee1f910877 pdu: add unit test for packing and unpacking RAR PDUs 2019-05-30 13:06:42 +02:00
Andre Puschmann ea2e692836 pdu: fix MAC RAR PDU packing and unpacking with backoff indicator 2019-05-30 13:06:42 +02:00
Andre Puschmann e97343579b liblte_mme: fix typo in header 2019-05-30 13:05:02 +02:00
Pedro Alvarez 1031ea896d add NAS activate dedicated bearer request unpacking test 2019-05-30 13:05:02 +02:00
Andre Puschmann 76b84a9b61 fix unpacking of deactivate eps bearer context 2019-05-30 13:05:02 +02:00
Pedro Alvarez 69b1a2319e Fix error in the TFT parameter list size unpacking 2019-05-30 13:05:02 +02:00
Pedro Alvarez 82828a699b Fixed bug in transaction identifier and radio prio unpacking in NAS. 2019-05-30 13:05:02 +02:00
Pedro Alvarez 02beeefdbd Fix header unpacking error in the Activate EPS dedicated bearer context request message 2019-05-30 13:05:02 +02:00
Andre Puschmann 1c749ad559 add basic handling for deactivating eps bearer 2019-05-30 13:05:02 +02:00
Andre Puschmann c14c3c23f1 pdcp: fix issue when setting SN length configuration 2019-05-30 13:05:02 +02:00
Andre Puschmann f000e36f21 liblte_mme: fix dedicated bearer handling, add handling for UE testmode 2019-05-30 13:05:02 +02:00
Andre Puschmann 8fd4c42849 fix include in build_info.h template 2019-05-28 13:04:53 +02:00
Andre Puschmann 20c9f4687c remove duplicated code mac_cfg_t 2019-05-27 12:37:52 +02:00
Xavier Arteaga 7629863c5a SRSUE MAC: 36.331 v10 9.2.2 MAC main config defaults does not include RACH 2019-05-27 12:37:52 +02:00
Xavier Arteaga 2c78111666 SRSUE: Fixed CLang Tidy in ue.cc 2019-05-27 12:21:57 +02:00
Francisco Paisana 00256f2cd9 fix the hanging in the UE during shutdown 2019-05-24 17:08:14 +02:00
Francisco Paisana 4311c3121c avoid crash when converting nulltype to string 2019-05-24 09:42:42 +02:00
Andre Puschmann 58b09c8677 fix pool_allocate macros for new unique_buffer 2019-05-20 17:16:12 +02:00
Xavier Arteaga 080b4a327c SRSUE: Refactored asynchronous cell and ue_radio. CA Fixed. 2019-05-17 18:13:51 +02:00
Andre Puschmann 65f50cd7ba introduce new UE layer design
- abstract UE object now consists of a radio, a PHY, and a stack layer
- add new stack abstraction layer that combines MAC, RLC, RRC, PDCP, NAS and GW
- PHY layer now has a single stack interface and does not talk to MAC and RRC seperatly
2019-05-17 17:46:28 +02:00
Andre Puschmann 3a6dd9b164 move UE RRC into own folder 2019-05-17 17:25:50 +02:00
Francisco Paisana 0e3baa0f2f Renamed the reset() method of byte_buffer_t to clear() 2019-05-16 12:35:01 +02:00
Francisco Paisana 3bedc93ba5 added _t to unique_byte_buffer type 2019-05-16 12:35:01 +02:00
Francisco Paisana bc01a5ecda changed block_queue api to return back the unique buffer in case it fails to push it to the queue 2019-05-16 12:35:01 +02:00
Francisco Paisana f4aa03154d change queue read and other functions apis 2019-05-16 12:35:01 +02:00
Francisco Paisana f469e2178b replaced byte_buffer_t allocated by the buffer pool for unique_byte_buffer which is safer and easier to use 2019-05-16 12:35:01 +02:00
Francisco Paisana 0976ea6f27 created a unique byte buffer that automatically deallocates 2019-05-16 12:35:01 +02:00
Andre Puschmann 4edcedd2b3 add helper to create cexp function for entire subframe 2019-05-16 12:32:36 +02:00
Andre Puschmann 4f42c0796c add CFO correction method with offset
- CFO correction which allows to specify the offset within
  the correction table to allow phase-continuity across
  multi-subframe transmissions (NB-IoT)
2019-05-16 12:32:36 +02:00
Andre Puschmann 7138126896 add short-cirtuit evaluation for calculating nof of ref symbols without passing object 2019-05-16 12:32:36 +02:00
Andre Puschmann e647dac3e4 add simple cross-correlation method
- implements a cross-correlation that takes the complex conjugate
  of one of the input signals (filter)
- the fft of this input signal is only computed once
2019-05-16 12:32:36 +02:00
Andre Puschmann 13c17ad9e7 add text output capabilities to filesink 2019-05-16 12:32:36 +02:00
Andre Puschmann 62dad5e21d add nb-iot tag support to PCAP writer 2019-05-16 12:32:36 +02:00
Andre Puschmann 92f3f02f2d remove radio_sync object 2019-05-16 12:30:26 +02:00
Andre Puschmann dc9df36a24 remove unused radio_multi code 2019-05-16 12:30:26 +02:00
Francisco Paisana 7be183c223 rework scheduler 2019-05-14 22:34:50 +02:00
Xavier Arteaga 2aa36dd11c Added backtrace print helper 2019-05-14 22:32:07 +02:00
Andre Puschmann fcd086a1c5 fix metrics_hub compilation for older gcc using std::chrono 2019-05-10 13:49:42 +02:00
Xavier Arteaga 114f66f8b9 Reduce ctest execution time 2019-05-10 12:01:43 +02:00
Andre Puschmann 0f6997170b fix unitialized var in pdu.h 2019-05-10 12:01:03 +02:00
Francisco Paisana aca1e9612d revert back from max_sizeof(...) to macros 2019-05-10 11:59:34 +02:00
Francisco Paisana 47ba5cd098 Set the optimization flag to Os for the rrc asn1 library 2019-05-10 11:59:34 +02:00
Francisco Paisana 14b6a1d483 setter method for choice types 2019-05-10 11:59:34 +02:00
Andre Puschmann 3f50e5f51c fix overlapping memcpy detected by valgrind
this has been detected by valgrind+gcc on Ubuntu 16.04 but
isn't an issue for more recent versions. Not sure if that is because
of an issue in older libc and there memcpy implementation or a
bug in valgrind, or both.

In any case, overlapping memcpy may cause undefined behaviour so
it seems ok to only copy the symbols that do not contain the
DMRS, i.e. not symbol 3 in each slot.
2019-05-09 17:40:08 +02:00
yagoda 0213045d74 small cmake bugfix for case where srsenb is disabled 2019-05-09 16:16:19 +02:00
Ismael Gomez efe74e765b Fix coverty non-inititalized variables in tdec 2019-05-08 10:56:48 +02:00
yagoda c25f3b0acf increasing rlc UM window size for eMBMS, small adjustment to eMBMS PHY common 2019-05-06 17:06:25 +02:00
Andre Puschmann 780ea8867c fix asn1_m2ap test
- there was an issue in the stack allocation of the large
  m2ap pdu struct that was fixed by heap-allocating it

- there was also an issue in the m2ap packing that used
  a temporary struct that was not initialized
2019-05-03 12:09:57 +02:00
Andre Puschmann fc432adb66 fix uninitialize variable in ue_ul.c 2019-05-03 11:16:58 +02:00
Andre Puschmann 779d599289 fix naming of unittest for ch_estimation (was overwriting previous test) 2019-05-03 11:02:21 +02:00
Andre Puschmann 723cd71a3a remove usage of <assert> in rlc_um_test 2019-05-03 10:58:05 +02:00