2d29e4005c
Starting to generate RLC NR status report.
...
Starting to check if status pdu generation is correct.
2021-11-17 10:50:35 +00:00
be9bb344a4
Starting to add handle_data_pdu to RLC NR entity.
2021-11-17 10:50:35 +00:00
7121152cff
Added basic functionality for read_pdu to RLC AM NR entity.
2021-11-17 10:50:35 +00:00
4196abafee
Added get_buffer_status to RLC AM NR entity
2021-11-17 10:50:35 +00:00
ebeb46b230
nr,pdcch_dmrs: take into account offset_rb in DMRS mapping
2021-11-17 10:28:31 +01:00
a58420a530
nr,gnb,rrc: implement basic NR RRC bearer addition and reconf message sending
2021-11-16 19:32:53 +00:00
0c733f7ea3
nr,ngap: use const_byte_spans instead of unique_byte_buffers in ngap interface to avoid intermediate copies
2021-11-16 19:32:53 +00:00
e8beb2ef81
nr,rrc: redesign fetching of asn1 obj ids for comparison and addmod/rem to asn1 lists
2021-11-16 19:04:51 +00:00
3b3630d444
nr,gnb,rrc: remove redundant code, and update rrc_nr_test to use default rrc nr cfg generator
2021-11-16 17:17:53 +01:00
f705445f21
nr,gnb,rrc: use rrc_nr_cfg to generate sib1 and mib
2021-11-16 17:17:53 +01:00
453a7760b3
Port misc SSN changes to dev.
2021-11-16 14:46:51 +01:00
0ee82ed0f6
ue_dl_nr_file_test: add option to select ue specific search space
...
* add option to select search space: ue and common1
* print coreset info
2021-11-16 12:57:20 +01:00
b7f9dd5d75
phy_common_nr: add helper method to print coreset info to string
2021-11-16 12:57:20 +01:00
5a3e99fb58
nr,gnb,rrc: fix missing return for mib generation
2021-11-16 00:12:36 +00:00
25a8ea53d3
nr,gnb,sched: pass mib config to scheduler so it is used during SSB allocation
2021-11-16 00:12:36 +00:00
fec97689a2
rrc,nr,gnb: refactored rrc nr cfg default and derived param generation to be mostly independent of parser
2021-11-16 00:12:36 +00:00
f2a5f00bb3
nr,gnb: fix abs freq ssb arfcn derivation
2021-11-15 15:47:31 +01:00
0b8a6970f0
nr,gnb,rrc: fix ssb frequency derivation when coreset0 is active
2021-11-15 15:47:31 +01:00
92c4e6e2d0
nr,gnb: account for CORESET#0 RB offset (See 38.213, table 13-1) in computation of SSB center frequency
2021-11-15 15:47:31 +01:00
4836e90b2c
Move place to apply reference_point_k_rb to dmrs
2021-11-15 09:50:39 +01:00
883ddef4a6
ue_dl_nr_file_test: fix compilation on gcc 4.8
2021-11-15 09:50:39 +01:00
66871b1e8e
ue_dl_nr_file_test: disable failing file tests temporarily
...
they will be enabled again as soon as the decoding issues are solved
2021-11-15 09:50:39 +01:00
798e9b7a5e
ue_dl: reference point for DMRS varies for SIB
2021-11-15 09:50:39 +01:00
e7c2cea032
Fix data conversion parse in ue_dl_nr_file_test
2021-11-15 09:50:39 +01:00
9c6f9f5949
dci_nr: print coreset0_bw when DCI is scrambled with SI-RNTI
2021-11-15 09:50:39 +01:00
d5a00fcdad
dci_nr_test: add test for DCI 1_0 with SI-RNTI
2021-11-15 09:50:39 +01:00
573b2f657a
ssb_file_test: make duplex and SSB SCS configurable, add new unit test for FDD+15kHz SCS
2021-11-15 09:50:39 +01:00
dd34f5b274
ue_dl_nr_file_test: fix coreset0 bandwidth when decoding SI-RNTI
2021-11-15 09:50:39 +01:00
972e080e48
ue_dl_nr_file_test: update SSB/SIB TV
...
update capture and make sure its rv=0
// Cell 0x01: nr_arfcn=368500 ul_nr_arfcn=349500 pci=500 mode=FDD rat=nr n_rb_dl=52 n_rb_ul=52 dl_mu=0 ul_mu=0 ssb_mu=0 ssb_arfcn=368410 ssb_prb=13:21 k_ssb=6 coreset0_prb=1:48 coreset0_idx=6
20:43:31.997 [PHY] DL - 01 ffff 784.0 PDSCH: harq=si prb=1:7 symb=2:12 CW0: tb_len=84 mod=2 rv_idx=0 cr=0.44
0000: 74 81 01 70 10 40 04 02 00 00 c8 00 24 68 a0 38 t..p.@......$h.8
0010: 05 01 00 40 1a 00 00 06 6c 6d 92 21 f3 70 40 20 ...@....lm.!.p@
0020: 00 00 80 80 00 41 06 80 a0 90 9c 20 08 55 19 40 .....A..... .U.@
0030: 00 00 33 a1 c6 d9 22 40 10 00 1e b8 94 63 c0 09 ..3..."@.....c..
0040: 28 c4 1b 8a 36 e1 5b 1c 3a 01 3c 5b 46 14 00 00 (...6.[.:.<[F...
0050: 00 00 00 00 ....
20:43:31.997 [PHY] DL - 01 ffff 784.0 PDCCH: ss_id=0 cce_index=0 al=4 dci=1_0
rb_alloc=0x120
time_domain_rsc=0
vrb_to_prb_map=0
mcs=6
rv_idx=0
si_indicator=0
dci_len=39
2021-11-15 09:50:39 +01:00
7a64163aa4
ue_dl_nr_file_test: enable coreset0_idx=6 file test
2021-11-15 09:50:39 +01:00
16b5f4c3db
ue_dl_nr_file_test: add further IQ capture with coreset0_idx=6
...
Cell 0x01: nr_arfcn=368500 ul_nr_arfcn=349500 pci=500 mode=FDD rat=nr n_rb_dl=52 n_rb_ul=52 dl_mu=0 ul_mu=0 ssb_mu=0 ssb_arfcn=368410 ssb_prb=13:21 k_ssb=6 coreset0_prb=1:48 coreset0_idx=6
12:58:46.197 [PHY] DL - 01 ffff 556.0 PDSCH: harq=si prb=1:7 symb=2:12 CW0: tb_len=84 mod=2 rv_idx=2 cr=0.44
0000: 74 81 01 70 10 40 04 02 00 00 c8 00 24 68 a0 38 t..p.@......$h.8
0010: 05 01 00 40 1a 00 00 06 6c 6d 92 21 f3 70 40 20 ...@....lm.!.p@
0020: 00 00 80 80 00 41 06 80 a0 90 9c 20 08 55 19 40 .....A..... .U.@
0030: 00 00 33 a1 c6 d9 22 40 10 00 1e b8 94 63 c0 09 ..3..."@.....c..
0040: 28 c4 1b 8a 36 e1 5b 1c 3a 01 3c 5b 46 14 00 00 (...6.[.:.<[F...
0050: 00 00 00 00 ....
12:58:46.197 [PHY] DL - 01 ffff 556.0 PDCCH: ss_id=0 cce_index=0 al=4 dci=1_0
rb_alloc=0x120
time_domain_rsc=0
vrb_to_prb_map=0
mcs=6
rv_idx=2
si_indicator=0
dci_len=39
2021-11-15 09:50:39 +01:00
d2fc11fbec
ue_dl_nr_file_test: add missing parameter to existing file tests
2021-11-15 09:50:39 +01:00
830cbcde08
ue_dl_nr_file_test: add all zero PDSCH check and let test fail in this case
2021-11-15 09:50:39 +01:00
77269c055d
ue_dl_nr_file_test: expose ARFCN for center and SSB and use it to derive RB offset
2021-11-15 09:50:39 +01:00
1684c56ca0
phy: add two IQ dumps with coreset0 and coreset1
...
coreset0:
15:03:16.697 [PHY] DL - 01 ffff 86.0 PDSCH: harq=si prb=2:7 symb=2:12 CW0: tb_len=84 mod=2 rv_idx=1 cr=0.44
0000: 74 81 01 70 10 40 04 02 00 00 c8 00 24 68 a0 38 t..p.@......$h.8
0010: 05 01 02 60 24 00 00 06 6c 6d 92 21 f3 70 40 20 ...`$...lm.!.p@
0020: 00 00 80 80 00 41 06 80 a0 90 9c 20 4c 29 21 00 .....A..... L)!.
0030: 00 00 33 a1 c6 d9 22 40 10 00 1e b8 94 63 c0 09 ..3..."@.....c..
0040: 28 c4 1b 8a 36 fd 5b 1c 3a 00 bc 5b 46 14 00 00 (...6.[.:..[F...
0050: 00 00 00 00 ....
15:03:16.697 [PHY] DL - 01 ffff 86.0 PDCCH: ss_id=0 cce_index=0 al=4 dci=1_0
rb_alloc=0x120
time_domain_rsc=0
vrb_to_prb_map=0
mcs=6
rv_idx=1
si_indicator=0
dci_len=39
coreset1:
15:03:16.693 [PHY] DL 0001 01 0100 85.6 PDCCH: ss_id=1 cce_index=0 al=4 dci=1_0
rb_alloc=0x5f
time_domain_rsc=0
vrb_to_prb_map=0
mcs=6
ndi=1
rv_idx=0
harq_process=0
dai=0
tpc_command=1
pucch_rsc=0
harq_feedback_timing=3
dci_len=39
15:03:16.693 [PHY] DL 0001 01 0100 85.6 PDSCH: harq=0 prb=2:48 symb=1:13 k1=4 CW0: tb_len=624 mod=2 rv_idx=0 cr=0.44 retx=0
0000: 43 02 6d 40 00 80 00 00 d6 5b 77 92 be 29 a1 5c C.m@.....[w..).\
0010: 9d d9 a3 42 64 bf d7 c0 cc 20 a6 4f b3 5e f5 06 ...Bd.... .O.^..
0020: 5f fc 03 02 83 ca e9 ee 04 e7 1a 1d 00 3f 9c 01 _............?..
0030: ec 1c 32 bb 6b 0f e2 e9 dc 7c f6 84 41 b2 2b e8 ..2.k....|..A.+.
0040: 10 f0 23 2c 91 f1 5d c7 6f b5 6e ac b6 fb c2 e6 ..#,..].o.n.....
0050: 32 2d b2 8b 07 36 11 f3 81 78 5d ff 1a 85 8d 6c 2-...6...x]....l
0060: 18 ce ca 52 1f 81 0f 78 c6 1a ab b5 e8 71 50 34 ...R...x.....qP4
2021-11-15 09:50:39 +01:00
8c99d7a3bd
ue_dl_nr_file_test: use common helper function to derive coreset0 params
2021-11-15 09:50:39 +01:00
279d82aa31
ue_dl_nr: debug to print PDCCH received symbols
2021-11-15 09:50:39 +01:00
36a287edd8
ue_dl_nr_file_test: expose various coreset and search space related parameters
2021-11-15 09:50:39 +01:00
f708635a5d
rrc_nr_cfg: set default PLMN for NR cell to 00101
2021-11-15 09:50:39 +01:00
779bfcf791
phy_common: fix symbol size derivation for NR-only cells
...
make sure that 52 PRB cell with LTE rates gives 15.36e6 as sample rate
2021-11-15 09:50:39 +01:00
853d870c52
rlc_um_nr: fix SN wrap-around in a few places
2021-11-14 16:25:09 +01:00
813adb9567
rlc_um_nr: reduce verbosity in info mode
...
this will only print the most relevant messages in info mode.
also streamlines some messages with RLC AM entity.
2021-11-14 16:25:09 +01:00
1bec07a64a
rlc_um_nr: fix starting/stopping of reassemble timer
2021-11-14 16:25:09 +01:00
b3c7eeedd3
rlc_um_nr_test: add extra check to verify reassembly timer isn't running
2021-11-14 16:25:09 +01:00
4187be3ff9
Revert "Revert "rlc_um_nr: reimplement update of RX_Next_Reassembly""
...
This reverts commit 296758e4ab
2021-11-14 16:25:09 +01:00
7141fda69c
Revert "rlc_um_nr_test: disable test9 until low TCP UL rates are understood/fixed"
...
This reverts commit e491aef74e
2021-11-14 16:25:09 +01:00
f99d6bc224
lib,rlc: changed get_bearer() to get_lcid().
2021-11-12 22:41:37 +00:00
3b150e26cb
rlc_am_nr: Changed header_t to HeaderType typename in RLC data structs.
...
Fix issue in clear_pdcp_sdu()
2021-11-12 22:41:37 +00:00
123ac16653
rlc_am_nr: fixed issue with pointers from rx entity to tx entity
2021-11-12 22:41:37 +00:00
f99e841421
Changed using a rlc_am_lte and rlc_am_nr entity, to a single rlc_am entity.
2021-11-12 22:41:37 +00:00
eefedcfccd
rlc_am_nr: renamed rlc_am_base to just rlc_am
2021-11-12 22:41:37 +00:00
aef87d5366
rlc_am_nr: Change rlc_am_base to use unique_ptr to hold rx/tx entities
2021-11-12 22:41:37 +00:00
779eda98bd
Temporarly silence unused variable warnings.
2021-11-12 22:41:37 +00:00
e780eb5ab0
Fixed missing TM and RLC AM NR in mem_pool
2021-11-12 22:41:37 +00:00
debb4a0c6b
Refactored RLC AM segment pool for re-use in both LTE and NR
...
Moved RLC AMD PDU definitions from rlc_am_lte.h to rlc_common.h to make them re-usable in both RLC LTE and RLC NR
2021-11-12 22:41:37 +00:00
54be15e7a6
Moved write pdu to rlc_am_base::rlc_am_base_rx
2021-11-12 22:41:37 +00:00
476f9e1156
Changed logger initialization in RLC AM entities
2021-11-12 22:41:37 +00:00
022c51493b
Refactored RLC AM NR/LTE Rx and Tx entities to use a rlc_am_base_rx/tx class.
...
This was done to make it easier to share entity specific code between LTE and NR.
This removes the previously used templates.
2021-11-12 22:41:37 +00:00
b15f63f32f
Added an RLC AM base class to avoid code duplication in the RLC AM NR entity.
...
This class is based on a template that receives as argument the
rlc_am_*_tx/rx entities, so that those are different for LTE and NR.
Moved code from rlc_am_lte/nr entities so that they use the new base class.
2021-11-12 22:41:37 +00:00
e65bcd7147
Changed default max S1 Setup retries to infinity
2021-11-12 15:09:39 +00:00
e5a83474cc
Added max_s1_setup retries option to S1AP
2021-11-12 15:09:39 +00:00
930e3699d0
Added max_s1_retries parameter
2021-11-12 15:09:39 +00:00
83c1fb65d7
nr,gnb,rrc: add rrc nr message handler and send functions to establish an SA RRC connection
2021-11-12 14:46:44 +00:00
02f261c0a9
rf: build srsran_rf as static library
...
For Ubuntu 18.04: Linking the static srsran_rf to libuhd
also requires to link Boost's "system" library.
Newer systems do not require this special handling.
2021-11-12 15:33:58 +01:00
085d561f65
skiq: allow running without root permissions
...
do what the comment says, when thread can't be created with privelages,
try to create it without them.
2021-11-12 15:33:36 +01:00
16753a006a
nr,gnb,rrc: add test logger delimiter; handle rrc setup complete
2021-11-11 10:55:35 +00:00
360f718a5e
Add PHY resource allocation calculation for SIB common 0 search space
2021-11-08 14:36:45 +00:00
9734f2e393
adt: fix optional_vector ctor, and add emplace method
2021-11-05 16:13:09 +00:00
0967cda042
gnb,stack: move gNB components into own folder
...
* move RRC, MAC, NGAP, SDAP into gnb folder
* move testing code below respective layers
2021-11-05 15:26:06 +01:00
951fea5f61
bearer_manager,rlc: reduce log level of message to warning level
...
relevant for the UE when it receives 2nd reconfiguration it could
be that the bearers are added again. in this case the handling is fine
and everything will work as expected. No reason to log error.
2021-11-05 15:26:06 +01:00
5f3afffd05
nr,gnb: implementation of sib and mib asn1 generation functions
2021-11-04 18:05:14 +00:00
96fd3aae3c
nr,gnb: small gnb interface refactors and fix of byte buffer operator=
2021-11-04 18:05:14 +00:00
2a5d21164f
Adding RLC AM NR unit tests
2021-11-04 16:12:07 +00:00
d528d8af4c
Added initial skeleton for RLC AM NR entity
2021-11-04 16:12:07 +00:00
2bb249bf09
Moved RLC AM LTE and NR packing functions to their own file.
2021-11-04 16:12:07 +00:00
f93d428e49
Moved RLC AM data structures to their own file
2021-11-04 16:12:07 +00:00
7e7f7b4c01
nr: fix failing unit tests
2021-11-04 15:24:57 +00:00
fa600ebda1
update sampling rate calculation from prb for nr
2021-11-04 15:24:57 +00:00
dab6e8bdcd
nr,gnb: updates in parsing and phy files to allow the splitting of NR and LTE stacks
2021-11-04 15:24:57 +00:00
1ead159f3f
backward: make signalhandler object static
...
having the sh a normal stack variable made the backtrace disappear
in some runs.
2021-11-04 14:53:41 +01:00
b44372faae
crash_handler: write backtrace to stderr instead of backtrace file
...
the backtrace file is hard to collect in some environment but the stdout
and stderr is usually captured by default.
2021-11-04 14:53:41 +01:00
8d719db43d
nr,gnb,mac: implement zero-copy get_dl_sched/get_ul_sched NR scheduler interface
2021-11-03 21:21:45 +01:00
ba50bbfb76
rlc,rrc,nr: remove rb_type from rlc_um_config
...
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-11-03 19:31:47 +01:00
9c2099f680
rrc,rlc,nr: fix RB label in RLC-NR for UE logs + ..
...
add rb_type in rlc_um_config
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-11-03 19:31:47 +01:00
d95c31d2de
rlc,rrc,nr: fix rlc bearer string diplayed in logs
...
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-11-03 19:31:47 +01:00
90d21f8426
Fix invalid log line formatting.
2021-11-03 16:51:33 +01:00
0bf2674d22
bearer_manager: reduce log level for clean/delete operations
...
this was causing errors in logs that aren't severe. the operations
are called when removing a UE regardless whether a bearer has been
created or not
2021-11-03 16:20:16 +01:00
f6e1ecdaf3
nr,gnb,mac: remove redundant checks and unused lcid enum constants
2021-11-03 13:31:16 +00:00
c615df9d1d
nr,gnb,mac: prioritize CRNTI CE handling over remaining SDUs and CEs in gNB mac receiver
2021-11-03 13:31:16 +00:00
4286ab81d9
nr,gnb,mac: fix const-correctness of some methods of class srsran::mac_sch_pdu_nr
2021-11-03 13:31:16 +00:00
74456bf3d2
Whitelist a reported deadlock involving read lock.
2021-10-29 12:45:47 +02:00
dfc2ea0a3e
nr,gnb,pdcp: extend the use of local rb_name member to pdcp nr
2021-10-28 21:21:46 +01:00
c64be663d2
nr,gnb,pdcp: store the PDCP RB name in base class for easier use
2021-10-28 21:21:46 +01:00
3c18e7c1f3
lte,enb,pdcp: fix addition of DRB logging in PDCP
2021-10-28 21:21:46 +01:00
5b8d4c39af
pdcp,lte: fix drb/srb id logging to account for dynamic mapping
2021-10-28 21:21:46 +01:00
e491aef74e
rlc_um_nr_test: disable test9 until low TCP UL rates are understood/fixed
2021-10-28 19:09:35 +02:00
296758e4ab
Revert "rlc_um_nr: reimplement update of RX_Next_Reassembly"
...
This reverts commit 5b025cfbf8
2021-10-28 19:09:35 +02:00
229b1eef21
radio,test: fix Coverity warning about dead code
...
add default in switch instead of using the the END state directly
that is checked before entering the switch. Coverity correctly
reports this as dead code.
2021-10-28 17:25:21 +02:00
8a53a9d35c
ssb_decode_test: Fix stack overflow pbch_msg buffer
2021-10-28 16:13:02 +02:00
6d0aafcf69
rlc_um_nr: fix has_missing_byte_segment() routine
...
return true if rx_window contains segment of this SN
2021-10-27 19:50:35 +02:00
5b025cfbf8
rlc_um_nr: reimplement update of RX_Next_Reassembly
2021-10-27 19:50:35 +02:00
2366dc286d
rlc_um_nr: improve logging
2021-10-27 19:50:35 +02:00
85e478d8ad
rlc_um_nr_test: add TC to reproduce reassembly issue
...
* add TC to reproduce reassembly issue that causes low TCP throughput
* fix PCAP writing
* fix other testcase to wait for t_reassembly to expire
2021-10-27 19:50:35 +02:00
ca7a377878
Fixes coverity 262740
2021-10-27 19:47:45 +02:00
4bd8b6f2de
Fixes coverity 359677
2021-10-27 19:47:45 +02:00
a14cc451d0
Addition NGAP cleanup
2021-10-27 19:37:49 +02:00
7f6801cb1e
ue_sync: fix 32bit compilation
...
fix printf format string on 32bit arches like ARMv7
FAILED: lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o
/usr/bin/gcc -DASSERTS_ENABLED -DENABLE_TIMEPROF -DENABLE_TTCN3 -DHAVE_BACKWARD -DHAVE_MBEDTLS -DHAVE_PCSC -I/usr/include/PCSC -I/usr/include/SoapySDR -Ilib/include -I../lib/include -Wno-unused-but-set-variable -Wall -Wno-comment -Wno-write-strings -Wno-unused-result -Wformat -Wmissing-field-initializers -Wtype-limits -std=c99 -fno-strict-aliasing -D_GNU_SOURCE -O3 -fno-trapping-math -fno-math-errno -DBUILD_TYPE_RELEASE -DIS_ARM -DHAVE_NEON -mfloat-abi=hard -mfpu=neon -fvisibility=hidden -fdiagnostics-color=always -Werror --param large-function-growth=1600 -O3 -DNDEBUG -fPIC -MD -MT lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o -MF lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o.d -o lib/src/phy/ue/CMakeFiles/srsran_ue.dir/ue_sync.c.o -c ../lib/src/phy/ue/ue_sync.c
In file included from ../lib/include/srsran/srsran.h:31,
from ../lib/src/phy/ue/ue_sync.c:13:
../lib/src/phy/ue/ue_sync.c: In function ‘srsran_ue_sync_set_tti_from_timestamp’:
../lib/include/srsran/phy/utils/debug.h:59:23: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘uint64_t’ {aka ‘long long unsigned int’} [-Werror=format=]
fprintf(stdout, "[DEBUG]: " _fmt "\n", ##__VA_ARGS__); \
^~~~~~~~~~~
../lib/src/phy/ue/ue_sync.c:1044:3: note: in expansion of macro ‘DEBUG’
DEBUG("rx time with 3gpp base in ms %lu\n", time_3gpp_msecs);
^~~~~
../lib/src/phy/ue/ue_sync.c:1044:41: note: format string is defined here
DEBUG("rx time with 3gpp base in ms %lu\n", time_3gpp_msecs);
~~^
%llu
cc1: all warnings being treated as errors
2021-10-27 18:03:03 +02:00
00b82bc772
Fix more issues in PHY lib
...
Fix variable shadowing issues in chest_test
Fix mutex unlock position in dft_fftw.c
CID 371598 Out of bounds access, in ssb_decode_test.c
2021-10-27 18:02:00 +02:00
9b74e3429c
Fix more Coverity issues in the PHY lib
...
CID 369560 Missing unlock, in dft_fftw.c
CID 363710 Logically dead code, in resampler.c
CID 55097 Result is not floating point, in chest_test_dl.c
CID 351020 Result is not floating point, in chest_nbiot_test_dl.c
2021-10-27 18:02:00 +02:00
b036da07de
Extend ASN1 utils function from_number()
2021-10-27 17:53:28 +02:00
0007473c7a
Initialize variable.
2021-10-27 17:39:51 +02:00
f539851128
Fix possible out-of-bounds-read.
2021-10-27 17:39:51 +02:00
1b2d77a49d
Fix possible out-of-bounds-read.
2021-10-27 17:39:51 +02:00
8753ea1be5
Fix coverty defects.
2021-10-27 17:39:51 +02:00
9c74dda039
rrc,nr: add msg5 and inactivity timers to RRC-NR
...
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-10-26 23:18:17 +02:00
edf0926a2f
Batch of LGTM fixes.
2021-10-26 21:49:17 +02:00
529e2bdf55
nr,rlc: call bsr update callback in RLC UM NR
2021-10-26 21:44:59 +02:00
7ad1ad800e
lte,enb,rlc: atomically compute DL buffer state and update the scheduler in the eNB
2021-10-26 21:44:59 +02:00
d972fb368c
Some LGTM fixes ( #3564 )
...
* Fix LGTM issues
* ue: add logging to switch on function
* Fix new LGTM issues
2021-10-26 21:15:36 +02:00
93649429dd
WIP: Fix Coverity issues in PHY lib ( #3507 )
...
Fix several Coverity issues
This commit adrresses the following code issues found by Coverity:
CID 339785 Division by zero, in fading_channel_test.c
CID 355272 Division by zero, in awgn_channel_test.c
CID 355277 NULL ptr dereference, in awgn_channel_test.c
CID 359663 NULL ptr dereference, in delay_channel_test.c
CID 369544 NULL ptr dereference, in chest_dl_nbiot.c
CID 373326 Resource Leak, in dft_fftw.c
CID 373329 Resource Leak, in dft_fftw.c
CID 372878 Division by zero, in sliv_test.c
CID 372871 Division by zero, in dmrs_pdcch.c
CID 370622 Negative loop bound, in csr_rs.c
CID 370624 Negative loop bound, in csr_rs.c
CID 370626 Negative loop bound, in csr_rs.c
CID's 369568, 369594 NULL ptr dereference, in ch_awgn.c
CID 369540 Logically dead code, in refsignal_dl.c
CID 369608 Logically dead code, in refsignal_ul.c
CIDs 366291, 366296, 366297 Out-of-bounds access, in zc_sequence.c
CID 372209 Division by zero, in cqi.c
CID 370992 Uninitialized pointer read, in pdcch_test.c
CID 373334 Integer overflow, in ue_sync.h
CID 370993, 370995 Undefined division, in pdcch_test.c
CID 370994 Undefined division, in ssb_decode_test.c
CIDs 353368 353364 353365 359673 353366 353367
Explicit null dereferenced, in psss_file_test.c
CID 371865 Unchecked return value, in rf_uhd_imp.cc
CID 363810 Undefined division, in ldpc_rm_chain_test.c
CID 372209, 372211, 372213, 372216 Undefined modulo, in cqi.c
CID 339834 Array compared against 0, in chest_dl.c
CID 369589 Out of bounds access, in dmrs_pucch.c
CID 371681 Out of bounds access, in ue_sync_nr_test.c
CIDs 370761, 370825 Copy-paste error, in ssb.c
CID 369599 out of bounds read, in dmrs_pdcch_test.c
CID 363795 out of bounds read, in ldpc_dec_c_avx2_flood.c
CID 363805 out of bounds read, in ldpc_dec_c_avx2long_flood.c
CID 363821 out of bounds read, in ldpc_dec_c_flood.c
2021-10-26 19:59:45 +02:00
dc31fb05a3
Fix ODR issue detected by ASAN in arch for the srsran_verbose global variable.
2021-10-26 16:56:11 +02:00
fa8e8ddf1f
Fix an ODR issue detected by ASAN in arch, where the global variable handler_registered was defined multiple times.
2021-10-26 16:56:11 +02:00
5d6b48311e
fixing a few regression bugs in embms
2021-10-26 15:35:18 +02:00
497e183487
rf_zmq_imp: disable Tx baseband scaling
...
until the correct gain settings are documented and potential
mis-configuration are handled. It seems that the default
Tx/rx gains values are not working with this function.
2021-10-26 14:56:44 +02:00
e2d26b5a8c
rlc_um_nr: log PDU without SN if full SDU is transmitted
...
PDUs that contain full SDUs don't have SNs, so the log should be
without it
2021-10-26 13:32:48 +02:00
3eb1862ab9
gnb_interface: reduce MAX_GRANTS to 4
...
see #3530 for detailed discussion. This change saves some CPU cycles it seems
2021-10-25 21:52:03 +02:00
32a1646536
nr,gnb,rrc: Derive RRC parameters from config.
...
* Derive RRC parameters from config.
* nr,gnb,rrc: hard code prach config index to 8 to avoid expiring RA proc window.
2021-10-25 20:54:32 +02:00
5ff6b2eaa9
Fix data race in ZMQ where nsamples and running variables could be read concurrently.
2021-10-25 20:30:57 +02:00
322f57a952
Initial real-time Tx gain setting ( #2976 )
...
* Make filename const in filesink
* Sine generation returns the next phase
* Avoid malloc/free in radio class
* Implement Tx gain in ZMQ
* Initial ratio RT gain test
* UHD: use timed Tx gain commands to align changes to subframes
* Minor improvement in test_radio_rt_gain
* Fix compilation
* Check RF gain thread id before joining
* Remove redundant zero initialization.
Co-authored-by: Fabian Eckermann <fabian@srs.io>
2021-10-25 10:54:17 +02:00
ebab12403f
Asynchronous NR PHY configuration ( #3527 )
...
* Fix a race condition when accessing the NR PHY cfg by the RRC and phy workers.
Rework how the phy cfg is handled, now workers have their own copy that gets updated after a reconfig moving it out of the state class.
* Default initialize sf_len member in sf_worker for consistency.
* Asynchronous NR PHY configuration
* Fix compilation
* Corrected method override and fix unitialised value
* Added carrier equal comparison to avoid aligment byte padding comparison
Co-authored-by: faluco <borja.ferrer@softwareradiosystems.com>
2021-10-25 10:51:02 +02:00
0ada9a01ec
Whitelist TSAN issue in srsenb::mac::sr_detected.
2021-10-23 21:26:00 +02:00
a1b2f3915d
Whitelist lock order inversion tsan issue in srsenb::rlc::rb_is_um.
2021-10-23 21:26:00 +02:00
8294724aad
gnb_interface: reduce MAX_GRANTS to 4
...
this significantly reduces data copies when providing the PHY
with scheduler results.
2021-10-23 21:09:26 +02:00
95bf85b3d3
Reduced maximum number of CSI reports
2021-10-23 17:23:08 +02:00
fbcffb84bd
Check if RLC is suspended before transmiting PDCP SDU.
...
This was done to avoid integrity issues, when the UE's RRC erroneously sent
measurement reports while the re-establishment was already in progress.
As errously sending PDCP PDUs on DRBs can cause issues as well, this was
disabled too.
2021-10-22 17:27:32 +01:00
9daa32e591
Configure the term timeout using the cmake definition
...
EXTRA_TERM_TIMEOUT_S
2021-10-22 13:52:07 +02:00
d9bdc3f83e
Add CSI resource information and fix segmentation fault
2021-10-22 12:46:44 +02:00
284207dad6
WIP: fixing collision in the the users_map
...
Signed-off-by: Carlo Galiotto <carlo@srs.io>
2021-10-21 23:26:46 +02:00
eace81d613
Fix UCI multiplexing for NR PUSCH
2021-10-21 22:14:00 +02:00
39bfcf4a5c
Add UCI valid in NR PUSCH info
2021-10-21 22:14:00 +02:00
7920e084b8
Revert "Do not abort tsan"
...
This reverts commit e8e1d101c553912f733070e71d020a33ec895280.
2021-10-21 21:31:21 +02:00
80c48a8b01
rlc: protect access to tx_enabled
2021-10-21 21:31:21 +02:00
bf566fbd29
radio: protect concurrent access from tx_end and tx
2021-10-21 21:31:21 +02:00
4239222909
Do not abort tsan
2021-10-21 21:31:21 +02:00
95b4a92f5f
Clarify the error messages printed when trying to open a RF device.
2021-10-21 17:51:51 +02:00
c6226b0d94
lte,enb,rrc: parse cellIndividualOffset in rr.conf and propagate it to measConfig sent to UE
2021-10-21 16:16:01 +01:00
65a2b35f09
Fix not checking initialization of S11 in MME. Fixed typo.
2021-10-21 14:50:44 +01:00
0b948d4098
Make sure that bind returns error if it cannot bind. Added test for SCTP bind error/success.
2021-10-21 14:50:44 +01:00
e721504f8e
Removed the sctp_init_server for consistency. Added listen method to unique_socket class.
2021-10-21 14:50:44 +01:00
e9a7e6dbae
Getting rid of sctp_init_client function. The only thing it does is call the sctp_init_socket function.
2021-10-21 14:50:44 +01:00
Pedro Alvarez
Ismael Gomez
Francisco
faluco
Andre Puschmann
Robert Falkenberg
Carlo Galiotto
Alejandro Leal Conejos
Bedran Karakoc
joaquim-SRS
Nils Fürste
Fabian Eckermann
yagoda
Fabian Eckermann
Xavier Arteaga
Xavier Arteaga