From 30ef479df9cee6b9ed809fcad9f23eea885986c9 Mon Sep 17 00:00:00 2001 From: microwavedcola1 Date: Fri, 1 Apr 2022 10:23:47 +0200 Subject: [PATCH] update Signed-off-by: microwavedcola1 --- README.md | 23 ++++++++++++++++------- ts/example.ts | 7 +------ 2 files changed, 17 insertions(+), 13 deletions(-) diff --git a/README.md b/README.md index 6eccded51..d29b8a40f 100644 --- a/README.md +++ b/README.md @@ -1,14 +1,22 @@ ### Development -* rustc 1.57.0 (f1edd0429 2021-11-29) -* anchor-cli 0.22.0 -* npm 8.1.2 -* node v16.13.1 + +- rust version 1.59.0 (9d1b2106e 2022-02-23) +- solana-cli 1.9.5 +- anchor-cli 0.22.0 +- npm 8.1.2 +- node v16.13.1 + +Devnet deployment - m43thNJ58XCjL798ZSq6JGAG1BnWskhdq5or6kcnfsD + +TS client - see ts dir, and ts/example.ts, run as `yarn ts-node ts/example.ts` ### Module structure + As and when we move to a more complete project, we should think of having multiple modules -e.g. core/shared, spot, perpetuals, etc., and then each would have its own instructions +e.g. core/shared, spot, perpetuals, etc., and then each would have its own instructions and state sub module. Goal is that new contributors find relevant code easily and can navigate easily. + ``` programs └── mango-v4 @@ -22,10 +30,11 @@ programs │ ├── lib.rs │ └── state # state goes here, each account state gets an individual file │ └── mod.rs - └── tests # rust tests, TODO + └── tests # rust tests, TODO ``` ### How to open and manage pull requests + - when in doubt dont squash commits, specially when merge request is very large, specially if your branch contains unrelated commits - use the why along with what for commit messages, code comments, makes it easy to understand the context -- add descriptions to your merge requests if they are non trivial, helps code reviewer watch out for things, understand the motivation for the merge request \ No newline at end of file +- add descriptions to your merge requests if they are non trivial, helps code reviewer watch out for things, understand the motivation for the merge request diff --git a/ts/example.ts b/ts/example.ts index 16c6a3af4..17962cc10 100644 --- a/ts/example.ts +++ b/ts/example.ts @@ -28,12 +28,7 @@ async function main() { ); const admin = Keypair.fromSecretKey( - Buffer.from( - JSON.parse( - // 6pkqDeYxxnysUEvyhvXx1JWzWNoKQFSB95hYTxvHj4R3 - fs.readFileSync(process.env.KEYPAIR!, 'utf-8'), - ), - ), + Buffer.from(JSON.parse(fs.readFileSync(process.env.KEYPAIR!, 'utf-8'))), ); const adminWallet = new Wallet(admin);