blockworks-foundation
/
mango-v4
mirror of https://github.com/blockworks-foundation/mango-v4.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fee buyback: Credit only perp fees that go to the dao (#479)

This commit is contained in:
Christian Kamm 2023-02-27 19:51:09 +01:00 committed by GitHub
parent 16599dd506
commit 9a13c1366a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
programs/mango-v4/src/state/orderbook/book.rs
View File

@ -356,16 +356,20 @@ fn apply_fees(
) -> Result<()> {
let quote_native = I80F48::from_num(market.quote_lot_size * quote_lots);
// The maker fees apply to the maker's account only when the fill event is consumed.
let maker_fees = quote_native * market.maker_fee;
let taker_fees = quote_native * market.taker_fee;
// taker fees should never be negative
require_gte!(taker_fees, 0);
// The maker fees apply to the maker's account only when the fill event is consumed.
// Part of the taker fees that go to the dao, instead of paying for maker rebates
let taker_dao_fees = (taker_fees + maker_fees.min(I80F48::ZERO)).max(I80F48::ZERO);
account
.fixed
.accrue_buyback_fees(taker_fees.floor().to_num::<u64>());
.accrue_buyback_fees(taker_dao_fees.floor().to_num::<u64>());
let perp_position = account.perp_position_mut(market.perp_market_index)?;
perp_position.record_trading_fee(taker_fees);
perp_position.taker_volume += taker_fees.to_num::<u64>();

4
programs/mango-v4/tests/cases/test_fees_buyback_with_mngo.rs
View File

@ -101,7 +101,7 @@ async fn test_fees_buyback_with_mngo() -> Result<(), TransportError> {
owner,
side: Side::Bid,
price_lots,
max_base_lots: 10,
max_base_lots: 20,
max_quote_lots: i64::MAX,
reduce_only: false,
client_order_id: 5,
@ -118,7 +118,7 @@ async fn test_fees_buyback_with_mngo() -> Result<(), TransportError> {
owner,
side: Side::Ask,
price_lots,
max_base_lots: 10,
max_base_lots: 20,
max_quote_lots: i64::MAX,
reduce_only: false,
client_order_id: 6,