From 596232fd907fd9693af5edfb315fa344279eac35 Mon Sep 17 00:00:00 2001
From: David Frank <bitinn@gmail.com>
Date: Wed, 29 Apr 2015 12:15:08 +0800
Subject: [PATCH] better test for headers, only support string and array

---
 lib/headers.js |  2 +-
 test/test.js   | 33 +++++++++++++++++++++++++++------
 2 files changed, 28 insertions(+), 7 deletions(-)

diff --git a/lib/headers.js b/lib/headers.js
index d94ced6..e784930 100644
--- a/lib/headers.js
+++ b/lib/headers.js
@@ -31,7 +31,7 @@ function Headers(headers) {
 
 		if (typeof headers[prop] === 'string') {
 			this.set(prop, headers[prop]);
-		} else if (headers[prop].length > 0) {
+		} else if (headers[prop] instanceof Array) {
 			headers[prop].forEach(function(item) {
 				self.append(prop, item);
 			});
diff --git a/test/test.js b/test/test.js
index 8dfd231..6a4168e 100644
--- a/test/test.js
+++ b/test/test.js
@@ -620,18 +620,39 @@ describe('node-fetch', function() {
 		});
 	});
 
-	it('should skip prototype when reading response headers', function() {
+	it('should ignore unsupported attributes while reading headers', function() {
 		var FakeHeader = function() {};
-		FakeHeader.prototype.c = 'string';
-		FakeHeader.prototype.d = [1,2,3,4];
+		FakeHeader.prototype.z = 'string';
+
 		var res = new FakeHeader;
 		res.a = 'string';
-		res.b = [];
+		res.b = ['1','2'];
+		res.c = '';
+		res.d = [];
+		res.e = { a:1 };
+		res.f = 1;
+		res.g = undefined;
+		res.h = null;
+		res.i = NaN;
+		res.j = true;
+		res.k = false;
+
 		var headers = new Headers(res);
+
 		expect(headers._headers['a']).to.include('string');
-		expect(headers._headers['b']).to.be.undefined;
-		expect(headers._headers['c']).to.be.undefined;
+		expect(headers._headers['b']).to.include('1');
+		expect(headers._headers['b']).to.include('2');
+		expect(headers._headers['c']).to.include('');
+
 		expect(headers._headers['d']).to.be.undefined;
+		expect(headers._headers['e']).to.be.undefined;
+		expect(headers._headers['f']).to.be.undefined;
+		expect(headers._headers['g']).to.be.undefined;
+		expect(headers._headers['h']).to.be.undefined;
+		expect(headers._headers['i']).to.be.undefined;
+		expect(headers._headers['j']).to.be.undefined;
+		expect(headers._headers['k']).to.be.undefined;
+		expect(headers._headers['z']).to.be.undefined;
 	});
 
 	it('should wrap headers', function() {