blockworks-foundation
/
node-fetch
mirror of https://github.com/blockworks-foundation/node-fetch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

handle common mistake of passing number as header

This commit is contained in:
David Frank 2015-05-04 12:05:06 +08:00
parent 60f819f0a0
commit a322795339
2 changed files with 36 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/headers.js
View File

@ -31,9 +31,13 @@ function Headers(headers) {
if (typeof headers[prop] === 'string') {
this.set(prop, headers[prop]);
} else if (typeof headers[prop] === 'number' && !isNaN(headers[prop])) {
this.set(prop, headers[prop].toString());
} else if (headers[prop] instanceof Array) {
headers[prop].forEach(function(item) {
self.append(prop, item);
self.append(prop, item.toString());
});
}
}

53
test/test.js
View File

@ -627,37 +627,46 @@ describe('node-fetch', function() {
it('should ignore unsupported attributes while reading headers', function() {
var FakeHeader = function() {};
FakeHeader.prototype.z = 'string';
// prototypes are ignored
FakeHeader.prototype.z = 'fake';
var res = new FakeHeader;
// valid
res.a = 'string';
res.b = ['1','2'];
res.c = '';
res.d = [];
res.e = { a:1 };
res.f = 1;
res.g = undefined;
res.h = null;
res.i = NaN;
res.j = true;
res.k = false;
// common mistakes, normalized
res.e = 1;
res.f = [1, 2];
// invalid, ignored
res.g = { a:1 };
res.h = undefined;
res.i = null;
res.j = NaN;
res.k = true;
res.l = false;
var headers = new Headers(res);
var h1 = new Headers(res);
expect(headers._headers['a']).to.include('string');
expect(headers._headers['b']).to.include('1');
expect(headers._headers['b']).to.include('2');
expect(headers._headers['c']).to.include('');
expect(h1._headers['a']).to.include('string');
expect(h1._headers['b']).to.include('1');
expect(h1._headers['b']).to.include('2');
expect(h1._headers['c']).to.include('');
expect(h1._headers['d']).to.be.undefined;
expect(headers._headers['d']).to.be.undefined;
expect(headers._headers['e']).to.be.undefined;
expect(headers._headers['f']).to.be.undefined;
expect(headers._headers['g']).to.be.undefined;
expect(headers._headers['h']).to.be.undefined;
expect(headers._headers['i']).to.be.undefined;
expect(headers._headers['j']).to.be.undefined;
expect(headers._headers['k']).to.be.undefined;
expect(headers._headers['z']).to.be.undefined;
expect(h1._headers['e']).to.include('1');
expect(h1._headers['f']).to.include('1');
expect(h1._headers['f']).to.include('2');
expect(h1._headers['g']).to.be.undefined;
expect(h1._headers['h']).to.be.undefined;
expect(h1._headers['i']).to.be.undefined;
expect(h1._headers['j']).to.be.undefined;
expect(h1._headers['k']).to.be.undefined;
expect(h1._headers['l']).to.be.undefined;
expect(h1._headers['z']).to.be.undefined;
});
it('should wrap headers', function() {