Commit Graph

38 Commits

Author SHA1 Message Date
Alexander Tesfamichael 70e8483ac6 Document response.ok convenience property 2017-04-30 19:59:33 +02:00
Kat Marchán e5ff203ef4 Revert "Allow passing agent option as an object (#236)" (#263)
This reverts commit ec29e3d264.

This patch prevents any agent being passed in which is not explicitly
an instance of `http.Agent`. This makes `node-fetch` no longer
compatible with https://npm.im/proxy-agent, which is one example of a
library that does not directly inherit from `http.Agent` directly.

Sorry for the revert -- I don't have an alternative patch because I
don't believe this is something node-fetch should be doing
automatically, because of how much of a limitation this could impose.

The original PR stated that this was to prevent requiring http/https,
and the effect would effectively be to force creation of an Agent on
every call. Note that this is already the behavior specified for
http.Agent when http.request received `false`. (See the bottom of the
[section on http.Agent in the Node
docs](https://nodejs.org/dist/latest-v7.x/docs/api/http.html#http_class_http_agent).

Cheers, and with apologies to @ahmadnassri for reverting their PR.
2017-04-08 18:33:46 -07:00
Ahmad Nassri ec29e3d264 Allow passing agent option as an object (#236) 2017-04-03 02:54:31 -07:00
Timothy Gu a345c398b3 More documentation 2017-02-26 16:52:32 -08:00
Timothy Gu d23204b4ec README: remove trailing whitespace 2017-02-26 13:18:41 -08:00
Ahmad Nassri 673ebb2089 docs(defaults): list of default header values (#237)
Fixes #226.
2017-02-21 12:38:54 -08:00
Timothy Gu 9351084a98 Update README for ES2015 2016-12-12 12:55:28 -08:00
Timothy Gu 8f3e886c7f Switch to Codecov
Fixes #186.
2016-10-15 09:17:47 -07:00
Dan Dascalescu e67b3a8579 Fix run-on sentence about Options (#168)
[ci skip]
2016-10-08 13:37:49 -07:00
Chris Veness f30cce86c4 Add 'post JSON' example to readme (#173) 2016-10-08 13:35:19 -07:00
David Frank ff38361a9e a document for error handling 2016-09-26 14:03:00 +08:00
David Frank 43e06ca422 add catch example to readme 2016-09-24 17:21:40 +08:00
David Frank e574b497d5 make sure example is working 2016-08-16 20:22:18 +08:00
Jimmy Karl Roland Wärting d8c6969736 added 2 binary exemple
Got to many "how do i handle binary/images" issues
2016-08-16 11:40:31 +02:00
David Frank 8cce714b48 changelog and documentation update 2016-08-03 18:02:26 +08:00
David Frank 1cd0a5c570 Update doc to show redirect mode 2016-04-06 03:25:16 +08:00
David Frank 364edcf04b doc update 2016-04-06 01:32:37 +08:00
David Frank 565ec4b35a additional tests for the new form-data integration 2015-07-22 15:40:52 +08:00
Dylan Piercey ffac4177b0 Automatically pull headers from node-form-data. 2015-07-22 02:05:06 +00:00
David Frank 55cde9e7de update document 2015-05-03 18:07:20 +08:00
Rhys Evans 5e4d9b1a60 expose response and headers constructors 2015-05-03 09:43:59 +01:00
David Frank 3f3d34d492 update doc and changelog 2015-04-17 13:31:58 +08:00
David Frank a8bb5650ad fix follow=0 scenario 2015-03-20 00:22:23 +08:00
David Frank 281037c795 travis and tests update, plus some doc clean up 2015-03-19 23:38:27 +08:00
David Frank f2984cb854 iojs support 2015-02-06 19:15:37 +08:00
David Frank e5487c106a Update README.md
simplify co example
2015-01-28 17:46:15 +08:00
David Frank be778b9d8c better tests and doc for res.ok 2015-01-28 12:17:12 +08:00
David Frank c737ad9482 doc update 2015-01-28 02:02:27 +08:00
David Frank 2e875d24b8 fix co example 2015-01-28 01:38:44 +08:00
David Frank bf874d06bb fix doc 2015-01-28 01:34:43 +08:00
David Frank 955b0c0719 update doc 2015-01-28 01:20:54 +08:00
David Frank ff81206c4a better test coverage 2015-01-28 01:00:53 +08:00
David Frank af21ae6c1c basic refactor done 2015-01-27 21:11:26 +08:00
David Frank 93a983d815 basic fetch feature done 2015-01-27 01:46:32 +08:00
David Frank 78853fc544 add test cases 2015-01-26 21:28:23 +08:00
David Frank 75699bb467 basic http added 2015-01-26 18:15:07 +08:00
David Frank 9c472a52f2 setup repo 2015-01-26 17:02:34 +08:00
David Frank 73861ddcb9 Initial commit 2015-01-26 15:29:27 +08:00