blockworks-foundation
/
solana
mirror of https://github.com/blockworks-foundation/solana.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

mechanism for disabling hash calc caching (#24437)

This commit is contained in:
Jeff Washington (jwash) 2022-04-18 22:44:30 -05:00 committed by GitHub
parent 94d3ec37d2
commit 0e0f306996
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
runtime/src/accounts_db.rs
View File

@ -5399,9 +5399,19 @@ impl AccountsDb {
return after_func(retval);
}
let should_cache_hash_data = CalcAccountsHashConfig::get_should_cache_hash_data();
let eligible_for_caching =
!config.use_write_cache && end.saturating_sub(start) == MAX_ITEMS_PER_CHUNK;
if eligible_for_caching && retval.is_empty() {
let range = bin_range.end - bin_range.start;
retval.append(&mut vec![Vec::new(); range]);
}
let mut file_name = String::default();
// if we're using the write cache, we can't cache the hash calc results because not all accounts are in append vecs.
if !config.use_write_cache && end.saturating_sub(start) == MAX_ITEMS_PER_CHUNK {
if should_cache_hash_data && eligible_for_caching {
let mut load_from_cache = true;
let mut hasher = std::collections::hash_map::DefaultHasher::new(); // wrong one?
@ -5443,10 +5453,6 @@ impl AccountsDb {
"{}.{}.{}.{}.{}",
start, end, bin_range.start, bin_range.end, hash
);
if retval.is_empty() {
let range = bin_range.end - bin_range.start;
retval.append(&mut vec![Vec::new(); range]);
}
if cache_hash_data
.load(
&Path::new(&file_name),

8
runtime/src/accounts_hash.rs
View File

@ -43,6 +43,14 @@ pub struct CalcAccountsHashConfig<'a> {
pub rent_collector: &'a RentCollector,
}
impl<'a> CalcAccountsHashConfig<'a> {
/// return true if we should cache accounts hash intermediate data between calls
pub fn get_should_cache_hash_data() -> bool {
// when we are skipping rewrites, we cannot rely on the cached data from old append vecs, so we have to disable caching for now
false
}
}
// smallest, 3 quartiles, largest, average
pub type StorageSizeQuartileStats = [usize; 6];