ammend clarifying comment for duplicate instance detection (#31008)

This commit is contained in:
Jeff Biseda 2023-03-31 12:50:04 -07:00 committed by GitHub
parent 9600643860
commit 0e2c6c8989
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 8 deletions

View File

@ -439,14 +439,12 @@ impl NodeInstance {
Self { wallclock, ..*self }
}
// Returns true if the crds-value is a duplicate instance
// of this node, with a more recent timestamp.
// The older instance is considered the duplicate instance because:
// - If a staked node is restarted it will receive its old instance value
// from gossip. Considering the new instance as the duplicate would
// prevent the node from restarting.
// - Similarly, hotswap relies on the the old instance being considered the
// duplicate instance.
// Returns true if the crds-value is a duplicate instance of this node,
// with a more recent timestamp.
// The older instance is considered the duplicate instance. If a staked
// node is restarted it will receive its old instance value from gossip.
// Considering the new instance as the duplicate would prevent the node
// from restarting.
pub(crate) fn check_duplicate(&self, other: &CrdsValue) -> bool {
match &other.data {
CrdsData::NodeInstance(other) => {