From 3e1214a871638d18c7ba59dd9c2cd611a3ab357d Mon Sep 17 00:00:00 2001 From: Greg Fitzgerald Date: Mon, 15 Apr 2019 15:03:44 -0600 Subject: [PATCH] Don't add reviewers to draft PRs (#3780) --- CONTRIBUTING.md | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e3daae2cef..8e321af15c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -46,10 +46,17 @@ and longer descriptions detailing what problem it solves and how it solves it. Draft Pull Requests --- -If you want early feedback on your PR, use GitHub's "Draft Pull Request" mechanism. Draft -PRs are a convenient way to collaborate with the Solana maintainers without triggering -notifications as you make changes. When you feel your PR is ready for a broader audience, -you can transition your draft PR to a standard PR with the click of a button. +If you want early feedback on your PR, use GitHub's "Draft Pull Request" +mechanism. Draft PRs are a convenient way to collaborate with the Solana +maintainers without triggering notifications as you make changes. When you feel +your PR is ready for a broader audience, you can transition your draft PR to a +standard PR with the click of a button. + +Do not add reviewers to draft PRs. GitHub doesn't automatically clear approvals +when you click "Ready for Review", so a review that meant "I approve of the +direction" suddenly has the appearance of "I approve of these changes." Instead, +add a comment that mentions the usernames that you would like a review from. Ask +explicitly what you would like feedback on. Rust coding conventions ---